Re: [PATCH v1 08/26] x86/virt/tdx: Add tdx_enable_ext() to enable of TDX Module Extensions

Xu Yilun
2025-11-24T11:07:11Z

> A few more nits, though. Please don't talk about things in terms of
> number of pages. Just give the usage in megabytes.

Yes.

...

> > -#define TDH_SYS_CONFIG 45
> > +#define TDH_SYS_CONFIG (45 | (1ULL << TDX_VERSION_SHIFT))
>
> That's my theory: we don't need to keep versions.

Good to know.

...

> > The TDX Module can only accept one root page (i.e. 512 HPAs at most), while
> > struct tdx_page_array contains the whole EXT memory (12800 pages). So we
> > can't populate all pages into one root page then tell TDX Module. We need to
> > populate one batch, tell tdx module, then populate the next batch, tell
> > tdx module...
>
> That is, indeed, the information that I was looking for. Can you please
> ensure that makes it into code comments?

Yes.