Re: [PATCH v1 06/26] x86/virt/tdx: Add tdx_page_array helpers for new TDX Module objects

Xu Yilun
2025-11-20T08:49:09Z

> For clarity for Yilun, be circumspect on scope-based-cleanup usage for
> arch/x86/virt/,

Yes. I think I should drop __free() here. But allow me to keep the kAPIs
definitions like:

void tdx_page_array_free(struct tdx_page_array *array);
DEFINE_FREE(tdx_page_array_free, struct tdx_page_array *, if (_T) tdx_page_array_free(_T))

So I can use __free() elsewhere.

> but for TSM driver bits in drivers/virt/, do feel free
> to continue aggressive avoidance of goto.

Yes.