Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Heiner Kallweit <hkallweit1@gmail.com>
To: Bjorn Helgaas <bhelgaas@google.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	Linux PM <linux-pm@vger.kernel.org>
Subject: [PATCH] PCI: Forbid RPM on ACPI systems before 5.0 only
Date: Mon, 17 Jan 2022 11:51:54 +0100	[thread overview]
Message-ID: <cadbd4eb-40bb-1fa8-1e00-dc95dab62295@gmail.com> (raw)

Currently PCI core forbids RPM and requires opt-in from userspace,
apart from few drivers calling pm_runtime_allow(). Reason is that some
early ACPI PM implementations conflict with RPM, see [0].
Note that as of today pm_runtime_forbid() is also called for non-ACPI
systems. Maybe it's time to allow RPM per default for non-ACPI systems
and recent enough ACPI versions. Let's allow RPM from ACPI 5.0 which
was published in 2011.

[0] https://lkml.org/lkml/2020/11/17/1548

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 drivers/pci/pci.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 428afd459..26e3a500c 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -3101,7 +3101,12 @@ void pci_pm_init(struct pci_dev *dev)
 	u16 status;
 	u16 pmc;
 
-	pm_runtime_forbid(&dev->dev);
+#ifdef CONFIG_ACPI
+	/* Some early ACPI PM implementations conflict with RPM. */
+	if (acpi_gbl_FADT.header.revision > 0 &&
+	    acpi_gbl_FADT.header.revision < 5)
+		pm_runtime_forbid(&dev->dev);
+#endif
 	pm_runtime_set_active(&dev->dev);
 	pm_runtime_enable(&dev->dev);
 	device_enable_async_suspend(&dev->dev);
-- 
2.34.1


             reply	other threads:[~2022-01-17 10:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-17 10:51 Heiner Kallweit [this message]
2022-01-17 23:35 ` [PATCH] PCI: Forbid RPM on ACPI systems before 5.0 only Bjorn Helgaas
2022-01-18  8:06   ` Heiner Kallweit
2022-01-18 16:09     ` Bjorn Helgaas
2022-01-18 16:28 ` Rafael J. Wysocki
2022-01-18 16:56   ` Heiner Kallweit
2022-01-18 17:11     ` Rafael J. Wysocki
2022-01-18 17:42       ` Heiner Kallweit
2022-01-19 19:38         ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cadbd4eb-40bb-1fa8-1e00-dc95dab62295@gmail.com \
    --to=hkallweit1@gmail.com \
    --cc=bhelgaas@google.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox