From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Lukas Wunner <lukas@wunner.de>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org,
Mahesh J Salgaonkar <mahesh@linux.ibm.com>,
Oliver O'Halloran <oohall@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 1/2] PCI: Add TLP Prefix reading into pcie_read_tlp_log()
Date: Thu, 4 Apr 2024 12:51:20 +0300 (EEST) [thread overview]
Message-ID: <cc4f4e53-22d3-b5b0-bc9d-3156bfec6652@linux.intel.com> (raw)
In-Reply-To: <Zg50P2JcpvO8S-a7@wunner.de>
[-- Attachment #1: Type: text/plain, Size: 888 bytes --]
On Thu, 4 Apr 2024, Lukas Wunner wrote:
> On Wed, Apr 03, 2024 at 01:02:05PM +0300, Ilpo Järvinen wrote:
> > pcie_read_tlp_log() handles only 4 TLP Header Log DWORDs but TLP Prefix
> > Log (PCIe r6.1 secs 7.8.4.12 & 7.9.14.13) may also be present.
> >
> > Generalize pcie_read_tlp_log() and struct pcie_tlp_log to handle also
> > TLP Prefix Log. The layout of relevant registers in AER and DPC
> > Capability is not identical but the offsets of TLP Header Log and TLP
> ^^^ ^^^
> Somehow this doesn't seem to make sense. Is the "not" perhaps wrong here?
Hi Lukas,
How about changing it into plural and adding a comma:
The layouts of relevant registers in AER and DPC Capabilities are not
identical, but ...
Does that sound better?
> > Prefix Log vary so the callers must pass the offsets to
> > pcie_read_tlp_log().
--
i.
next prev parent reply other threads:[~2024-04-04 9:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-03 10:02 [PATCH v2 0/2] PCI: Consolidate TLP Log reading and printing Ilpo Järvinen
2024-04-03 10:02 ` [PATCH v2 1/2] PCI: Add TLP Prefix reading into pcie_read_tlp_log() Ilpo Järvinen
2024-04-04 9:34 ` Lukas Wunner
2024-04-04 9:51 ` Ilpo Järvinen [this message]
2024-04-03 10:02 ` [PATCH v2 2/2] PCI: Create helper to print TLP Header and Prefix Log Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc4f4e53-22d3-b5b0-bc9d-3156bfec6652@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lukas@wunner.de \
--cc=mahesh@linux.ibm.com \
--cc=oohall@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox