From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28A25221D9E for ; Thu, 27 Nov 2025 14:12:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764252735; cv=none; b=iauGH8HwDkXXzLzhyiPkZJQpXzeMOicUTYYhwRYE3ilIUwSo4EHQKdyyH2G499dxkOoQ5Yrab6aRHsMmRIrxmyRYPIrbBOYdfDLqqLyhpHHnkVOUCGq0H4canfzTR1ahR07EwPwHj24IkKbr1jLiK8qKsMdeQold3LThWDLzxNQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764252735; c=relaxed/simple; bh=lPbejQRzLGwK7I1gopu3GY5ha7xC6bHJ9U4GIaoCZNU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GLZqMoziYlSXmcKOKEnOI5gfONk3nomDpZIoJ4kOaMkdMkEY6qpDUFzBBWNPzzWYX+Oxd1mgylIoxRYKMhys5N1GVCysJRLr0oAx1B4x+8llek4UGEIg/K8ND9Veu8t9OK9wgbQeWiQgZYAQ1hXh/0ABztvWnPYpRzc1KAGIHUo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=A0N1gQMm; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NRqkyJr2; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="A0N1gQMm"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NRqkyJr2" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5ARD2Jex1022580 for ; Thu, 27 Nov 2025 14:12:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= fCiYRHPq3rlvKmF8kWI43Q2cFwW+J8eYLT37CyJ1pt8=; b=A0N1gQMm7AHEOGho fZk5FoOnO2+O0SloBk+NsTwB2zW7qUOxS1QSUsx5/9bkx4aANfbc4Q6RDYGFfzqi cz10Pi5o/vVk9yJXWr/VJMFPYYrZvGsG827i/ZQqbPbA/7vq+josK2xxx4AzjniA Dkq6vm+qGtLgYVZ5NXhT/3VkHJxqxxLBsOt1OgLCHy4O7FoOJuz7cfQBJAknIhjX v7BmEU4+mIr3u3Nx+dDDwqUtRMdg/sIzCbhZzO6gSjUJLXcq6xjTrdmPEdJIKaEq SmXyEMkoFYfv+ZGrIVGJIbFlBiDOIB843VOazVfSv6W460R/BaB4kM1sq84J/3ba gEgvKw== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4apq66g4ww-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 27 Nov 2025 14:12:12 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4ed5ff5e770so1394281cf.3 for ; Thu, 27 Nov 2025 06:12:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764252732; x=1764857532; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fCiYRHPq3rlvKmF8kWI43Q2cFwW+J8eYLT37CyJ1pt8=; b=NRqkyJr2hjNxCyUcz7N0LgMLyt3dmuQIVxSZFpOE4g2dLNj8AiIFcDLyqF0/Ai2bCI gmV2FULh/8k9jCiAAHfwB7fFSJbnmLe6uaeyUH8g6xrKbKB2PuVe9sv1V/WecLXcVqhO soQRuDZUDrotOv8tMTkD1rzDrmFXsxxIsHUndCg8SmhsZ9MX90DPm7y68hdbWV6OunFA UuKuzkQvRSsSksLJhimblPo3Wowvwd7gemO+VNz+Pa1NjTGXjnzIK9+cElsFeJ7EUSZR 37q8MUtDU00/wk+qYOYhcTUPKSiHA2bMxOdiwniOwRzGvO2PH/bMt6j8D565uEh9Nw2D ZxIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764252732; x=1764857532; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fCiYRHPq3rlvKmF8kWI43Q2cFwW+J8eYLT37CyJ1pt8=; b=c+YeThdsc3VfKQNPJHuW5Hg41BK2ECgqUqPJYho3XI6+iI2SCnRKGD7YD7IJaiFka8 6LELG8bg4haU52Hw6G6wVrwEpVCsVlZ6fCxN8gf2G/LZ/ryPfH2EpQTokyW7Ys5G8Aqe S6txBF/Dvv3y/RrnkD1/4vHjG9OloEfq0qK9wxzncTtc0OVQlJQOijoBUmWMneEOZzUA yyrp1zfthguT0iQBfTu1hhKALDca0XJjoQPYJAM+Fjxw9HDDM+xI7sO0zRD5TnmS4koF jZSY+BJ8fX2FWMZqqyfDX2TNccx8cbk7iXCGzR3VLmVGje9+AyqhnWN7/rxsnyekQbn8 DCrQ== X-Forwarded-Encrypted: i=1; AJvYcCVlrCINv8Ydb6FhMW5NiBSLZmHKL3GKLeFaZNNjxgolciXiT7G1rIxl87cAZpKTzLuKxrXHxMvWI7o=@vger.kernel.org X-Gm-Message-State: AOJu0YyQiv+OCCfHzWPhuzBC1Lmk5YygtfU8EkaaY6ToZUHGgUUj+jpe 5IQluahDdiisvspHTGUmer5QX/UpB9Fgz1a2lMZ1atO3O5Rl4nipTjZB92P7JJzVhzkRuHhWbMn DbK5dFl9qpF/wUFtKu+++eEefK3IpEQ9dBC7tIO2XY5FwEA9eD1geUtDs1tTR47c= X-Gm-Gg: ASbGncszt7lKyDd4DTYacPAjNhwiffZZAfqZzME/5TO+GctSo3/UwjglV9Q8wG2IlZA kPFiR6pq0IHo4dFyVXvjh7UDZ0CN6grqfoJmiUwIh1f/8LJZBLbhQci89yXrag6MvaWx3YsER9U ryTMbqgx9bXZRqrFiPcBbKKvm1k1LA1lZBkM9ChMyl9+hZJU8jb0Rr0jRrUXPNrUN6DbSMFgxlc dFv4FgmJayKG5kkADp7CHoElBopeZ/8M2pRG6EzyhjJtpor7yWdpE5w12VlVIAgTKeR2bx6/bMg DSz5cJ21ZqMKiG4KyTs39iaL7xxa83FoBAB6rMDXHZt8rm7VQvNxXK+zCCNd+eOIEIce73xJrS2 ficsmYMLWRxNU++rqQfBOmLrEND923+d0nCSw7O7Bulrvam2ITS2KewIh9elXKncO+fo= X-Received: by 2002:a05:622a:144d:b0:4ee:2638:ea2 with SMTP id d75a77b69052e-4ee58930d72mr245470391cf.9.1764252732237; Thu, 27 Nov 2025 06:12:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IHAENiG2NWzvRUpC2N3DyEf6LKMfN1Rk9Nazrw11y8MKYBoWmJU39W3UKHkR1LhJjRLAlv1gQ== X-Received: by 2002:a05:622a:144d:b0:4ee:2638:ea2 with SMTP id d75a77b69052e-4ee58930d72mr245469471cf.9.1764252731408; Thu, 27 Nov 2025 06:12:11 -0800 (PST) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64751062081sm1632438a12.34.2025.11.27.06.12.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Nov 2025 06:12:10 -0800 (PST) Message-ID: Date: Thu, 27 Nov 2025 15:12:08 +0100 Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] PCI: qcom: Clear ASPM L0s CAP for MSM8996 SoC To: Manivannan Sadhasivam Cc: Manivannan Sadhasivam , lpieralisi@kernel.org, kwilczynski@kernel.org, bhelgaas@google.com, robh@kernel.org, linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov References: <20251126081718.8239-1-mani@kernel.org> <7rmiof6lxrr27vd4rnilc6ynxj7c2eiv33uw62lt4sheylpjny@6m2nuqnbnifc> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <7rmiof6lxrr27vd4rnilc6ynxj7c2eiv33uw62lt4sheylpjny@6m2nuqnbnifc> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: m9n9-3BUffMmzXvyh1L6kWPHioBqII7p X-Proofpoint-ORIG-GUID: m9n9-3BUffMmzXvyh1L6kWPHioBqII7p X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI3MDEwNSBTYWx0ZWRfX6XseshtBPaWL OgIzLiw2f/GEJHbvIfKjVorCH6ogOxSEkpeyudJpuc/ckt8sn+osHH4EFDFD8TJWW7PyYzeHzwP OpSz/N0YMGPnmpeVMBad0k0iMXNVQYDEICIe9horUbyjJokAsJ5HGqC0oUHSsrE3rRe5+pS4rUL acJrIAf6+1ZYZwctELTg/c1UNioMw7MzzGSIPndgV24hw6LVOfAP0Ml4WN0ce9KO2v3wGDlso0A WI1HqzzGcE7mkL9x5NTMcThDEMfPvBXgMKGbS+fKAsLcJAOJXkHj1wan49YCLNLFoqOtuqkR26C /8Krk6iR+Oztaf+dLk/sHHxfXXHkCcDyMrr6chBQPkNIARx8ZtJJjdjj/kN4Zqcl79tme9wIWcA 3L/B+3kWg9VuT6WXChBCUQs/1pCi8g== X-Authority-Analysis: v=2.4 cv=BYHVE7t2 c=1 sm=1 tr=0 ts=69285c3c cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=BQ-7DGIy8I7IhXLRZ7wA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-25_02,2025-11-27_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0 bulkscore=0 priorityscore=1501 spamscore=0 clxscore=1015 suspectscore=0 malwarescore=0 phishscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511270105 On 11/27/25 2:55 PM, Manivannan Sadhasivam wrote: > On Thu, Nov 27, 2025 at 11:55:15AM +0100, Konrad Dybcio wrote: >> On 11/26/25 9:17 AM, Manivannan Sadhasivam wrote: >>> From: Manivannan Sadhasivam >>> >>> Though I couldn't confirm the ASPM L0s support with the Qcom hardware team, >>> bug report from Dmitry suggests that L0s is broken on this legacy SoC. >>> Hence, clear the L0s CAP for the Root Ports in this SoC. >> >> FWIW if we trust the downstream DT, we have this hunk: >> >> arch/arm64/boot/dts/qcom/msm8996.dtsi >> 1431: qcom,l1-supported; >> 1432: qcom,l1ss-supported; >> 1586: qcom,l1-supported; >> 1587: qcom,l1ss-supported; >> 1739: qcom,l1-supported; >> 1740: qcom,l1ss-supported; >> >> But also funnily enough, msm8996auto boards specifically manually >> do a /delete-property/ on those.. >> >> (there exists one 'qcom,l0s-supported', but it's NOT set for 8996, 98, >> or 845) >> >> On msm-4.14, this became "qcom,no-l0s/l1/l1ss-supported". This forbids L0s >> on at least 8150 and 8250. >> >> Later, both hosts on SM8350 and SM8450-PCIe0 (not 1) forbid L0s. >> > > Thanks for digging in. Unfortunately, I have to rely on word of mouth to get the > ASPM capability as there is no proper doc that says which SoC supports which > state. And, I'm quite nervous to trust downstream DTS as they were not very > accurate in describing the hardware capabilities. But I think we should atleast > consider the 'no-l0s' properties seriously. > > Let me go through all DTS and build try to build a sane ASPM compatibility > table. But just be clear, the above exercise should not block this patch as it > fixes a real issue that has been reported. Yeah definitely fwiw Reviewed-by: Konrad Dybcio >> SM8350-PCIe0 sets 'qcom,l1ss-sleep-disable' which influences some RPMh >> things, but also prevents some clock ops wrt the CLKREF source >> > > We can ignore 'qcom,l1ss-sleep-disable' as it is a Qcom low power feature built > around PCIe L1ss, which is not yet supported in upstream. OK thanks Konrad