From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C93FC7EE22 for ; Sat, 6 May 2023 12:03:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231569AbjEFMD0 (ORCPT ); Sat, 6 May 2023 08:03:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232125AbjEFMDZ (ORCPT ); Sat, 6 May 2023 08:03:25 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4156311610 for ; Sat, 6 May 2023 05:03:20 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-4ec8149907aso3195244e87.1 for ; Sat, 06 May 2023 05:03:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683374598; x=1685966598; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=iDA1o5DOpOhngrWpyHFqKpT+FKuc32+BdG6EdkURD0I=; b=XzsoB368bAHnBWpU15NLULOnKVfBGXSJfEvW60ldEpQwUiYs0l6Bvd8VpTBDHnGF20 bQQLcEtJLmrha2Tc9BwlkAC5lWVI4fY9CyGbrRWVFD6TsyJUUwZ0NOMpaz4ZF3jmTP2c LgFmeetudSh9VhiaWcwy2fXQGczMPPPMs1MtO8tb2Hz0u+mYuV2ociKPzAGarAC/xTNn g9Y00e5pjXMZzFnE9wz+LAbZs10L5EzOJUSLB7H3YgQivJb5H8C0JFFqtuVmqkTMqB0k plBOmAqf9cCTjOdbyGHEzJrzSoxfhCTQuLMzKuMfjYJgQt1HhwLJcerE6vcio/dYDrkR O2Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683374598; x=1685966598; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iDA1o5DOpOhngrWpyHFqKpT+FKuc32+BdG6EdkURD0I=; b=BgVyMkZYtucuZ/decqCcV1lj4H95JrwRYS6PxT6AGWDYhjPh0bBzD2zgiPhTCZURRf p0JWrBDXDNXA1rV5O/c81odH9KRlCoUMFlXe6xD4cVG4mhB5Pg2eaAOpwpwI5tPr+VTr BVT02l6icjGo1imgLDpitO5FJIAdqc+z50jZcRXt4EVdSPXPv8saF5s/6eqXTtrXe+6x RT/Ul5yjV7dMnRVxdNfy+qVtBwqSpI3XRv7IbN4N5tZ4IGuwPfh3mlmJIC7zxeAL0hTk dnotVUqwXjlwa3auJXO2rHIrD+d9j49q7Y0/ryeD/VpzJeCtNyFJag2gubnDLARCofqe e2rg== X-Gm-Message-State: AC+VfDyRq5HEhj/+QMUcF7GiNSWwpDu7fMmFM0whedjr3G8ob+vh51b7 p487Ecqeaa2bFZA0KH0hT6ufDA== X-Google-Smtp-Source: ACHHUZ657exLovcKVKLg88kAQmx0RX8h5aAvhO9CpNbhD2LkobNTGOHPK+ztRA1IPGF2OD+m5vgyww== X-Received: by 2002:a05:6512:1026:b0:4eb:7e:1fa5 with SMTP id r6-20020a056512102600b004eb007e1fa5mr1102362lfr.8.1683374598443; Sat, 06 May 2023 05:03:18 -0700 (PDT) Received: from ?IPV6:2001:14ba:a0db:1f00::8a5? (dzdqv0yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a0db:1f00::8a5]) by smtp.gmail.com with ESMTPSA id o3-20020a056512050300b004efe9a169d2sm632963lfb.64.2023.05.06.05.03.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 06 May 2023 05:03:17 -0700 (PDT) Message-ID: Date: Sat, 6 May 2023 15:03:17 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 1/8] PCI: qcom: Use DWC helpers for modifying the read-only DBI registers Content-Language: en-GB From: Dmitry Baryshkov To: Manivannan Sadhasivam , lpieralisi@kernel.org, kw@linux.com, bhelgaas@google.com Cc: robh@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, steev@kali.org, quic_srichara@quicinc.com References: <20230506073139.8789-1-manivannan.sadhasivam@linaro.org> <20230506073139.8789-2-manivannan.sadhasivam@linaro.org> <81d5643b-3aec-a987-eaf4-e89b0887ce64@linaro.org> In-Reply-To: <81d5643b-3aec-a987-eaf4-e89b0887ce64@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On 06/05/2023 14:43, Dmitry Baryshkov wrote: > On 06/05/2023 10:31, Manivannan Sadhasivam wrote: >> DWC core already exposes dw_pcie_dbi_ro_wr_{en/dis} helper APIs for >> enabling and disabling the write access to read only DBI registers. So >> let's use them instead of doing it manually. >> >> Also, the existing code doesn't disable the write access when it's done. >> This is also fixed now. >> >> Fixes: 5d76117f070d ("PCI: qcom: Add support for IPQ8074 PCIe >> controller") >> Signed-off-by: Manivannan Sadhasivam >> --- >>   drivers/pci/controller/dwc/pcie-qcom.c | 10 +++++----- >>   1 file changed, 5 insertions(+), 5 deletions(-) > > Reviewed-by: Dmitry Baryshkov Of course: Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry