Linux PCI subsystem development
 help / color / mirror / Atom feed
From: ALOK TIWARI <alok.a.tiwari@oracle.com>
To: Manivannan Sadhasivam <mani@kernel.org>
Cc: daire.mcnamara@microchip.com, lpieralisi@kernel.org,
	kwilczynski@kernel.org, bhelgaas@google.com, robh@kernel.org,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	Xichao Zhao <zhao.xichao@vivo.com>
Subject: Re: [External] : Re: [PATCH] PCI: plda: Remove the use of dev_err_probe()
Date: Mon, 15 Sep 2025 18:55:29 +0530	[thread overview]
Message-ID: <cf18193a-5a49-4e0c-b07a-a4f705fc5c8c@oracle.com> (raw)
In-Reply-To: <cl52jts26ulfcanbzz42w35g3bcjlwfhteph2oze4drveajzg3@a4kq3cxfzn2l>

Hi Mani,

On 9/8/2025 3:43 PM, Manivannan Sadhasivam wrote:
> On Wed, Aug 20, 2025 at 04:52:00PM GMT, Xichao Zhao wrote:
>> The dev_err_probe() doesn't do anything when error is '-ENOMEM'.
>> Therefore, remove the useless call to dev_err_probe(), and just
>> return the value instead.
>>
> 
> Change is fine as it is. But I think devm_pci_alloc_host_bridge() should return
> the actual error pointer instead of NULL and let the callers guess the errno.
> 
> Callers are using both -ENOMEM and -ENODEV, both of then will mask the actual
> errno that caused the failure.
> 
> Cleanup task for someone interested :)
> 
> - Mani

Did you really intend to do that,
Should that be an RFC (for cleanup task) patch ?

Thanks,
Alok

  reply	other threads:[~2025-09-15 13:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-20  8:52 [PATCH] PCI: plda: Remove the use of dev_err_probe() Xichao Zhao
2025-09-08 10:13 ` Manivannan Sadhasivam
2025-09-15 13:25   ` ALOK TIWARI [this message]
2025-09-15 14:07     ` [External] : " Manivannan Sadhasivam
2025-09-15 19:10       ` ALOK TIWARI
2025-09-08 10:16 ` Manivannan Sadhasivam
2025-09-12 22:09 ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cf18193a-5a49-4e0c-b07a-a4f705fc5c8c@oracle.com \
    --to=alok.a.tiwari@oracle.com \
    --cc=bhelgaas@google.com \
    --cc=daire.mcnamara@microchip.com \
    --cc=kwilczynski@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=mani@kernel.org \
    --cc=robh@kernel.org \
    --cc=zhao.xichao@vivo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox