From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Frank Li <Frank.li@nxp.com>
Cc: manivannan.sadhasivam@linaro.org, bhelgaas@google.com,
conor+dt@kernel.org, devicetree@vger.kernel.org,
festevam@gmail.com, helgaas@kernel.org, hongxing.zhu@nxp.com,
imx@lists.linux.dev, kernel@pengutronix.de,
krzysztof.kozlowski+dt@linaro.org, kw@linux.com,
l.stach@pengutronix.de, linux-arm-kernel@lists.infradead.org,
linux-imx@nxp.com, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, lpieralisi@kernel.org,
robh@kernel.org, s.hauer@pengutronix.de, shawnguo@kernel.org
Subject: Re: [PATCH v5 04/16] dt-bindings: imx6q-pcie: Add linux,pci-domain as required for iMX8MQ
Date: Sun, 24 Dec 2023 10:02:28 +0100 [thread overview]
Message-ID: <cf231452-e1e6-44bd-bff4-c699d5f2a53a@linaro.org> (raw)
In-Reply-To: <ZYeznY7gXM+zoQeB@lizhi-Precision-Tower-5810>
On 24/12/2023 05:29, Frank Li wrote:
> On Sat, Dec 23, 2023 at 07:40:28PM +0100, Krzysztof Kozlowski wrote:
>> On 20/12/2023 22:36, Frank Li wrote:
>>> iMX8MQ have two pci controllers. Adds "linux,pci-domain" as required
>>> proptery for iMX8MQ to indicate pci controller index.
>>
>>
>> Why it has to be required? Everything will work fine if skipped.
>> Otherwise please provide reason why it must be *required*.
>
> Next patch will use "linux,pci-domain" as PCI slot ID, instead compared
> with hard code register address.
>
> The below code will be removed.
>
> - if (dbi_base->start == IMX8MQ_PCIE2_BASE_ADDR)
> - imx6_pcie->controller_id = 1;
>
>
> when there are more than 2 controller, this compare logic will become
> complex.
>
> So after next patch, "linux,pci-domain" will be required.
Nothing in commit msg explains this. Why you cannot use some
auto-incremented values when this is missing?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-12-24 9:02 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 21:35 [PATCH v5 00/16] PCI: imx6: Clean up and add imx95 pci support Frank Li
2023-12-20 21:36 ` [PATCH v5 01/16] PCI: imx6: Simplify clock handling by using bulk_clk_*() function Frank Li
2023-12-20 21:36 ` [PATCH v5 02/16] PCI: imx6: Simplify phy handling by using by using IMX6_PCIE_FLAG_HAS_PHY Frank Li
2023-12-20 21:36 ` [PATCH v5 03/16] PCI: imx6: Simplify reset handling by using by using *_FLAG_HAS_*_RESET Frank Li
2023-12-20 21:36 ` [PATCH v5 04/16] dt-bindings: imx6q-pcie: Add linux,pci-domain as required for iMX8MQ Frank Li
2023-12-23 18:40 ` Krzysztof Kozlowski
2023-12-24 4:29 ` Frank Li
2023-12-24 9:02 ` Krzysztof Kozlowski [this message]
2023-12-20 21:36 ` [PATCH v5 05/16] PCI: imx6: Using "linux,pci-domain" as slot ID Frank Li
2023-12-20 21:36 ` [PATCH v5 06/16] PCI: imx6: Simplify ltssm_enable() by using ltssm_off and ltssm_mask Frank Li
2023-12-20 21:36 ` [PATCH v5 07/16] PCI: imx6: Simplify configure_type() by using mode_off and mode_mask Frank Li
2023-12-20 21:36 ` [PATCH v5 08/16] PCI: imx6: Simplify switch-case logic by involve init_phy callback Frank Li
2023-12-20 21:36 ` [PATCH v5 09/16] dt-bindings: imx6q-pcie: Clean up irrationality clocks check Frank Li
2023-12-23 18:42 ` Krzysztof Kozlowski
2023-12-24 4:43 ` Frank Li
2023-12-24 9:04 ` Krzysztof Kozlowski
2023-12-20 21:36 ` [PATCH v5 10/16] dt-bindings: imx6q-pcie: remove reg and reg-name Frank Li
2023-12-21 22:50 ` Rob Herring
2023-12-23 3:46 ` Frank Li
2023-12-23 18:43 ` Krzysztof Kozlowski
2023-12-24 4:34 ` Frank Li
2023-12-24 9:06 ` Krzysztof Kozlowski
2023-12-20 21:36 ` [PATCH v5 11/16] dt-bindings: imx6q-pcie: Add imx95 pcie compatible string Frank Li
2023-12-21 22:52 ` Rob Herring
2023-12-20 21:36 ` [PATCH v5 12/16] PCI: imx6: Add iMX95 PCIe support Frank Li
2023-12-20 21:36 ` [PATCH v5 13/16] PCI: imx6: Clean up get addr_space code Frank Li
2023-12-20 21:36 ` [PATCH v5 14/16] PCI: imx6: Add epc_features in imx6_pcie_drvdata Frank Li
2023-12-20 21:36 ` [PATCH v5 15/16] dt-bindings: imx6q-pcie: Add iMX95 pcie endpoint compatible string Frank Li
2023-12-23 18:44 ` Krzysztof Kozlowski
2023-12-24 4:47 ` Frank Li
2023-12-24 9:09 ` Krzysztof Kozlowski
2023-12-24 9:07 ` Krzysztof Kozlowski
2023-12-20 21:36 ` [PATCH v5 16/16] PCI: imx6: Add iMX95 Endpoint (EP) function support Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf231452-e1e6-44bd-bff4-c699d5f2a53a@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Frank.li@nxp.com \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=helgaas@kernel.org \
--cc=hongxing.zhu@nxp.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kw@linux.com \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox