From: Dongli Zhang <dongli.zhang@oracle.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org,
mst@redhat.com, rafael@kernel.org, lenb@kernel.org,
bhelgaas@google.com, mika.westerberg@linux.intel.com,
boris.ostrovsky@oracle.com, joe.jin@oracle.com,
stable@vger.kernel.org, Fiona Ebner <f.ebner@proxmox.com>,
Thomas Lamprecht <t.lamprecht@proxmox.com>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC 0/2] PCI: acpiphp: workaround race between hotplug and SCSI_SCAN_ASYNC job
Date: Wed, 13 Dec 2023 00:12:16 -0800 [thread overview]
Message-ID: <d0308a65-4e78-5386-126c-9a7115d345b8@oracle.com> (raw)
In-Reply-To: <20231213003614.1648343-1-imammedo@redhat.com>
Hi Igor,
I am not able to reproduce the issue any longer with the two patches on
top of the mainline linux.
Thank you very much!
Dongli Zhang
On 12/12/23 16:36, Igor Mammedov wrote:
> Hacks to mask a race between HBA scan job and bridge re-configuration(s)
> during hotplug.
>
> I don't like it a bit but it something that could be done quickly
> and solves problems that were reported.
>
> Other options to discuss/possibly more invasive:
> 1: make sure pci_assign_unassigned_bridge_resources() doesn't reconfigure
> bridge if it's not necessary.
> 2. make SCSI_SCAN_ASYNC job wait till hotplug is finished for all slots on
> the bridge or somehow restart the job if it fails
> 3. any other ideas?
>
>
> 1st reported: https://urldefense.com/v3/__https://lore.kernel.org/r/9eb669c0-d8f2-431d-a700-6da13053ae54@proxmox.com__;!!ACWV5N9M2RV99hQ!ORo96Nh22kv1Yj0pazd3c692djoLbWscgouJoyVG1c1CNQnYz-H7nPM7RIp8N-0qQjScZ7BgORR_Lm4oMGMl$
>
> CC: Dongli Zhang <dongli.zhang@oracle.com>
> CC: linux-acpi@vger.kernel.org
> CC: linux-pci@vger.kernel.org
> CC: imammedo@redhat.com
> CC: mst@redhat.com
> CC: rafael@kernel.org
> CC: lenb@kernel.org
> CC: bhelgaas@google.com
> CC: mika.westerberg@linux.intel.com
> CC: boris.ostrovsky@oracle.com
> CC: joe.jin@oracle.com
> CC: stable@vger.kernel.org
> CC: linux-kernel@vger.kernel.org
> CC: Fiona Ebner <f.ebner@proxmox.com>
> CC: Thomas Lamprecht <t.lamprecht@proxmox.com>
>
> Igor Mammedov (2):
> PCI: acpiphp: enable slot only if it hasn't been enabled already
> PCI: acpiphp: slowdown hotplug if hotplugging multiple devices at a
> time
>
> drivers/pci/hotplug/acpiphp_glue.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
next prev parent reply other threads:[~2023-12-13 8:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-13 0:36 [RFC 0/2] PCI: acpiphp: workaround race between hotplug and SCSI_SCAN_ASYNC job Igor Mammedov
2023-12-13 0:36 ` [RFC 1/2] PCI: acpiphp: enable slot only if it hasn't been enabled already Igor Mammedov
2023-12-13 9:47 ` Fiona Ebner
2023-12-13 10:07 ` Igor Mammedov
2023-12-13 13:01 ` Rafael J. Wysocki
2023-12-13 16:06 ` Igor Mammedov
2023-12-13 0:36 ` [RFC 2/2] PCI: acpiphp: slowdown hotplug if hotplugging multiple devices at a time Igor Mammedov
2023-12-13 7:26 ` Greg KH
2023-12-13 8:13 ` Dongli Zhang
2023-12-13 10:05 ` Igor Mammedov
2023-12-13 17:25 ` Dongli Zhang
2023-12-13 9:47 ` Fiona Ebner
2023-12-13 13:07 ` Rafael J. Wysocki
2023-12-13 16:49 ` Igor Mammedov
2023-12-13 16:54 ` Michael S. Tsirkin
2023-12-13 17:09 ` Dongli Zhang
2024-01-03 9:54 ` Igor Mammedov
2024-01-03 16:19 ` Dongli Zhang
2023-12-13 18:50 ` Igor Mammedov
2023-12-13 8:12 ` Dongli Zhang [this message]
2023-12-13 18:11 ` [RFC 0/2] PCI: acpiphp: workaround race between hotplug and SCSI_SCAN_ASYNC job Bjorn Helgaas
2023-12-13 18:12 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0308a65-4e78-5386-126c-9a7115d345b8@oracle.com \
--to=dongli.zhang@oracle.com \
--cc=bhelgaas@google.com \
--cc=boris.ostrovsky@oracle.com \
--cc=f.ebner@proxmox.com \
--cc=imammedo@redhat.com \
--cc=joe.jin@oracle.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=mst@redhat.com \
--cc=rafael@kernel.org \
--cc=stable@vger.kernel.org \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox