From: Woody Suwalski <terraluna977@gmail.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: linux-kernel@vger.kernel.org, bhelgaas@google.com,
linux-pci@vger.kernel.org, mst@redhat.com
Subject: Re: [PATCH] hack to debug acpiphp crash
Date: Tue, 25 Jul 2023 07:45:08 -0400 [thread overview]
Message-ID: <d1333a63-c6b8-fe9a-24ce-05d2198323c2@gmail.com> (raw)
In-Reply-To: <20230725104237.0c8d0dc1@imammedo.users.ipa.redhat.com>
Igor Mammedov wrote:
> On Tue, 25 Jul 2023 10:06:44 +0200
> Igor Mammedov <imammedo@redhat.com> wrote:
>
>> PS:
>> What happens is that on resume firmware (likely EC),
>> issues ACPI bus check on root ports which (bus check) is
>> wired to acpiphp module (though pciehp module was initialized
>> at boot to manage root ports), it's likely firmware bug.
>>
>> I'd guess the intent behind this was to check if PCIe devices
>> were hotplugged while laptop has been asleep, and for
>> some reason they didn't use native PCIe hotplug to handle that.
>> However looking at laptop specs you can't hotplug PCIe
>> devices via external ports. Given how old laptop is
>> it isn't going to be fixed, so we would need a workaround
>> or fixup DSDT to skip buscheck.
>>
>> The options I see is to keep old kernel as for such case,
>> or bail out early from bus check/enable_slot since root port
>> is managed by pciehp module (and let it handle hotplug).
> scratch all of above out (it's wrong). Looking at DSDT
> firmware sends Notify(rpxx, 2 /* Wake */) event. Which
> according to spec needs to be handed down to the native
> device driver.
>
>
I agree that this laptop is a tricky one. I had to adjust my kernel
config NOHZ just to make it suspend to ram, otherwise it was waking back
right after going to sleep (and the same nohz kernel worked on all my
other machines)...
next prev parent reply other threads:[~2023-07-25 11:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <11fc981c-af49-ce64-6b43-3e282728bd1a@gmail.com>
2023-07-20 20:21 ` Kernel 6.5-rc2: system crash on suspend bisected Bjorn Helgaas
2023-07-24 9:27 ` Igor Mammedov
2023-07-27 6:09 ` Michael S. Tsirkin
2023-07-27 12:07 ` Woody Suwalski
2023-07-23 9:24 ` Linux regression tracking #adding (Thorsten Leemhuis)
2023-07-24 13:59 ` [PATCH] hack to debug acpiphp crash Igor Mammedov
2023-07-25 1:52 ` Woody Suwalski
2023-07-25 8:06 ` Igor Mammedov
2023-07-25 8:42 ` Igor Mammedov
2023-07-25 11:45 ` Woody Suwalski [this message]
2023-07-25 11:58 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1333a63-c6b8-fe9a-24ce-05d2198323c2@gmail.com \
--to=terraluna977@gmail.com \
--cc=bhelgaas@google.com \
--cc=imammedo@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mst@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).