Re: [PATCH v1 2/2] PCI/ACPI: alloc ACPI to be built without PCI support

[Sinan Kaya <okaya@kernel.org>]

On 12/3/2018 3:19 AM, Ingo Molnar wrote:
> 
> * Sinan Kaya <okaya@kernel.org> wrote:
> 
>> We are compiling PCI code today for systems with ACPI and no PCI
>> device present. Remove the useless code and reduce the tight
>> dependency.
>>
>> Signed-off-by: Sinan Kaya <okaya@kernel.org>
>> ---
>>   arch/x86/include/asm/pci_x86.h | 5 +++++
>>   drivers/acpi/Kconfig           | 1 -
>>   drivers/acpi/Makefile          | 2 +-
>>   drivers/acpi/internal.h        | 5 +++++
>>   drivers/pci/Makefile           | 2 +-
>>   include/acpi/acpi_drivers.h    | 5 +++++
>>   include/linux/acpi.h           | 6 ++++++
>>   include/linux/pci.h            | 4 ++++
>>   8 files changed, 27 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/x86/include/asm/pci_x86.h b/arch/x86/include/asm/pci_x86.h
>> index 959d618dbb17..940cf12e7d05 100644
>> --- a/arch/x86/include/asm/pci_x86.h
>> +++ b/arch/x86/include/asm/pci_x86.h
>> @@ -121,7 +121,12 @@ extern void __init dmi_check_pciprobe(void);
>>   extern void __init dmi_check_skip_isa_align(void);
>>   
>>   /* some common used subsys_initcalls */
>> +#ifdef CONFIG_PCI
>>   extern int __init pci_acpi_init(void);
>> +#else
>> +static inline int  __init pci_acpi_init(void)
>> +{ return -EINVAL; }
>> +#endif
> 
> No objections to removing the dependency, but that's nowhere near
> standard kernel style. ;-)
> 

Great,

> (There are similar problems elsewhere in the patch as well, please fix
> all of them.)

I sure can fix them but I copied the stub style from existing other stub
functions in the same file and did run checkpatch before submitting.

If you can point me to the specific ones you would like to see or give an
idea what it needs to look like, I can change it.

I saw three different styles as follows:

static inline int  __init pci_acpi_init(void) {}

static inline int  __init pci_acpi_init(void)
{}

static inline int  __init pci_acpi_init(void)
{
}


> 
> Thanks,
> 
> 	Ingo
>