From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f48.google.com (mail-oo1-f48.google.com [209.85.161.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3697D20CCE6 for ; Thu, 20 Feb 2025 17:29:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740072552; cv=none; b=P0o5cH2TEU4JwJg3soUpWqi1qFuht1y5439Cd4pHX46ve4hkI8H9b0vfDh6pK4q9+dmsARqKpixZWPZImhzUR9ZHx2R5NHxnU84gPL8TZlhom3JpBkpij60TrrsfwmMg9R99krPRm2NlXzhR2w5d1zTpSdqef6PJ5KKmckw6YIw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740072552; c=relaxed/simple; bh=2L9S38y1z8Zm2vnzvPj+2uI+11xVncvT2stzj/5BO2Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ACZQw0sp4b7WsuBsQIjP8dmFsnXr2pH4Llg1q/0PvR551qXH9vXddgXFjuJNSIXvCFsLbGdFoo+90YQyijbrilL7dCrH/bJxfF0PYHYt/Ka6j9jWgVBYdQ9QvA/alotmnVgs+oyQFoGeFVbF5WLnBIWl8GFFgVm2SyPqEBXstdk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=V2/RrBWn; arc=none smtp.client-ip=209.85.161.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="V2/RrBWn" Received: by mail-oo1-f48.google.com with SMTP id 006d021491bc7-5fc6cd89f85so507337eaf.1 for ; Thu, 20 Feb 2025 09:29:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1740072549; x=1740677349; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=dKf1vcFL6xViBeT7BvtPbIy9sFenGIBAFVayL6IZB0U=; b=V2/RrBWn/Zo+teoTjn85YegpompjEEIYKk0J18yPtJIa+cgNOQ9aG+0FprOmZfTYQ9 dpYdgK7fgcvfApEo8UQBue7r4x5D8WPMTtIvVL3V3e/k26kQ9ymBef6vu7zj8sVTgcEm 9suSjbJ7ocYH6Ilx8JwJIu4NXF9RsjDksomfk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740072549; x=1740677349; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dKf1vcFL6xViBeT7BvtPbIy9sFenGIBAFVayL6IZB0U=; b=OYTJ3x70HPKZeIDzwjdIiz39C2p1J15ElBF9xXNvmxinOV4tDO06bw94etldkIsElz ynt+IVbUszVOxhtNnYdDPKaUvPZ9DV9euZPABqM8WCMwfXEE+aGNH00+zvVFm2EmHe0q Um/1FSS17QF9igHa/ciNiMKoAGa4izZy+tQeJ0BsazPcrYHRT13LhzOC5YfIMjEK0V+8 ctGY7ZPbh2psdmH6cgwLkghP6tqVBz+oE4qkw2rLGn/OvLPXePLXkksTBXeBZRAc9uQ5 o0AQw9HZLyc0VSsAqzVrpnX7V/W21B5YKG4uvciPRCysPwjodPeq0L3rvn8HOK/6BRpW ySIQ== X-Forwarded-Encrypted: i=1; AJvYcCWSKzV/CYd3ssvan2CiXiR9aSoRYkfnK3ecO9NMU9hLnungU/TYm9EANdtowg+JV8pUg3j74lACeWY=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0RvHRkwRlAYZIx7aoxmzQ8pkhIyq/55VQfe72X277OU4La+oD em8+tlovoovnSfb9c9GYTQwEIRevUrA7MzeJJ5izPGOwuF5tkwt+OWzKFrOfGg== X-Gm-Gg: ASbGncsa88CTT1Jk2W5WEgYDIYXTxrTVBT/3zjaYJ7gpBu+EwaGKdnbHB/cwAcUS0a/ Ay1hcLHpetpykzZrFoHVu3O9BwWXsMTQi30PAkbDKNYh3aQBrW5v8DMKHMrphlyJBXca0WHoIva sBxrBLRqDxPnSwdHSyLHZneIiKyWXon4YBCEkKCqrgiYcCp8TEFzQ7KyQZYFyZsM5Kbg79KF8ui 7LCHSLGo/C/wOt+lP0JebZDWAEfsqTtg3moQGQIizJ+zmm3Qy7NtKcXLd9cBAxtLNZkeEjPHLha uC3MrDCniSs1DsfZH2lJKSCGdhoZgHpJ1y/dQBui37eEprclbA+zYPyWG7k9hQoHs2rInmIdLCm R8+a0 X-Google-Smtp-Source: AGHT+IGHUYuXkflX6Xl2ci+0XBC0DnCcaMzZUD3gJQT0dFe4tZ5U3wxWcguP1LzcW4V9sDRX10JEUw== X-Received: by 2002:a05:6820:270c:b0:5fc:b059:7597 with SMTP id 006d021491bc7-5fd194df6fcmr160232eaf.1.1740072549114; Thu, 20 Feb 2025 09:29:09 -0800 (PST) Received: from [10.171.122.29] (wsip-98-189-219-228.oc.oc.cox.net. [98.189.219.228]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-5fd0aa506acsm497034eaf.31.2025.02.20.09.29.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Feb 2025 09:29:08 -0800 (PST) Message-ID: Date: Thu, 20 Feb 2025 09:29:06 -0800 Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/8] PCI: brcmstb: Do not assume that reg field starts at LSB To: Jim Quinlan , linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Stanimir Varbanov , bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com Cc: Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list References: <20250214173944.47506-1-james.quinlan@broadcom.com> <20250214173944.47506-4-james.quinlan@broadcom.com> Content-Language: en-US From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <20250214173944.47506-4-james.quinlan@broadcom.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/14/2025 9:39 AM, Jim Quinlan wrote: > When setting a register field it was assumed that the field started at the > lsb of the register. Although the masks do indeed start at the lsb, and > this will probably not change, it is prudent to use a method that makes no > assumption about the mask's placement in the register. > > The uXXp_replace_bits() calls are used since they are already prevalent > in this driver. > > Signed-off-by: Jim Quinlan Reviewed-by: Florian Fainelli -- Florian