From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, tiwai@suse.de,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-pci@vger.kernel.org,
"Péter Ujfalusi" <peter.ujfalusi@linux.intel.com>,
"Ranjani Sridharan" <ranjani.sridharan@linux.intel.com>,
"Bard Liao" <yung-chuan.liao@linux.intel.com>
Subject: Re: [PATCH 2/5] ASoC: SOF: Intel: add initial support for PTL
Date: Thu, 13 Jun 2024 06:59:44 +0200 [thread overview]
Message-ID: <d1baeec6-87f5-4784-8cbf-b26a9de441e9@linux.intel.com> (raw)
In-Reply-To: <c835bf25-39b8-4f7a-9c77-33367085670e@linux.intel.com>
On 6/12/24 18:08, Pierre-Louis Bossart wrote:
>
>
> On 6/12/24 18:01, Mark Brown wrote:
>> On Wed, Jun 12, 2024 at 08:58:55AM +0200, Pierre-Louis Bossart wrote:
>>> Clone LNL for now.
>>
>> There's a dependency somewhere I think:
>>
>> In file included from /build/stage/linux/sound/soc/sof/intel/pci-ptl.c:10:
>> /build/stage/linux/include/linux/pci.h:1063:51: error: ‘PCI_DEVICE_ID_INTEL_HDA_
>> PTL’ undeclared here (not in a function); did you mean ‘PCI_DEVICE_ID_INTEL_HDA_
>> MTL’?
>> 1063 | .vendor = PCI_VENDOR_ID_##vend, .device = PCI_DEVICE_ID_##vend##
>> _##dev, \
>> | ^~~~~~~~~~~~~~
>> /build/stage/linux/sound/soc/sof/intel/pci-ptl.c:52:11: note: in expansion of ma
>> cro ‘PCI_DEVICE_DATA’
>> 52 | { PCI_DEVICE_DATA(INTEL, HDA_PTL, &ptl_desc) }, /* PTL */> | ^~~~~~~~~~~~~~~
>
> Yes indeed there is a dependency, I mentioned it in the cover letter
>
>
> "
> This patchset depends on the first patch of "[PATCH 0/3] ALSA/PCI: add
> PantherLake audio support"
> "
>
> We don't add PCI IDs every week but when we do we'll need an update of
> pci_ids.h prior to ALSA- and ASoC-specific patches.
There's another problem reported by the Intel build bot
https://lore.kernel.org/oe-kbuild-all/202406131144.L6gW0I47-lkp@intel.com/
When I modified the order of patches I broke the intermediate
compilation. The ACPI machine definition needs to come first.
I'll send a v2, sorry about that.
next prev parent reply other threads:[~2024-06-13 4:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 6:58 [PATCH 0/5] ASoC/SOF/PCI/Intel: add PantherLake support Pierre-Louis Bossart
2024-06-12 6:58 ` [PATCH 1/5] ASoC: SOF: Intel: add PTL specific power control register Pierre-Louis Bossart
2024-06-12 6:58 ` [PATCH 2/5] ASoC: SOF: Intel: add initial support for PTL Pierre-Louis Bossart
2024-06-12 16:01 ` Mark Brown
2024-06-12 16:08 ` Pierre-Louis Bossart
2024-06-13 4:59 ` Pierre-Louis Bossart [this message]
2024-06-12 6:58 ` [PATCH 3/5] ASoC: Intel: soc-acpi: add PTL match tables Pierre-Louis Bossart
2024-06-12 6:58 ` [PATCH 4/5] ASoC: Intel: soc-acpi-intel-ptl-match: add rt711-sdca table Pierre-Louis Bossart
2024-06-12 6:58 ` [PATCH 5/5] ASoC: Intel: soc-acpi-intel-ptl-match: Add rt722 support Pierre-Louis Bossart
2024-08-08 8:12 ` [PATCH 0/5] ASoC/SOF/PCI/Intel: add PantherLake support Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1baeec6-87f5-4784-8cbf-b26a9de441e9@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=bhelgaas@google.com \
--cc=broonie@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=peter.ujfalusi@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=tiwai@suse.de \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox