From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f53.google.com (mail-ot1-f53.google.com [209.85.210.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FCB2212D97 for ; Thu, 20 Feb 2025 17:29:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740072579; cv=none; b=g/GIZpLr8VMRwa9xwtxMi2girGtIaYjpLBBt5OrpSVUW44e6jsozpw4/H1mzMT0oRRitmZZSe3JF2dY+xDQXkvPsjlj1ayvvCsDIpA4M2UYBWAXQVBfSLcnkLcczf2/fWXA2qIdmMdvS0llV+q2crdAUf10T8C3I4D7D9SOv0OE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740072579; c=relaxed/simple; bh=OMIKK8FOyrWHnC0j5QluAve9X6UXxjyhC5lNgIQnY4g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZI9JTaR01ix1MTA/0Yv+m00ODBc9oKBSEcUF55xKer3AV84Yf8HTEnsooVDM+zl7+0MRuSSq6/Pv5XeLGIjry3W0wtFe/M6nRpBbhcKnlGI/kiBqUkZmC24/3gmF/ywVBKW99YeJsJBPDwpTxnRUH59aRvGENfQ5IErAT/zPQP8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=KhGHkm7z; arc=none smtp.client-ip=209.85.210.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="KhGHkm7z" Received: by mail-ot1-f53.google.com with SMTP id 46e09a7af769-72726a65cbaso644265a34.0 for ; Thu, 20 Feb 2025 09:29:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1740072576; x=1740677376; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=kdikSYRCknu87r4IRD4jNLLC13le+VI+y2JvXDGCpPM=; b=KhGHkm7zYwPlYQV33lwhnuAiCykiautsZgM913OhWx1q1c+LfOcw9NpiZ4KFOpOksP a8rHz9jZevypA6lCyYNZTaBoWosHVUFWUIM7l7EUbDQ/xrcJPokNplzZBmJ8gnM4mVKp a9StjXewFPuyohafaPmU9B7xomDvuRkhhP/Uc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740072576; x=1740677376; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kdikSYRCknu87r4IRD4jNLLC13le+VI+y2JvXDGCpPM=; b=M3WoucxZt/LQaIQ4/NPY6d/cOPpRSFa/f7gcppSZq2c5AjQkE4nyr9bpwnRqGdTUMI 9hvUtbBdjkGt3+TckRDkopU6eoG1y8fiSeZSwlsrdDOJJOlBtzjMTxEdPlw5uOfah7Bt lhcRYCf0JXyWzgI5VvngKpD7CTdy8nfGIuCyzXxjO6jby2o7atlfG6v3Gzwj/plxAVIt b6KsziJc1i3CH2F5f7RckI0BE0iOg09BM4AQOBta5/49k96Q3wT3HAYrPpLLj891eeCY MjCNHBOlzve+fVFlojhnHsMzi5mJQbNsg9DlRBIUBzMP45JUJBoWmYvFgUU16zADtKDR WrJg== X-Forwarded-Encrypted: i=1; AJvYcCW0mMRTtUEos8F09tMiAYmwMCYQEwbKWCYgmb1X0EazPTgKMWpX6FgYS2xoK+CkNiG69R8GP94ICvg=@vger.kernel.org X-Gm-Message-State: AOJu0YyKuWdsS2rAqxu0zzUMG2O3rlXUfhjn4mtMA5WaFjVuVCoOutcJ dxQaYxwwm8h34bi39l2Upb4RsjXNw2xVn0HMjNzglUJ/C91hMXr30Lfv3Tc+Qw== X-Gm-Gg: ASbGncuPhfsf7in0utNhnUuvknxpN8bQzjePdd6UpfxwjJyttv8npyNQxxtD/6Jj4Jr qgx6Mnr+oEkDDDs7EaDZ8K84y4JfCXzqaJI44Alm+ut300thnIwqsEM9lc2G8iCXNTd+PjIwyIs Jl3f44yoRW9q6hC2QMK+N/zGe/YCS6Zsg+NcspZKIiuiCfa9HTJ8fBe6I0+V/oNaxofQvHvTsQe eAvhWrx1MVgCz2H9mP/EJ5yaBDZ9UnfBwuhhNvCEyLwbMgJouBv43BGnei+9fGGRl6lFaV3GVNU KL9NbqKcmv9HPMUwrZHt53M3RRDc6vv5VjvjvT/SoZGuVRrNrELODZCo2di4/1o/lksjYv+lLqG FTJQB X-Google-Smtp-Source: AGHT+IGZA+a9XGOETQCq4mTPzcDC3M3BrXfb2U/dru5rUVJw0B01xbMp+b+QPk3A39iTP91d5M6t3w== X-Received: by 2002:a05:6830:2aa7:b0:727:2f9d:284c with SMTP id 46e09a7af769-7274399117dmr2635918a34.10.1740072576341; Thu, 20 Feb 2025 09:29:36 -0800 (PST) Received: from [10.171.122.29] (wsip-98-189-219-228.oc.oc.cox.net. [98.189.219.228]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7272737d70dsm2344358a34.42.2025.02.20.09.29.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Feb 2025 09:29:35 -0800 (PST) Message-ID: Date: Thu, 20 Feb 2025 09:29:32 -0800 Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/8] PCI: brcmstb: Fix error path upon call of regulator_bulk_get() To: Jim Quinlan , linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Stanimir Varbanov , bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com Cc: Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list References: <20250214173944.47506-1-james.quinlan@broadcom.com> <20250214173944.47506-5-james.quinlan@broadcom.com> Content-Language: en-US From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <20250214173944.47506-5-james.quinlan@broadcom.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/14/2025 9:39 AM, Jim Quinlan wrote: > If regulator_bulk_get() returns an error, no regulators are created and we > need to set their number to zero. If we do not do this and the PCIe > link-up fails, regulator_bulk_free() will be invoked and effect a panic. > > Also print out the error value, as we cannot return an error upwards as > Linux will WARN on an error from add_bus(). > > Fixes: 9e6be018b263 ("PCI: brcmstb: Enable child bus device regulators from DT") > Signed-off-by: Jim Quinlan Reviewed-by: Florian Fainelli -- Florian