From: Sinan Kaya <okaya@kernel.org>
To: Huacai Chen <chenhc@lemote.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci <linux-pci@vger.kernel.org>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Tiezhu Yang <yangtiezhu@loongson.cn>
Subject: Re: [PATCH] PCI/portdrv: Don't disable pci device during shutdown
Date: Tue, 22 Sep 2020 00:30:46 -0400 [thread overview]
Message-ID: <d2fee988-d41d-d2c4-3420-a4258c5379aa@kernel.org> (raw)
In-Reply-To: <CAAhV-H6+57ss5p037r04-X7=YZrQnLUsLDB3GrR-_OPXiucUgw@mail.gmail.com>
On 9/21/2020 10:11 PM, Huacai Chen wrote:
>> his sounds like a quirk to me rather than a behavior that should be
>> applied to all platforms.
> Yes, this is very like a quirk, but it seems there are a lot of
> platforms that have problems, and removing the pci_disable_device()
> has no side effect.
Why is there no side effect?
AFAIK, kexec goes through the shutdown path and you are leaving a PCI
device enabled during kexec boot which can corrupt the booting OS
memory.
I don't think you can generalize a behavior based on a few quirky
devices. You should be quirking only the device that has a problem
rather than changing the behavior of all other platforms.
next prev parent reply other threads:[~2020-09-22 4:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 9:22 [PATCH] PCI/portdrv: Don't disable pci device during shutdown Huacai Chen
2020-09-21 15:50 ` Sinan Kaya
2020-09-22 2:11 ` Huacai Chen
2020-09-22 4:30 ` Sinan Kaya [this message]
2020-09-22 6:20 ` Tiezhu Yang
2020-09-22 6:16 ` Huacai Chen
2020-12-31 6:15 ` Huacai Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2fee988-d41d-d2c4-3420-a4258c5379aa@kernel.org \
--to=okaya@kernel.org \
--cc=bhelgaas@google.com \
--cc=chenhc@lemote.com \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-pci@vger.kernel.org \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox