From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
"Mario Limonciello (AMD)" <superm1@kernel.org>,
linux-acpi@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
linux-i2c@vger.kernel.org, linux-pci@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
ibm-acpi-devel@lists.sourceforge.net,
"Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>,
Mika Westerberg <westeri@kernel.org>,
Andi Shyti <andi.shyti@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
Mark Pearson <mpearson-lenovo@squebb.ca>,
"Derek J. Clark" <derekjohn.clark@gmail.com>,
Hans de Goede <hansg@kernel.org>
Subject: Re: [PATCH v2 6/6] platform/x86: thinkpad_acpi: Convert to use acpi_dev_is_video_device() helper
Date: Mon, 20 Jul 2026 13:33:01 +0300 (EEST) [thread overview]
Message-ID: <d45b8ac1-d05c-7797-efaf-d0ff67cde80b@linux.intel.com> (raw)
In-Reply-To: <20260714185915.865396-7-andriy.shevchenko@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 966 bytes --]
On Tue, 14 Jul 2026, Andy Shevchenko wrote:
> Replace open coded variant of acpi_dev_is_video_device() helper.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/platform/x86/lenovo/thinkpad_acpi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/lenovo/thinkpad_acpi.c b/drivers/platform/x86/lenovo/thinkpad_acpi.c
> index 6dd7c28fc0db..aaeada46a0e7 100644
> --- a/drivers/platform/x86/lenovo/thinkpad_acpi.c
> +++ b/drivers/platform/x86/lenovo/thinkpad_acpi.c
> @@ -774,7 +774,7 @@ static acpi_status __init tpacpi_acpi_handle_locate_callback(acpi_handle handle,
> if (!strcmp(context, "video")) {
> struct acpi_device *dev = acpi_fetch_acpi_dev(handle);
>
> - if (!dev || strcmp(ACPI_VIDEO_HID, acpi_device_hid(dev)))
> + if (!acpi_dev_is_video_device(dev))
> return AE_OK;
Acked-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
--
i.
next prev parent reply other threads:[~2026-07-20 10:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 18:53 [PATCH v2 0/6] ACPI: Introduce and use acpi_dev_is_video_device() helper Andy Shevchenko
2026-07-14 18:53 ` [PATCH v2 1/6] ACPI: utils: Introduce " Andy Shevchenko
2026-07-14 19:14 ` sashiko-bot
2026-07-14 18:53 ` [PATCH v2 2/6] ACPI: scan: Convert to use " Andy Shevchenko
2026-07-14 19:18 ` sashiko-bot
2026-07-14 18:53 ` [PATCH v2 3/6] ACPI: video: " Andy Shevchenko
2026-07-14 19:21 ` sashiko-bot
2026-07-14 18:53 ` [PATCH v2 4/6] i2c: acpi: " Andy Shevchenko
2026-07-14 19:30 ` sashiko-bot
2026-07-14 18:53 ` [PATCH v2 5/6] PCI/VGA: " Andy Shevchenko
2026-07-14 19:36 ` sashiko-bot
2026-07-20 9:04 ` Ilpo Järvinen
2026-07-20 9:51 ` Andy Shevchenko
2026-07-14 18:53 ` [PATCH v2 6/6] platform/x86: thinkpad_acpi: " Andy Shevchenko
2026-07-14 19:47 ` sashiko-bot
2026-07-20 10:33 ` Ilpo Järvinen [this message]
2026-07-21 13:40 ` [PATCH v2 0/6] ACPI: Introduce and " Rafael J. Wysocki (Intel)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d45b8ac1-d05c-7797-efaf-d0ff67cde80b@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=derekjohn.clark@gmail.com \
--cc=hansg@kernel.org \
--cc=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mpearson-lenovo@squebb.ca \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=superm1@kernel.org \
--cc=westeri@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox