From: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: "bhelgaas@google.com" <bhelgaas@google.com>,
"Joao.Pinto@synopsys.com" <Joao.Pinto@synopsys.com>,
"jingoohan1@gmail.com" <jingoohan1@gmail.com>,
"kishon@ti.com" <kishon@ti.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH 3/8] bindings: PCI: designware: Add support for the EP in designware driver
Date: Wed, 4 Apr 2018 12:56:19 +0100 [thread overview]
Message-ID: <d48b4dc7-41a5-2304-c310-f7b4e08973a8@synopsys.com> (raw)
In-Reply-To: <20180404115014.GC24669@red-moon>
Hi Lorenzo,
On 04/04/2018 12:50, Lorenzo Pieralisi wrote:
> On Wed, Mar 28, 2018 at 12:38:33PM +0100, Gustavo Pimentel wrote:
>
> Please always write a commit log even if it is trivial.
Ok, Kishon has also refered that. On next patch version it'll contain a log
description.
>
> Thanks,
> Lorenzo
>
>> Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
>> ---
>> Documentation/devicetree/bindings/pci/designware-pcie.txt | 13 +++++++++++++
>> 1 file changed, 13 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/pci/designware-pcie.txt b/Documentation/devicetree/bindings/pci/designware-pcie.txt
>> index 6300762..4bb2e08 100644
>> --- a/Documentation/devicetree/bindings/pci/designware-pcie.txt
>> +++ b/Documentation/devicetree/bindings/pci/designware-pcie.txt
>> @@ -3,6 +3,7 @@
>> Required properties:
>> - compatible:
>> "snps,dw-pcie" for RC mode;
>> + "snps,dw-pcie-ep" for EP mode;
>> - reg: Should contain the configuration address space.
>> - reg-names: Must be "config" for the PCIe configuration space.
>> (The old way of getting the configuration address space from "ranges"
>> @@ -56,3 +57,15 @@ Example configuration:
>> #interrupt-cells = <1>;
>> num-lanes = <1>;
>> };
>> +or
>> + pcie_ep: pcie_ep@dfc00000 {
>> + compatible = "snps,dw-pcie-ep";
>> + reg = <0xdfc00000 0x0001000>, /* IP registers 1 */
>> + <0xdfc01000 0x0001000>, /* IP registers 2 */
>> + <0xd0000000 0x2000000>; /* Configuration space */
>> + reg-names = "dbi", "dbi2", "addr_space";
>> + device_type = "pci";
>> + num-ib-windows = <6>;
>> + num-ob-windows = <2>;
>> + num-lanes = <1>;
>> + };
>> --
>> 2.7.4
>>
>>
Regards,
Gustavo
next prev parent reply other threads:[~2018-04-04 11:57 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-28 11:38 [PATCH 0/8] Designware EP support and code clenan up Gustavo Pimentel
2018-03-28 11:38 ` [PATCH 1/8] bindings: PCI: designware: Example update Gustavo Pimentel
2018-04-02 5:23 ` Kishon Vijay Abraham I
2018-04-03 10:33 ` Gustavo Pimentel
2018-04-03 10:52 ` Kishon Vijay Abraham I
2018-04-03 10:53 ` Kishon Vijay Abraham I
2018-04-03 13:13 ` Gustavo Pimentel
2018-04-06 6:23 ` Kishon Vijay Abraham I
2018-03-28 11:38 ` [PATCH 2/8] PCI: dwc: designware: Add support for endpoint mode Gustavo Pimentel
2018-04-02 5:34 ` Kishon Vijay Abraham I
2018-04-04 10:20 ` Gustavo Pimentel
2018-04-06 7:16 ` Kishon Vijay Abraham I
2018-03-28 11:38 ` [PATCH 3/8] bindings: PCI: designware: Add support for the EP in designware driver Gustavo Pimentel
2018-04-02 5:35 ` Kishon Vijay Abraham I
2018-04-03 10:43 ` Gustavo Pimentel
2018-04-03 10:55 ` Kishon Vijay Abraham I
2018-04-03 13:20 ` Gustavo Pimentel
2018-04-06 7:04 ` Kishon Vijay Abraham I
2018-04-04 11:50 ` Lorenzo Pieralisi
2018-04-04 11:56 ` Gustavo Pimentel [this message]
2018-04-09 19:12 ` Rob Herring
2018-04-10 11:11 ` Gustavo Pimentel
2018-03-28 11:38 ` [PATCH 4/8] misc: pci_endpoint_test: Add designware EP entry Gustavo Pimentel
2018-04-02 5:36 ` Kishon Vijay Abraham I
2018-04-03 10:11 ` Gustavo Pimentel
2018-04-03 10:56 ` Kishon Vijay Abraham I
2018-03-28 11:38 ` [PATCH 5/8] PCI: dwc: designware: Define maximum number of vectors Gustavo Pimentel
2018-03-28 11:38 ` [PATCH 6/8] PCI: dwc: Replace lower into upper case characters Gustavo Pimentel
2018-03-28 12:05 ` Fabio Estevam
2018-03-28 13:00 ` Gustavo Pimentel
2018-03-29 13:56 ` Fabio Estevam
2018-03-28 11:38 ` [PATCH 7/8] PCI: dwc: Small computation improvement Gustavo Pimentel
2018-03-28 11:38 ` [PATCH 8/8] PCI: dwc: Replace magic number by defines Gustavo Pimentel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d48b4dc7-41a5-2304-c310-f7b4e08973a8@synopsys.com \
--to=gustavo.pimentel@synopsys.com \
--cc=Joao.Pinto@synopsys.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=jingoohan1@gmail.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).