Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@linux.intel.com>
To: Paul Menzel <pmenzel@molgen.mpg.de>, Bjorn Helgaas <helgaas@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	linux-pci@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: Dell XPS 13 9360: Two PCI devices with disabled power management by default
Date: Sat, 2 Mar 2024 08:22:19 -0800	[thread overview]
Message-ID: <d6275e31-9ceb-4d8c-9018-e30857c31bba@linux.intel.com> (raw)
In-Reply-To: <eeccc05b-3341-4bc5-bdc7-27cd9e6eb104@molgen.mpg.de>

On 3/2/2024 8:19 AM, Paul Menzel wrote:
> [Cc: +Arjan]
> 
> Dear Bjorn,
> 
> 
> Thank you for your reply.
> 
> Am 01.03.24 um 22:51 schrieb Bjorn Helgaas:
>> On Fri, Mar 01, 2024 at 12:32:12PM +0100, Paul Menzel wrote:
> 
>>> I noticed on the Dell XPS 13 9360 some devices do not have power management
>>> enabled by default. From PowerTOP:
>>>
>>>         Bad           Runtime PM for PCI Device Intel Corporation Sunrise Point-LP PCI Express Root Port #1
>>>         Bad           Runtime PM for PCI Device Intel Corporation Sunrise Point-LP LPC Controller
>>
>> I don't know what this "Bad" is based on, so I don't know where to
>> look for something Linux might be doing.  I don't see any code that
>> mentions 9d10 or 9d58 Device IDs in relation to power.
> 
> Turns out that PowerTOP marks all devices as *Bad* where `power/control` differs from `auto`. In this case these are set to `on`, which should be good from a power 
> management perspective.

ok just fixed this in powertop git

thanks for the report!



      reply	other threads:[~2024-03-02 16:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-01 11:32 Dell XPS 13 9360: Two PCI devices with disabled power management by default Paul Menzel
2024-03-01 21:51 ` Bjorn Helgaas
2024-03-02 16:19   ` Paul Menzel
2024-03-02 16:22     ` Arjan van de Ven [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d6275e31-9ceb-4d8c-9018-e30857c31bba@linux.intel.com \
    --to=arjan@linux.intel.com \
    --cc=bhelgaas@google.com \
    --cc=helgaas@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pmenzel@molgen.mpg.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox