From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 217B5C433F5 for ; Tue, 19 Apr 2022 09:59:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241952AbiDSKCH (ORCPT ); Tue, 19 Apr 2022 06:02:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230005AbiDSKCF (ORCPT ); Tue, 19 Apr 2022 06:02:05 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 073402252A for ; Tue, 19 Apr 2022 02:59:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650362362; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZYCbCMusX5qnw2HYP1MeCveqjGocg9sXBdk9ZKPneIA=; b=dTg+1KY04kMNJ0bxuOnuYDG85+S0YfutMIn5FZ2fBU6/CVRwL8dT4OqRLRBMMygYWhEd8T YwI6KA1DLv56gaXwSSkAob+rSCoGz14olvuPQ03TmDTMG2FYQ194M1e1ByzCL3ibz7kyPa B4P7tI9DtVXG2W2+acR/tQB8KgTaOGM= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-164-9MFsF31tNVSAhnK7CrVU5g-1; Tue, 19 Apr 2022 05:59:20 -0400 X-MC-Unique: 9MFsF31tNVSAhnK7CrVU5g-1 Received: by mail-ed1-f72.google.com with SMTP id s28-20020a05640217dc00b0041d69ecc528so10719312edy.12 for ; Tue, 19 Apr 2022 02:59:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=ZYCbCMusX5qnw2HYP1MeCveqjGocg9sXBdk9ZKPneIA=; b=iXBZySVgIELJK1s/1KzKrkwolzS10bt/RgPhnG+5LyjoPjt/cY9L2xgx9VL50E9oUK 4T7obJURLz4H+YpMHkZ8hoCijDE689FLC4G/bjWUXA7MpefYjFR/5iaz1/yvTkQ3LNbM KtsJq+3EdgSsbIafsDZ9Ga/cXHDA4aGi94tBi4owMsrCH9LLJ+Pe4V4aFC5HOZWSBc3z m8RfOdnTZEh5Dl0Wa9K192cTQKuVuojQ3rIASD0khGfnB6iZruKdmi6Kj2Gtia421csr wM4BLM2vgehb68YVJWITr3en3JS4ty6Sj7wCeGnZHrzaBfQeJTXRab63lUmcsLGSnpYa SQuQ== X-Gm-Message-State: AOAM530duf3Zhj4jaXbfCSABV718ANELeoSHXYxI/sX4n7gwmsMhL8Dp cDD9o8jAAzWFD9pzHqv6AOCzvpYKbalEOGPlICZTMO5JxuGbUCcarbV+hVSQw6LAye552JPJ7Zw BnZeO0ms5MjQJvgydaGjp X-Received: by 2002:a17:907:96a1:b0:6e8:9dce:c3bc with SMTP id hd33-20020a17090796a100b006e89dcec3bcmr12479270ejc.589.1650362359323; Tue, 19 Apr 2022 02:59:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxPj/oCA2jmmG43YRFtvikiwgaJYI1/P+OfA2QaPriTfw/gSnUO1tnTCTWh6or2Q3Awqulg1A== X-Received: by 2002:a17:907:96a1:b0:6e8:9dce:c3bc with SMTP id hd33-20020a17090796a100b006e89dcec3bcmr12479257ejc.589.1650362359077; Tue, 19 Apr 2022 02:59:19 -0700 (PDT) Received: from ?IPV6:2001:1c00:c1e:bf00:d69d:5353:dba5:ee81? (2001-1c00-0c1e-bf00-d69d-5353-dba5-ee81.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:d69d:5353:dba5:ee81]) by smtp.gmail.com with ESMTPSA id vw17-20020a170907059100b006e8732d1944sm5460828ejb.5.2022.04.19.02.59.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Apr 2022 02:59:18 -0700 (PDT) Message-ID: Date: Tue, 19 Apr 2022 11:59:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v2 0/3] x86/PCI: Log E820 clipping Content-Language: en-US To: Bjorn Helgaas , "Rafael J . Wysocki" , Borislav Petkov , "H . Peter Anvin" , Ingo Molnar Cc: Mika Westerberg , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Myron Stowe , Juha-Pekka Heikkila , =?UTF-8?Q?Benoit_Gr=c3=a9goire?= , Hui Wang , Kai-Heng Feng , linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas References: <20220414182252.758742-1-helgaas@kernel.org> From: Hans de Goede In-Reply-To: <20220414182252.758742-1-helgaas@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Hi All, On 1/1/70 01:00, Bjorn Helgaas wrote: > This is still work-in-progress on the issue of PNP0A03 _CRS methods that > are buggy or not interpreted correctly by Linux. > > The previous try at: > https://lore.kernel.org/r/20220304035110.988712-1-helgaas@kernel.org > caused regressions on some Chromebooks: > https://lore.kernel.org/r/Yjyv03JsetIsTJxN@sirena.org.uk > > This v2 drops the commit that caused the Chromebook regression, so it also > doesn't fix the issue we were *trying* to fix on Lenovo Yoga and Clevo > Barebones. > > The point of this v2 update is to split the logging patch into (1) a pure > logging addition and (2) the change to only clip PCI windows, which was > previously hidden inside the logging patch and not well documented. > > Bjorn Helgaas (3): > x86/PCI: Eliminate remove_e820_regions() common subexpressions > x86: Log resource clipping for E820 regions > x86/PCI: Clip only host bridge windows for E820 regions Thanks, the entire series looks good to me: Reviewed-by: Hans de Goede For the series. So what is the plan to actually fix the issue seen on some Lenovo models and Clevo Barebones ? As I mentioned previously I think that since all our efforts have failed so far that we should maybe reconsider just using DMI quirks to ignore the E820 reservation windows for host bridges on affected models ? That or implement 3 of: > So I think the progression is: > > 1) Remove anything mentioned in E820 from _CRS (4dc2287c1805 [7]). > This worked around some issues on Dell systems. > > 2) Remove things mentioned in E820 unless they cover the entire > window (5949965ec934 [8]) > > 3) Coalesce adjacent _CRS windows, *then* remove things mentioned in > E820 unless they cover the entire (coalesced) window (current > proposal) Regards, Hans