From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0406D23F405 for ; Tue, 9 Sep 2025 04:17:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757391426; cv=none; b=vC/PpCkFdfy3r1M3vj0NFS+v0oo8iGG0pLwWHeKmpUU8rlwDd2q3CdqCztwWqymF9GFpaVo5hrfVgBN5e117kZqa1i4fLQoNPkGARTIlWMPikI6mM0P9RfCxRMVFEmgw9mEm7qxemaGtycMorS93y3bOvqYGPAr5YwF8S3LRMOk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757391426; c=relaxed/simple; bh=Vrtl+xs7K4zXcPnLFH1TuZOu/V+27YNQSOap/9QG3ug=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=R3fi6dAGn07AHvF028WO8IOx5zXPlhvvlKUc3sJEV1aeQ2fXHB5B0HAlPoqMDfq9xekyuk7UhewIWDp456keZbJ9JreNaTM0nU8VsdipU4wAIIJe//dTsHgdjA+1BkhwRuwSjLZ8cteNenwwrslw1LHRE0ev/n+2HK7v+sq8ZzM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=gazw1fRq; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gazw1fRq" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757391424; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PXc4wYDZmZ/L8uZekYzqBJVvEmMbocn1KotryOo59zE=; b=gazw1fRq3FlUpr9AAM3srtv70EnitSiZV8xi/tSoQH23d/eFrUHSaO3Fbbk8HdeB763MKJ aVXVF9u9e5+XNwWIu7n1FiE5wmL5kOFLLQKqAvhTnBrKp3HOOKkGC9DeaW5RTIf+blb9Xn +ajVRMs4H6imOqNeQvjWmRI110LiOmA= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-619-bsaSifLAP5qWy5scbKpHhA-1; Tue, 09 Sep 2025 00:17:02 -0400 X-MC-Unique: bsaSifLAP5qWy5scbKpHhA-1 X-Mimecast-MFC-AGG-ID: bsaSifLAP5qWy5scbKpHhA_1757391422 Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4b6019b13b2so105378211cf.3 for ; Mon, 08 Sep 2025 21:17:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757391422; x=1757996222; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PXc4wYDZmZ/L8uZekYzqBJVvEmMbocn1KotryOo59zE=; b=prrXucqITes1GFvkT2/EK44ZpYOQOTrm2lzWTlg4XBYELU7i3I2w2XI+v+yIBfPdvJ F88ReEAWrdI2JpPTAnIOAZLeRD66NRB8100cU37xF6berleWDXOU5O6c9qjJKIAlyq3D Gqw+Ih+PZa6URYqdyzK4/o9XkZCAtSoQP7/bmQV47WennpH7aZxiDGwDrPfetkSK81NV Q7FJS66PHXYVbav53ZVgKkbOBl8yq3QRp4qFr0FGs9aLKm1DZOvIletWfl0iCv/A7waW 8RZ3mYaNusA0KJNHeVS7DdaMVY47A+VACxU0hd8Y20QHHRI7vJW0rUv69dHUUCX9BpIe OCVw== X-Forwarded-Encrypted: i=1; AJvYcCWKOvffxAssENlLra4vAkdmTVS3A5Nfx6nvUxzvRRdJsqvnIsb0lJdHwRCyn/v3eANkbH9XafMj03c=@vger.kernel.org X-Gm-Message-State: AOJu0YwdM1QIbaAi7llP3/ewVG7Pq+ZwkEGG27rXg9aoPigTwO3F3zsZ r83Xf3/OqITBhRo86pdE8IVjKBiU6tm7HNhz+7E3MLtdP0wdPX5cNxrhPdsK7EKaCj/k1LDgrwc pW/weMeIvEUTqhmLzrEke9Alyl+vntc3BaKByv4pDiEQsyIs10CQByQwLhunnbw== X-Gm-Gg: ASbGncsAuRkDSKdSfCKQ4NE70XGtOUpj4BVXJGzJlIIdCj8ukDNzVP15Wwf8ghMFI6s 7T06ZFy3ZBPPI17bVZNgoz81Z4C8OkBNgS17X4WFQ0sf54i/fYdQl3wvlup/skex33zjG3BeaXq 3i4JfgeCQsRID3lsqkOaa15O2ybUcIYaSErSkn/0Ixw1mDB+rm/CG3fii+vnfwi5klNV8ACK5or bWErZHZecI1JapNWhOGj3m+sjhlevqYnycNaz/AFZMOCJ0jcVEI+b/+fMeIhaR3l5YQQVQmgNtA I9a+o8TpeXcCyB3AJwXo3Jni2PAz0LFFwALXK5UC X-Received: by 2002:ac8:7f56:0:b0:4b2:fcf4:44c9 with SMTP id d75a77b69052e-4b5f846701amr118252521cf.60.1757391422225; Mon, 08 Sep 2025 21:17:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHlZTe8MK04WhNv9/TediecLNUlQjS4uZJ6D+gPH8b1KU0M6GQFQ+qYugLVX8lKpMw4F3h/7g== X-Received: by 2002:ac8:7f56:0:b0:4b2:fcf4:44c9 with SMTP id d75a77b69052e-4b5f846701amr118252291cf.60.1757391421878; Mon, 08 Sep 2025 21:17:01 -0700 (PDT) Received: from [192.168.40.164] ([70.105.235.240]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-728a860bdebsm100439826d6.69.2025.09.08.21.16.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Sep 2025 21:17:01 -0700 (PDT) Message-ID: Date: Tue, 9 Sep 2025 00:16:59 -0400 Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 04/11] iommu: Organize iommu_group by member size Content-Language: en-US To: Jason Gunthorpe , Bjorn Helgaas , iommu@lists.linux.dev, Joerg Roedel , linux-pci@vger.kernel.org, Robin Murphy , Will Deacon Cc: Alex Williamson , Lu Baolu , galshalom@nvidia.com, Joerg Roedel , Kevin Tian , kvm@vger.kernel.org, maorg@nvidia.com, patches@lists.linux.dev, tdave@nvidia.com, Tony Zhu References: <4-v3-8827cc7fc4e0+23f-pcie_switch_groups_jgg@nvidia.com> From: Donald Dutile In-Reply-To: <4-v3-8827cc7fc4e0+23f-pcie_switch_groups_jgg@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/5/25 2:06 PM, Jason Gunthorpe wrote: > To avoid some internal padding. > > Signed-off-by: Jason Gunthorpe > --- > drivers/iommu/iommu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c > index 1874bbdc73b75e..543d6347c0e5e3 100644 > --- a/drivers/iommu/iommu.c > +++ b/drivers/iommu/iommu.c > @@ -58,13 +58,13 @@ struct iommu_group { > void *iommu_data; > void (*iommu_data_release)(void *iommu_data); > char *name; > - int id; > struct iommu_domain *default_domain; > struct iommu_domain *blocking_domain; > struct iommu_domain *domain; > struct list_head entry; > - unsigned int owner_cnt; > void *owner; > + unsigned int owner_cnt; > + int id; > > /* Used by the device_group() callbacks */ > u32 bus_data; ok, but still leaves a 32-bit hole at the end, which would occur in the struct if bus_data was put after id or owner_cnt. Reviewed-by: Donald Dutile