Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Mario Limonciello <mario.limonciello@amd.com>
To: Bjorn Helgaas <helgaas@kernel.org>,
	Alex Deucher <alexander.deucher@amd.com>
Cc: Oz Tiram <oz@shift-computing.de>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	Reza Nikzad Chaleshori <rezanikzadch@gmail.com>
Subject: Re: [PATCH 0/2] Fix amdgpu detection of pci=realloc
Date: Mon, 19 Oct 2026 21:06:32 -0500	[thread overview]
Message-ID: <daa45533-29be-47f7-bbfd-67b3045b63cb@amd.com> (raw)
In-Reply-To: <20261019-vfct-regression-v1-0-5a63ddd378dd@amd.com>



On 10/19/26 20:44, Mario Limonciello wrote:
> amdgpu needs to know the bus number the platform assigned a device to
> be able to match firmware images against the right device.
> 
> This was previously adjusted to be a soft filter due to
> commit 11c141672045f ("drm/amdgpu: Fix VFCT bus number matching with
> soft filter") where if everything but the number matched to take a device.
> 
> This however fails when there are two identical devices.  Instead save the
> initial bus number to the PCI device structure and then match that.
> 
> Link: https://lore.kernel.org/linux-pci/20261015124843.203905-1-mario.limonciello@amd.com/
> Link: https://lore.kernel.org/amd-gfx/20261019194106.2796150-1-alexander.deucher@amd.com/
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> Mario Limonciello (2):
>        PCI: Preserve the initial bus number in pci_dev
>        drm/amdgpu: Match VFCT using initial PCI bus number
> 
>   drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c | 17 +++--------------
>   drivers/pci/probe.c                      |  1 +
>   include/linux/pci.h                      |  1 +
>   3 files changed, 5 insertions(+), 14 deletions(-)
> ---
> base-commit: 87bba57a9f33e2b5e90d4ad70973675333182a2c
> change-id: 20261019-vfct-regression-2142fc52852a
> 
> Best regards,
> --
> Mario Limonciello <mario.limonciello@amd.com>

I think Sashiko is right on the feedback.  I'll iterate further on it.

      parent reply	other threads:[~2026-10-20  2:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-20  1:44 [PATCH 0/2] Fix amdgpu detection of pci=realloc Mario Limonciello
2026-10-20  1:44 ` [PATCH 1/2] PCI: Preserve the initial bus number in pci_dev Mario Limonciello
2026-10-20  1:51   ` sashiko-bot
2026-10-20  1:44 ` [PATCH 2/2] drm/amdgpu: Match VFCT using initial PCI bus number Mario Limonciello
2026-10-20  1:53   ` sashiko-bot
2026-10-20 13:18   ` Deucher, Alexander
2026-10-20  2:06 ` Mario Limonciello [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=daa45533-29be-47f7-bbfd-67b3045b63cb@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=helgaas@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=oz@shift-computing.de \
    --cc=rezanikzadch@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox