Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Stanimir Varbanov <svarbanov@mm-sol.com>
To: Bjorn Helgaas <helgaas@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH v2 0/4] PCI: qcom: Cleanups
Date: Thu, 13 Oct 2016 11:31:52 +0300	[thread overview]
Message-ID: <daf16f7c-63ec-0096-0ca8-e7eb8a21f1b6@mm-sol.com> (raw)
In-Reply-To: <20161012160654.GS4308@localhost>

Hi Bjorn,

On 10/12/2016 07:06 PM, Bjorn Helgaas wrote:
> On Wed, Oct 12, 2016 at 08:59:54AM -0500, Bjorn Helgaas wrote:
>>   - Remove platform drvdata because it appears unused (we called
>>     platform_set_drvdata() but not platform_get_drvdata()).
>>
>>   - Remove redundant struct members.
>>
>> Nothing here should change the behavior of the driver.
>>
>> Changes from v1:
>>   I dropped the following patch because it was a lot of churn for
>>   questionable benefit:
>>     PCI: qcom: Name private struct pointer "qcom" consistently
>>
>> ---
>>
>> Bjorn Helgaas (4):
>>       PCI: qcom: Remove unused platform data
>>       PCI: qcom: Remove redundant struct qcom_pcie.dbi
>>       PCI: qcom: Remove redundant struct qcom_pcie.dev
>>       PCI: qcom: Reorder struct qcom_pcie
>>
>>
>>  drivers/pci/host/pcie-qcom.c |   30 ++++++++++++------------------
>>  1 file changed, 12 insertions(+), 18 deletions(-)
> 
> I applied these to pci/host-qcom for v4.9.  I hope to ask Linus to
> pull them tomorrow, so if you see any issues, let me know soon.

Thanks for the clean up!

Reviewed-by: Stanimir Varbanov <svarbanov@mm-sol.com>

regards,
Stan

      reply	other threads:[~2016-10-13  8:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-12 13:59 [PATCH v2 0/4] PCI: qcom: Cleanups Bjorn Helgaas
2016-10-12 14:00 ` [PATCH v2 1/4] PCI: qcom: Remove unused platform data Bjorn Helgaas
2016-10-12 14:00 ` [PATCH v2 2/4] PCI: qcom: Remove redundant struct qcom_pcie.dbi Bjorn Helgaas
2016-10-12 14:00 ` [PATCH v2 3/4] PCI: qcom: Remove redundant struct qcom_pcie.dev Bjorn Helgaas
2016-10-12 14:00 ` [PATCH v2 4/4] PCI: qcom: Reorder struct qcom_pcie Bjorn Helgaas
2016-10-12 16:06 ` [PATCH v2 0/4] PCI: qcom: Cleanups Bjorn Helgaas
2016-10-13  8:31   ` Stanimir Varbanov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=daf16f7c-63ec-0096-0ca8-e7eb8a21f1b6@mm-sol.com \
    --to=svarbanov@mm-sol.com \
    --cc=bhelgaas@google.com \
    --cc=helgaas@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox