From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9267248176 for ; Mon, 16 Mar 2026 17:07:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773680864; cv=none; b=sVO95t7NO+SU5wK8XVg0RnaiZyWaLD43Xu01kpyaFWsvLKN6Prg0IbvJ98halErIKqtPt3it9X/0tcOwMD43t56CY0EGysQ7O1ZpWqrbynoD7uvTvaNTtKPlOrSRRut2pmtaQRa2klRuTXSSDFb+FQMdDMkPUjvt/6OzFIJDrMM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773680864; c=relaxed/simple; bh=ndSyZFZJ0iMwREzqBpvvKbaR/JlX2TVhp1ZhDsVoAMw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=G7laBGNmTt18jSZblXwwqgR/4Asm1gty5OgxOVB+KJQziSPkuKyXXMafCATMaUP9jGm3kOQ1fVxYIeeASFyzP9zKdyKogvJArZCmp9m17yMycfGRXvf7U4+sswZ49YyIGzojFUNFXwhVjfgeszPf/7yUA0KyImhtby9fJ7EfOWI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=X+Nlgmj4; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jsSgPz9/; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="X+Nlgmj4"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jsSgPz9/" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62GEgG3Z3295927 for ; Mon, 16 Mar 2026 17:07:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= n1xeMoYeUM0iSmvPxnEiOO/lpTwBXAxToBC2I8g5MT0=; b=X+Nlgmj4OOaKssRg 4e+d6j+YInLZbUUYEhBCPUFKoIM4YtGoc99GwqQ10TJmPjB/CmSuHpPwmbV7wSg+ gmPOqgVaLk8ZRcWDLGYwb4WoBNwYGGAQu9LwjKdtBF4Vq/PP8ILX80VePosnAn9/ VUBBXlO9VluIzXokZac37bTWrwu/A3+s3GmM9CEKFq++6YzLLn0yfllLDnndTx2S kyronXorVd/CLR6pMaqTIWmB5SUN5szZpHBFg6AuY1JRWB88ClPlvnATCqj73Fae 8wnwP1NqnvRuRn/MfB0lX8kaZ0Fjrfu8XnfDTCed23SOC09MYiYYPVBbVNuAGwNZ /Pg+zA== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cxkuy0hj1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 16 Mar 2026 17:07:41 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-829b6b22dabso2133629b3a.0 for ; Mon, 16 Mar 2026 10:07:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773680861; x=1774285661; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=n1xeMoYeUM0iSmvPxnEiOO/lpTwBXAxToBC2I8g5MT0=; b=jsSgPz9/LhZj9guteIaZiJ4CCd5b5CESPdwTK0jA57JAE7UpT01KfWIWlJhpqhpPUs N5u3CJrO5NMXiFKfpP7K/r8TyLUuPton5RESYPoc/5hKPVEVZVeS+Q72nqwLEGo9bxSU uq02hmCuIgClO67Qzw3KKkiqU7w0j75fbEnYZsq9ztrAn8d+M6p5w7a6D1UapRepgDDx khMMbhXOY4ITgqs8FBCuNDC06TfJyB9bQ436+VZg6wMjvW5Zx7z8/CneXp6HVZCnX0c8 Z67hLTbeVNtg7TTwJPdeF0ktwEwuW9N0itH9CvNLe5x6KCMkwPV/MtUnVHe7AAdIsiHH PwSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773680861; x=1774285661; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=n1xeMoYeUM0iSmvPxnEiOO/lpTwBXAxToBC2I8g5MT0=; b=N4jq4lHago9CpI40zU5kcv6qLjQMjN6yOTNUdf8iFLlwenbG0mpQLu1c9BXFc6GiSy pWesl1zXCAX/2p+gU4g5k/gAV4s3A4UV8FivpVFV8+uiadeqJtZ+vkNwMxqeUe9FLSY+ EMtm1rqskjJMfnXU6gajya/mL8MS1iq1keRSDLZUdpA5xQW+Hh4VbWpk9q8k+LvouPlA oYCLx9b8pyWea6X6f7lA3P+5OflONV+X19ma2p+ybyLlaWQ5CPxJjKpOIVP+Jfj3XXkj S3g4XhF1//3Fh2GDJ7gUJPGBSZHoWaYBB+PkYbS+1XUtL2pd32fDyk9R68bQijapGUIC I77A== X-Forwarded-Encrypted: i=1; AJvYcCUHBwha9b3ZPyDDHfSxEclr5sJSv58c10HGByGPfcCwmwoRoRzwr/3u0moOd1e9pQOWsHON/oCAYtw=@vger.kernel.org X-Gm-Message-State: AOJu0YzOR6OI+wnV4bwDAF9xaEDG7GbB5yb1hjLBvoqE4bDESI12+IsN f8sfhgFDtcAhDKtmXYPOZ5I74stVZBZwoU4+CFFyhF+rW8cRsQd6Og+f9oWNcEVkLB99R1KFsV0 lLtZIyDjK//7vPq2RmnwfRU8oVIf3Mmokm1Sy6lnzCJx4jdoygHfZKRarLMU/t+8= X-Gm-Gg: ATEYQzxc1rgX8CMNnmdFUw0C+mXstCbbJCBnTQq84E+Ff33CreSqnXZ2Gp0eKuvXitL eB63xlBjashrfveEJQfLG/ggXAdLIPfQwjouhCdmlyaLVnCef5H0/lc9gCWYTwiYIs1V+7v6+ej keZQkZxUehAl8nnPVAur8oyQwugIJhXkb23uEvipoG1IhmA6hbe3JUBvCgnGZmk6J55I21rkE7F QduUiL3x76ooBw/qQqvvPlkZullXBXrtGcAaBUbgzrGA6mymMEiKtpoJU2OJqCahTtKWjseNHj/ MR2t6tNZ3cT2pGfrPuFNkQzfV9rXXg2j0k/eJb2bXebO7d4jY6tsM4kAxQb59lhoDJ52DXWU3MC 3A0tYhN9C75tc7RPTHyxivhYjhVC4B+INU25JDYAqabGKxz4pE/tt09WSgQ== X-Received: by 2002:a05:6a00:854:b0:81e:81fb:b392 with SMTP id d2e1a72fcca58-82a196d9795mr12519537b3a.11.1773680860315; Mon, 16 Mar 2026 10:07:40 -0700 (PDT) X-Received: by 2002:a05:6a00:854:b0:81e:81fb:b392 with SMTP id d2e1a72fcca58-82a196d9795mr12519484b3a.11.1773680859759; Mon, 16 Mar 2026 10:07:39 -0700 (PDT) Received: from [192.168.1.12] ([38.254.186.229]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82a072418e9sm14954842b3a.3.2026.03.16.10.07.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Mar 2026 10:07:39 -0700 (PDT) Message-ID: Date: Mon, 16 Mar 2026 22:37:25 +0530 Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 2/3] of: factor arguments passed to of_map_id() into a struct To: Dmitry Baryshkov Cc: Nipun Gupta , Nikhil Agarwal , Joerg Roedel , Will Deacon , Robin Murphy , Marc Zyngier , Lorenzo Pieralisi , Thomas Gleixner , Saravana Kannan , Richard Zhu , Lucas Stach , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Bjorn Helgaas , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Konrad Dybcio , Bjorn Andersson , Rob Herring , Conor Dooley , Krzysztof Kozlowski , Prakash Gupta , Vikash Garodia , linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, imx@lists.linux.dev, xen-devel@lists.xenproject.org, linux-arm-msm@vger.kernel.org, Charan Teja Kalla References: <20260309-parse_iommu_cells-v10-0-c62fcaa5a1d8@oss.qualcomm.com> <20260309-parse_iommu_cells-v10-2-c62fcaa5a1d8@oss.qualcomm.com> <27edd195-b0d3-4214-9df3-74a84da1e3e1@oss.qualcomm.com> Content-Language: en-US From: Vijayanand Jitta In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=br1BxUai c=1 sm=1 tr=0 ts=69b838dd cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=FuYIH7Xx0xzBSkYrynBYgw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=VwQbUJbxAAAA:8 a=GQrJT2J37VpXmJLvS4cA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE2MDEzMyBTYWx0ZWRfX6GokunLAIE7s q0VhXkM2cnt+4rNFn8VITPMlprWzLGaXTxAl5MdgwKfAR/a4IM8zHzY4hCOrxATT1vQFnFh86xh 5xNDMI2pkXConlVD2G+pLlTyGL9wfqphkunjdLVZAWyczo3m9m890irQLZEVYkiSR9p5iPk/5YS rvQpLUkZBOFrTbmqS1IMeqmHVacQUOto13e5efSkK4fCusinfq4YamFUrrUWxjmb1FNoqL63tjA zRXywRl+TAtITy8HKBU1kJs4SET9WeXg3QaFNsoR2W/T2f4Cj2d+zMz/2mGG7+I9DZkTdkgMw3a 1v+hMi+pmiX/ckSEX0kwuPv7sd+vfQi1Kp+Yjw57IEpK1x0bBGz7MauDDUzrwPpzAxC0RqCJOT6 Obfrfe+1/LI/KVdUwblMp2fOOSuw3HrQwcmSVbz47am/piVmeOwZb7aJkQGQTsQNWYqRIlmOFF9 GEaSNfL/wDpjxS7O4zg== X-Proofpoint-ORIG-GUID: bhEZhbdFuL0majEXP_pBTbSVr9I-HRWe X-Proofpoint-GUID: bhEZhbdFuL0majEXP_pBTbSVr9I-HRWe X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-16_04,2026-03-16_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 phishscore=0 clxscore=1015 impostorscore=0 suspectscore=0 lowpriorityscore=0 adultscore=0 spamscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603160133 On 3/12/2026 7:48 PM, Dmitry Baryshkov wrote: > On Thu, Mar 12, 2026 at 05:12:51PM +0530, Vijayanand Jitta wrote: >> >> >> On 3/10/2026 2:53 AM, Dmitry Baryshkov wrote: >>> On Mon, Mar 09, 2026 at 01:03:38AM +0530, Vijayanand Jitta wrote: >>>> From: Charan Teja Kalla >>>> >>>> Change of_map_id() to take a pointer to struct of_phandle_args >>>> instead of passing target device node and translated IDs separately. >>>> Update all callers accordingly. >>>> >>>> Subsequent patch will make use of the args_count field in >>>> struct of_phandle_args. >>>> >>>> Suggested-by: Rob Herring (Arm) >>>> Signed-off-by: Charan Teja Kalla >>>> Signed-off-by: Vijayanand Jitta >>>> --- >>>> drivers/cdx/cdx_msi.c | 5 ++- >>>> drivers/iommu/of_iommu.c | 2 +- >>>> drivers/irqchip/irq-gic-its-msi-parent.c | 11 ++++-- >>>> drivers/of/base.c | 63 ++++++++++++++++---------------- >>>> drivers/of/irq.c | 8 +++- >>>> drivers/pci/controller/dwc/pci-imx6.c | 16 ++++++-- >>>> drivers/pci/controller/pcie-apple.c | 5 ++- >>>> drivers/xen/grant-dma-ops.c | 4 +- >>>> include/linux/of.h | 12 +++--- >>>> 9 files changed, 76 insertions(+), 50 deletions(-) >>>> >>>> diff --git a/drivers/cdx/cdx_msi.c b/drivers/cdx/cdx_msi.c >>>> index 63b3544ec997..03232b5ffbca 100644 >>>> --- a/drivers/cdx/cdx_msi.c >>>> +++ b/drivers/cdx/cdx_msi.c >>>> @@ -121,6 +121,7 @@ static int cdx_msi_prepare(struct irq_domain *msi_domain, >>>> struct device *dev, >>>> int nvec, msi_alloc_info_t *info) >>>> { >>>> + struct of_phandle_args msi_spec = { .np = NULL }; >>> >>> Why do you need to set it? Parse functions ignore passed args, don't >>> they? >>> >> >> The parse function does check arg->np on input — if it is non-NULL, >> it is used to match only entries targeting that specific node. >> >> Also, there is this existing path in drivers/pci/msi/irqdomain.c which >> pre-sets the node and passes it as input to of_msi_xlate(), so the node >> pointer is not ignored by the parse code: > > Is it only being used for MSIs? If so, can we make that explicit in the > API by having the 'filter' device_node pointer? > Yes, I see this is used only in the MSI path via of_msi_xlate(). By filter do you mean the below changes ? here of_map_id() and of_map_msi_id() would accept the filter as a separate parameter so that arg becomes a pure output: int of_map_id(const struct device_node *np, u32 id, const char *map_name, const char *cells_name, const char *map_mask_name, const struct device_node *filter_np, struct of_phandle_args *arg); int of_map_msi_id(const struct device_node *np, u32 id, const struct device_node *filter_np, struct of_phandle_args *arg); of_msi_xlate() would then pass *msi_np as filter_np down to of_map_msi_id and IOMMU callers would pass NULL to of_map_id. Does this look fine ? I can include this in v11. Thanks, Vijay >> >> u32 pci_msi_domain_get_msi_rid(struct irq_domain *domain, struct pci_dev *pdev) >> { >> struct device_node *of_node; >> u32 rid = pci_dev_id(pdev); >> >> pci_for_each_dma_alias(pdev, get_msi_id_cb, &rid); >> >> of_node = irq_domain_get_of_node(domain); >> rid = of_node ? of_msi_xlate(&pdev->dev, &of_node, rid) : >> iort_msi_map_id(&pdev->dev, rid); >> >> return rid; >> } >> >