Re: [RFC PATCH v10 1/5] iommu/vt-d: add pci_dev parameter to qi_submit_sync and refactor callers

Baolu Lu
2024-01-10T05:04:33Z

On 12/29/23 1:02 AM, Ethan Zhao wrote:
> Signed-off-by: Ethan Zhao<haifeng.zhao@linux.intel.com>

Please don't leave the message body empty. You should describe why do
you want to add the change in this patch.

> ---
> drivers/iommu/intel/dmar.c | 45 +++++++++++++++++++++--------
> drivers/iommu/intel/iommu.c | 26 +++++------------
> drivers/iommu/intel/iommu.h | 17 +++++------
> drivers/iommu/intel/irq_remapping.c | 2 +-
> drivers/iommu/intel/pasid.c | 11 ++-----
> drivers/iommu/intel/svm.c | 13 ++++-----
> 6 files changed, 58 insertions(+), 56 deletions(-)
>
> diff --git a/drivers/iommu/intel/dmar.c b/drivers/iommu/intel/dmar.c
> index 23cb80d62a9a..3d661f2b7946 100644
> --- a/drivers/iommu/intel/dmar.c
> +++ b/drivers/iommu/intel/dmar.c
> @@ -1344,7 +1344,7 @@ static int qi_check_fault(struct intel_iommu *iommu, int index, int wait_index)
> * can be part of the submission but it will not be polled for completion.
> */
> int qi_submit_sync(struct intel_iommu *iommu, struct qi_desc *desc,
> - unsigned int count, unsigned long options)
> + unsigned int count, unsigned long options, struct pci_dev *pdev)

How about adding a bit in options parameter to tell whether the @pdev is
valid?

Best regards,
baolu