From: Sinan Kaya <okaya@kernel.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org,
Derek Chickles <derek.chickles@caviumnetworks.com>,
Satanand Burla <satananda.burla@caviumnetworks.com>,
Felix Manlunas <felix.manlunas@caviumnetworks.com>,
Raghu Vatsavayi <raghu.vatsavayi@caviumnetworks.com>,
"David S. Miller" <davem@davemloft.net>,
Bjorn Helgaas <bhelgaas@google.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Juergen Gross <jgross@suse.com>,
Jia-Ju Bai <baijiaju1990@gmail.com>,
Alex Williamson <alex.williamson@redhat.com>
Subject: Re: [PATCH v6 1/7] PCI: Expose reset_type to users of __pci_reset_function_locked()
Date: Sat, 20 Oct 2018 12:21:21 -0400 [thread overview]
Message-ID: <df6c2825-b31f-043b-be8d-c905940e683e@kernel.org> (raw)
In-Reply-To: <20181020150353.GR5906@bhelgaas-glaptop.roam.corp.google.com>
On 10/20/2018 11:03 AM, Bjorn Helgaas wrote:
>> We can also drop the series if we think that current API are good enough
>> and nuances are well understood.
> I don't think the current API is good enough:) It's just a small
> matter of sorting out a better one.
I guess the next logical question is if you have any suggestion.
merge __pci_reset_function_locked() and pci_reset_function_locked().
Then save the context all the time?
What about locked vs. unlocked APIs? If there is a way to know if lock
is being held by the currently running task, we could skip the locking business
and unify these two APIs.
next prev parent reply other threads:[~2018-10-20 16:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-19 2:11 [PATCH v6 1/7] PCI: Expose reset_type to users of __pci_reset_function_locked() Sinan Kaya
2018-10-19 2:11 ` [PATCH v6 2/7] PCI: Expose reset_type to users of pci_reset_function() Sinan Kaya
2018-10-19 2:11 ` [PATCH v6 3/7] PCI: Expose reset_type to users of pci_reset_function_locked() Sinan Kaya
2018-10-19 20:20 ` Bjorn Helgaas
2018-10-19 22:18 ` Sinan Kaya
2018-10-19 2:11 ` [PATCH v6 4/7] PCI: Expose reset type to users of pci_try_reset_function() Sinan Kaya
2018-10-19 20:14 ` Bjorn Helgaas
2018-10-19 20:21 ` Brian Norris
2018-10-19 2:11 ` [PATCH v6 5/7] PCI: Expose reset type to users of pci_probe_reset_function() Sinan Kaya
2018-10-19 2:11 ` [PATCH v6 6/7] PCI: Expose reset type to users of pci_reset_bus() Sinan Kaya
2018-10-19 2:11 ` [PATCH v6 7/7] IB/hfi1,PCI: switch to __pci_function_locked() for reset request Sinan Kaya
2018-10-19 13:10 ` Doug Ledford
2018-10-20 2:09 ` [PATCH v6 1/7] PCI: Expose reset_type to users of __pci_reset_function_locked() Bjorn Helgaas
2018-10-20 2:58 ` Sinan Kaya
2018-10-20 15:03 ` Bjorn Helgaas
2018-10-20 16:21 ` Sinan Kaya [this message]
2018-11-08 20:31 ` Alex Williamson
2018-11-08 21:13 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df6c2825-b31f-043b-be8d-c905940e683e@kernel.org \
--to=okaya@kernel.org \
--cc=alex.williamson@redhat.com \
--cc=baijiaju1990@gmail.com \
--cc=bhelgaas@google.com \
--cc=boris.ostrovsky@oracle.com \
--cc=davem@davemloft.net \
--cc=derek.chickles@caviumnetworks.com \
--cc=felix.manlunas@caviumnetworks.com \
--cc=helgaas@kernel.org \
--cc=jgross@suse.com \
--cc=linux-pci@vger.kernel.org \
--cc=raghu.vatsavayi@caviumnetworks.com \
--cc=satananda.burla@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).