From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DC5EC433E1 for ; Thu, 28 May 2020 06:53:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2C90421475 for ; Thu, 28 May 2020 06:53:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WeIYDG9i" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726006AbgE1Gxi (ORCPT ); Thu, 28 May 2020 02:53:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726036AbgE1Gxe (ORCPT ); Thu, 28 May 2020 02:53:34 -0400 Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6EB9CC08C5C4 for ; Wed, 27 May 2020 23:53:34 -0700 (PDT) Received: by mail-pj1-x1043.google.com with SMTP id 5so2603829pjd.0 for ; Wed, 27 May 2020 23:53:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=zbKuT3nrBchNOXLtoqggayeJJOXuYIPFyuAneEl5VZE=; b=WeIYDG9i+HPcpC+T7wLyd72laBytTR0RvEwehEj45sRWw4OKQzXYNNFynXnVehee4d Xz6/jjgw409iODdX8f+4nfB4ksOmJlLeRUjPatyd73dc4YdD/O6i/XN42ATrsS/CHqC2 Hj1KqTS/6K1rdwTjZSmW73Clu5pi1g+wvul9mqCnXjpkHb3po6GXlCny3fXX4LNkVWWh +Rf0+FfG/tiIkuRFgH2XUOnYBAJUB98HYAgq5RhcSvah+qLAhflgOXk0g/sakA7NLXbh qEjIntovK2YBpTUr74m+FL9V9Iy1pdy/deZKUseiSeBwZTjQlJikyz4UUCdSr+OwEHgX 9Dug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=zbKuT3nrBchNOXLtoqggayeJJOXuYIPFyuAneEl5VZE=; b=SH+DBWYDrAxeUc+pv5yvKfbSI01JiF8LJl9vvXS70S2Ds1NcGPfzVUzkHhq6fkNBMR 0T/ofZndwuEi2/m/8WOSZQ7AR3zXq5T4LfoKS3asQsxyMI+hG4XfV+eaPQ/9wea+ufi4 13eGBaxxM2M5r4WzKXH52KRuFRXvXQqqjAUqSsDREhY14oY2Vl9+eFmqBerKwINss9Vt sC0DIzHblxAEyQ71DJG7X6yfCseTJIJ7p+8mSFsM7WCbQAWWGWeZ5NlWFbTAp9x3Kduo VciOM1N2v/8fNCc6pGDKIdNrZEJ3RLkaIk261v0puMmWzDzgIQwvKjUOT4UU1GutjzCl 9mBw== X-Gm-Message-State: AOAM531GtqIoGomDF5c0MmVih7zkzeScMYYw+MCm7IyGtdgoZQ7X5piv gTAUGP7y+uXxk1jgsExvDQ81UFhpLqhdIw== X-Google-Smtp-Source: ABdhPJzZUXUIWStr7BtNwklBZN744dC8lv7AAZWH3qxAABW36QOxKh3qydTDu9mclcxQ1QgO9lDG4g== X-Received: by 2002:a17:90a:d317:: with SMTP id p23mr2285917pju.107.1590648813784; Wed, 27 May 2020 23:53:33 -0700 (PDT) Received: from [10.140.6.42] ([45.135.186.12]) by smtp.gmail.com with ESMTPSA id g18sm3799582pfq.146.2020.05.27.23.53.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 May 2020 23:53:33 -0700 (PDT) Subject: Re: [PATCH 2/2] iommu: calling pci_fixup_iommu in iommu_fwspec_init To: Greg Kroah-Hartman Cc: Joerg Roedel , Bjorn Helgaas , Arnd Bergmann , Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , "Rafael J. Wysocki" , Len Brown , jean-philippe , Herbert Xu , kenneth-lee-2012@foxmail.com, Wangzhou , linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, iommu@lists.linux-foundation.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org References: <1590493749-13823-1-git-send-email-zhangfei.gao@linaro.org> <1590493749-13823-3-git-send-email-zhangfei.gao@linaro.org> <20200527090115.GB179718@kroah.com> From: Zhangfei Gao Message-ID: Date: Thu, 28 May 2020 14:53:20 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200527090115.GB179718@kroah.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On 2020/5/27 下午5:01, Greg Kroah-Hartman wrote: > On Tue, May 26, 2020 at 07:49:09PM +0800, Zhangfei Gao wrote: >> Calling pci_fixup_iommu in iommu_fwspec_init, which alloc >> iommu_fwnode. Some platform devices appear as PCI but are >> actually on the AMBA bus, and they need fixup in >> drivers/pci/quirks.c handling iommu_fwnode. >> So calling pci_fixup_iommu after iommu_fwnode is allocated. >> >> Signed-off-by: Zhangfei Gao >> --- >> drivers/iommu/iommu.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c >> index 7b37542..fb84c42 100644 >> --- a/drivers/iommu/iommu.c >> +++ b/drivers/iommu/iommu.c >> @@ -2418,6 +2418,10 @@ int iommu_fwspec_init(struct device *dev, struct fwnode_handle *iommu_fwnode, >> fwspec->iommu_fwnode = iommu_fwnode; >> fwspec->ops = ops; >> dev_iommu_fwspec_set(dev, fwspec); >> + >> + if (dev_is_pci(dev)) >> + pci_fixup_device(pci_fixup_iommu, to_pci_dev(dev)); > Why can't the caller do this as it "knows" it is a PCI device at that > point in time, right? Putting fixup here is because 1. iommu_fwspec has been allocated 2. iommu_fwspec_init will be called by of_pci_iommu_init and iort_pci_iommu_init, covering both acpi and dt Thanks