From: Krzysztof Kozlowski <krzk@kernel.org>
To: Thippeswamy Havalige <thippesw@amd.com>,
manivannan.sadhasivam@linaro.org, robh@kernel.org,
linux-pci@vger.kernel.org, bhelgaas@google.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, devicetree@vger.kernel.org
Cc: bharat.kumar.gogada@amd.com, michal.simek@amd.com,
lpieralisi@kernel.org, kw@linux.com
Subject: Re: [PATCH 1/2] dt-bindings: PCI: xilinx-cpm: Add compatible string for CPM5 controller-1.
Date: Fri, 6 Sep 2024 11:56:27 +0200 [thread overview]
Message-ID: <e985a9d4-b398-4290-a4b9-08999c6a9f71@kernel.org> (raw)
In-Reply-To: <20240906093148.830452-2-thippesw@amd.com>
On 06/09/2024 11:31, Thippeswamy Havalige wrote:
> The Xilinx Versal premium series has CPM5 block which supports two typeA
> Root Port controller functionality at Gen5 speed.
>
> Add compatible string to distinguish between two CPM5 rootport controller1.
Subjects NEVER end with full stops.
>
> Error interrupt register and bits for both the controllers
> are at different.
>
> Signed-off-by: Thippeswamy Havalige <thippesw@amd.com>
> ---
> Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml b/Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml
> index 989fb0fa2577..b63a759ec2d7 100644
> --- a/Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml
> +++ b/Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml
> @@ -17,6 +17,7 @@ properties:
> enum:
> - xlnx,versal-cpm-host-1.00
> - xlnx,versal-cpm5-host
> + - xlnx,versal-cpm5-host1
That's poor naming. "-1.00" and now "1". Get your naming reasonable...
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-09-06 9:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-06 9:31 [PATCH 0/2] Add support for CPM5 controller-1 Thippeswamy Havalige
2024-09-06 9:31 ` [PATCH 1/2] dt-bindings: PCI: xilinx-cpm: Add compatible string " Thippeswamy Havalige
2024-09-06 9:56 ` Krzysztof Kozlowski [this message]
2024-09-06 10:43 ` Havalige, Thippeswamy
2024-09-06 10:46 ` Krzysztof Kozlowski
2024-09-06 10:50 ` Havalige, Thippeswamy
2024-09-06 12:19 ` Krzysztof Kozlowski
2024-09-11 4:54 ` Havalige, Thippeswamy
2024-09-06 9:31 ` [PATCH 2/2] PCI: xilinx-cpm: Add support for Versal CPM5 Root Port controller-1 Thippeswamy Havalige
2024-09-06 9:56 ` Krzysztof Kozlowski
2024-09-06 19:19 ` Bjorn Helgaas
2024-09-12 9:38 ` Havalige, Thippeswamy
2024-09-07 6:15 ` kernel test robot
2024-09-07 9:00 ` kernel test robot
2024-09-07 10:01 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e985a9d4-b398-4290-a4b9-08999c6a9f71@kernel.org \
--to=krzk@kernel.org \
--cc=bharat.kumar.gogada@amd.com \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=michal.simek@amd.com \
--cc=robh@kernel.org \
--cc=thippesw@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox