Linux PCI subsystem development
 help / color / mirror / Atom feed
From: "Wouter Bijlsma" <wouter@wouterbijlsma.nl>
To: "Krzysztof Wilczyński" <kw@linux.com>
Cc: "Lukas Wunner" <lukas@wunner.de>,
	"Bjorn Helgaas" <helgaas@kernel.org>,
	linux-pci@vger.kernel.org,
	"Ilpo Jarvinen" <ilpo.jarvinen@linux.intel.com>,
	"Mika Westerberg" <mika.westerberg@linux.intel.com>
Subject: Re: [PATCH] PCI/bwctrl: Fix NULL pointer deref on bus number exhaustion
Date: Sun, 23 Mar 2025 14:07:20 +0100	[thread overview]
Message-ID: <eaa54741-e15c-457b-9313-1d5bcb518860@app.fastmail.com> (raw)
In-Reply-To: <20250323125652.GJ1902347@rocinante>

Hi Krzysztof,

> Would you be happy to provide your "Tested-by:" tag?

You can use 'Tested-by: Wouter Bijlsma <wouter@wouterbijlsma.nl>'

-Wouter


On Sun, Mar 23, 2025, at 1:56 PM, Krzysztof Wilczyński wrote:
> Hello,
> 
> > The patch is working, no kernel crashes and shutting down after hotplugging the Thunderbolt 4 dock does not hang anymore, thanks!
> 
> Thank you for testing!  Appreciated!
> 
> > I still see messages in the kernel log that 'devices behind bridge are unusable' because 'no bus can be assigned to them', 'Hotplug bridge without secondary bus, ignoring', etc. These all refer to the Thunderbolt 4 bridge. Adding "pci=hpbussize=0x33" to the kernel doesn't make a difference. Adding "pci=realloc,asssign-busses,hpbussize=0x33" actually does 'fix' the bus allocation failures (or at least I don't see any messages in the log anymore), but then amdgpu fails to initialize the IGP.
> 
> We can fix any outstanding issues or drop this patch.  I leave it to hot
> plug experts like Ilpo, Bjorn and Lukas to make the call here.
> 
> > Anyway, all devices connected to the Thunderbolt 4 dock appear to work (USB, screens, ethernet) even despite these bus allocation failures, so I will just ignore them. 
> > 
> > Thanks again!
> 
> Would you be happy to provide your "Tested-by:" tag?
> 
> Krzysztof
> 

  reply	other threads:[~2025-03-23 13:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-22 18:52 [PATCH] PCI/bwctrl: Fix NULL pointer deref on bus number exhaustion Lukas Wunner
2025-03-23 11:24 ` Krzysztof Wilczyński
     [not found]   ` <2e16d6af-7d7d-47a7-9c69-26f0765a83d6@app.fastmail.com>
2025-03-23 12:56     ` Krzysztof Wilczyński
2025-03-23 13:07       ` Wouter Bijlsma [this message]
2025-03-23 13:39         ` Krzysztof Wilczyński
2025-04-04 13:06       ` Ilpo Järvinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eaa54741-e15c-457b-9313-1d5bcb518860@app.fastmail.com \
    --to=wouter@wouterbijlsma.nl \
    --cc=helgaas@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=kw@linux.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=mika.westerberg@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox