From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 790F728FA93 for ; Fri, 13 Jun 2025 23:28:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749857310; cv=none; b=pIl+SAkhwfKJ03LT3cwksMN117OpQM0nGZXb5DHZHzBY0YVrF5l4SUPWH1XNb8T3jqOsV6e0vMBPsEayWm0iD7sjbxjVOfB93Vq0jmABglUDgs15LhurXnj55oQfU5A9yAmM5LzcGjS763sgG4GAGFG8qBFsVQA0Wr2Bt7qWhGI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749857310; c=relaxed/simple; bh=2Mqj1erFnz6eSrH6OrYi/A52QDuDNTJKYtEZmzU2yFI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gXe9M19sFGGMJf2sj0o3Q7eACoDcQXTQwiXB8YIKCQD52JOVP3TBwuRfUKSU+iQXgR27Ahh/Yt6qOehtuPE1iil+TGLjV2/nvjgsnr0xjrf+KStZgoMv/n16K+Kf46Zg2Y1A4/+2FKE0d5tBSJTf62V36tJIH++xAjvCGzFPlV8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=iKF1+zMd; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="iKF1+zMd" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2351227b098so22747415ad.2 for ; Fri, 13 Jun 2025 16:28:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1749857309; x=1750462109; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=tVIgyEp369YGSVHAgR24zVsOgiLYMbHVkjFj8orXwT0=; b=iKF1+zMduC7foWTxBH0wHi+rI2pWqqgb5zRu38wBo75Hl+3ScSzHJmEiHoWM8n4QMi 338Cus5pyywdK8dU3XONx/uQn2JBQLhO9Q3n6FRWtmHQi8zkpVB75LMkirekZN/vMk4m CzDkMQDJWve08SJw6MwySepiC8USf/6Egwi4k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749857309; x=1750462109; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tVIgyEp369YGSVHAgR24zVsOgiLYMbHVkjFj8orXwT0=; b=FSYJpz/8bCGl2fVcnhu8xpKmNw6d6tUch5+pCkdimS3rOY89fq0W8jBKVkudCTr/vc KNsAiCptewjLYGTPjXnuIb9+Yl26mjz2AJkmEJNqEluqxZRz2vsddvEY4iVxGZdB/0ZQ IHQJkPhmM+EnFHYLgmvB8/Y3mkI2RR8LwpFkH1CtZaibIfp2w27fTu/gU7kLyE4oIipx kgKHv2ha6pEO/cSTqdyQfXs3O6H3Pa84BMwLbXS1ZE67uOxAFlZEVrvcMik0S6Dncotc SoWGDeJzGuB9tEoNqDE2td+IT5KSHOHDirz6+0LIoSudMninx7D6ulazY7CVp3LobeYZ nw6w== X-Forwarded-Encrypted: i=1; AJvYcCUJKdufuSa57F5CXp3/ATq4q9F9I50hWG0rCX84oKmuOflA3SGoAYle5I+K7eP7imq66C6NMBIyUzI=@vger.kernel.org X-Gm-Message-State: AOJu0Yy4/QiULqHNNsQZ7Zf5gEcOb0iQYflHZ6SIdRCOWnG45oKxRYcV n+YLFkr9hII6jCG8ohJGnsePqmbgdKtj4lS2gQeCeGGb9DYQrhPyvyodCNpbe03LvA== X-Gm-Gg: ASbGnctIrRSpr/mVWNg4dMiY4LRD2hbBO2C5mRc84bJ6zQ8l7xw/vduSHB/qVzr7HN4 wgH1kZmRsbTjEXdA/XpcPeUOaz1Pgb2QKOZ4kgYh0IuxNKEMrFmNkTC9Mx0HcjuYAe9itQqeg1O YoRG9x1WLyKpcFZ073zD/buix3HqShltpoydsWeKeN47QE1hi6gWVQLmMwFTsgC6vCGzc21aRPo I3wA/7Fcfp8SRB7IUm03GlNnBIhe9C51mkEUo9PcMWOeWmCuOPnlTuUxHH1g9ROEFskLEc26h3s FLAW2D7ByA5ovuxONulM6NFEJcHcruvH8WMFm0+IuSYhfGS/snOMl4yVxLu3RMCnOkTKFW3KV1F bN1jJxBV/QZVdTjdkbBvZV2javw== X-Google-Smtp-Source: AGHT+IFRMv4pLDDHZkU3igLGyfy5y+yaEPSSBvXVtQJ9pTX4uJU4gfxC9bWCYgV8MTIXuT7DWuR7ng== X-Received: by 2002:a17:902:d543:b0:234:db06:ad1 with SMTP id d9443c01a7336-2366b16cd2dmr19148195ad.0.1749857308692; Fri, 13 Jun 2025 16:28:28 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2365deaaa15sm20255465ad.173.2025.06.13.16.28.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Jun 2025 16:28:27 -0700 (PDT) Message-ID: Date: Fri, 13 Jun 2025 16:28:26 -0700 Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] PCI: brcmstb: Add panic/die handler to driver To: Jim Quinlan , linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com Cc: Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list References: <20250613220843.698227-1-james.quinlan@broadcom.com> <20250613220843.698227-3-james.quinlan@broadcom.com> Content-Language: en-US From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <20250613220843.698227-3-james.quinlan@broadcom.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/13/25 15:08, Jim Quinlan wrote: > Whereas most PCIe HW returns 0xffffffff on illegal accesses and the like, > by default Broadcom's STB PCIe controller effects an abort. Some SoCs -- > 7216 and its descendants -- have new HW that identifies error details. > > This simple handler determines if the PCIe controller was the cause of the > abort and if so, prints out diagnostic info. Unfortunately, an abort still > occurs. > > Care is taken to read the error registers only when the PCIe bridge is > active and the PCIe registers are acceptable. Otherwise, a "die" event > caused by something other than the PCIe could cause an abort if the PCIe > "die" handler tried to access registers when the bridge is off. > > Example error output: > brcm-pcie 8b20000.pcie: Error: Mem Acc: 32bit, Read, @0x38000000 > brcm-pcie 8b20000.pcie: Type: TO=0 Abt=0 UnspReq=1 AccDsble=0 BadAddr=0 > > Signed-off-by: Jim Quinlan Reviewed-by: Florian Fainelli -- Florian