From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2049.outbound.protection.outlook.com [40.107.220.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CEB81188580; Fri, 7 Feb 2025 18:50:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.220.49 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738954225; cv=fail; b=DRhWHG12lmSx+Ng6awglKAvR/y3M+WSvckRkld+mEoOOO18hplNYyNeM1ERpB/9lP/EoRdmlMuUhDFTZOkqMh0sah5NFa/wSUQgMJrE2GQSSIFH+qdl/bO86IdO87fG0ZQHxhfq0JLkOcAcuZU/oSmiFB0vptKF/7p44fKFa+XQ= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738954225; c=relaxed/simple; bh=Zj4sabk1aNwujAMEmSqmP225qDE4PwKs3uPPbnNhEv8=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=u5/FtbgjsFhusduFnKwSa2ePIpzT162/SyegNbP6eCmV8RBJpXatkYZv6d5YWyhq4IftOOZyYEZBF5dz0v0kpIzrLFflcipT8ksaYNocTEISHgPlvS3tPkWErreqP+uc37myvfF8mpYPLkhsXUWuIWBKwpBRBTqGss4i0IY2Qyk= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=Fr5aEIBL; arc=fail smtp.client-ip=40.107.220.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="Fr5aEIBL" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KJeardcM1riO2kGRKjFQAhEIO+enmvQzsI58/jjsypEN6JbmSG0n94Qu5bh0bYeejMlIZCtHcARY5Eiv7yq8FO+0KqZBKhdhehOqtNiopuxpfpJPD/EwclUfzrZSHCKRyeOTktbq8cNjvE8eiAa7h7dQEW643O06bKQhI/a6EtpUJHScID1CfaOKjJBPbEMceNZe+/sciVfPM5TXSTU5iP8QpQkXlKV0Ck/6wpmybbw1xEuRQskIyNhxc7je95zcjTnyupmBzVT39I3EY3w+41J1YKFuUStOM6+z0jF/EnujqEVoIMwRHRYb7i78oN67AkvhEY9t3gza1EPJmz2beA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VKeGjOG+52yWvFb/0eZNiF+jjl1PMFaR+fbaMW5hig0=; b=c4MUfrJDqiu909k8XI+oTSE7Cgy0s9UxcwGCbAVAOabGlYfZ+UO4kP56uvmUOHR9nS23/4LADoBdResUObjH5FHB3kQZgZABNOtQ8PHHz84hq/4Zv8zTUrxd3CbJPd8DUDqwpRagDI7SNYvWT7hQ73fSiMiYhzr6ym9D65jeqAlOtHy8AdssO5h5uSDE4SKEi+be4+agsv32YxGob+Z2+t5HgO9N7pu3ViuIQU0B8GtR2ldJIOlr6/Q4YeEb9jtrYPSf98TkDSLldLZS1vzAwHIjwK8xnl9yYshAFg1mM1dE+yUQuIGlGtxZ4BWYptCpK+qU9dbgGSNRrsBigJFbdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VKeGjOG+52yWvFb/0eZNiF+jjl1PMFaR+fbaMW5hig0=; b=Fr5aEIBLOqpqL4SaW3s/a3jXKZRZf+/RcZicl82+eGr5hYwa4zdpE8WEojfXMZu4s4C4D+hiv69ctwBeyIenKrSHNBHAWWZ5MhaNt+NksQiH2LwnAoKdagcZKjS/9n6EJLpADMBSCbYnuM14TznjCFd3DH9oA10YC1Tdh/Eq90k= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DS0PR12MB6390.namprd12.prod.outlook.com (2603:10b6:8:ce::7) by PH7PR12MB6636.namprd12.prod.outlook.com (2603:10b6:510:212::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8422.11; Fri, 7 Feb 2025 18:50:15 +0000 Received: from DS0PR12MB6390.namprd12.prod.outlook.com ([fe80::38ec:7496:1a35:599f]) by DS0PR12MB6390.namprd12.prod.outlook.com ([fe80::38ec:7496:1a35:599f%3]) with mapi id 15.20.8422.010; Fri, 7 Feb 2025 18:50:15 +0000 Message-ID: Date: Fri, 7 Feb 2025 12:50:11 -0600 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 04/16] PCI/AER: Modify AER driver logging to report CXL or PCIe bus error type To: Gregory Price Cc: linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, nifan.cxl@gmail.com, dave@stgolabs.net, jonathan.cameron@huawei.com, dave.jiang@intel.com, alison.schofield@intel.com, vishal.l.verma@intel.com, dan.j.williams@intel.com, bhelgaas@google.com, mahesh@linux.ibm.com, ira.weiny@intel.com, oohall@gmail.com, Benjamin.Cheatham@amd.com, rrichter@amd.com, nathan.fontenot@amd.com, Smita.KoralahalliChannabasappa@amd.com, lukas@wunner.de, ming.li@zohomail.com, PradeepVineshReddy.Kodamati@amd.com, alucerop@amd.com References: <20250107143852.3692571-1-terry.bowman@amd.com> <20250107143852.3692571-5-terry.bowman@amd.com> Content-Language: en-US From: "Bowman, Terry" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SA9PR10CA0005.namprd10.prod.outlook.com (2603:10b6:806:a7::10) To DS0PR12MB6390.namprd12.prod.outlook.com (2603:10b6:8:ce::7) Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB6390:EE_|PH7PR12MB6636:EE_ X-MS-Office365-Filtering-Correlation-Id: f7fc04a9-9a7f-47cd-2203-08dd47a84298 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|7416014|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?eDVEcDltSFYwSTRWeFIxWUNJZ2JtTTFQZVhLU2dkaGlXMVVNdStNKzg3RzQ2?= =?utf-8?B?UCszdFl2UGc3ZzlHa1c1cVdNS01TZS9jdGRjMXdTZ00yWVB2ZGZYandNak4z?= =?utf-8?B?YlhTOGFtdldhVms0anlHSDZveWpGYnlNYVpaWXBtNnoyaCtlOU1JVS9YbG1Q?= =?utf-8?B?Qi9pd21MUzBvdTROMWNKYWFpVm5abDJNRkszVEdQUzJ2NjgydDFheS9vLzNR?= =?utf-8?B?V2pLZ2hVT0NRNklZNU1ieXpaTWF3b3pYc1dwN3RmUEdKN0pDSGF3VHVVYVBt?= =?utf-8?B?aFlzZjg1aTVpOFdoRDlXU29NRU41ZGNIejJGSm13cjI3Qmx0b3hWa1dwcFp1?= =?utf-8?B?VGRFcXVrMDNZcldUNWcxb0dsc1B3T0w2RXRZeGJGNnRnaytKcHA1RFFOWlU3?= =?utf-8?B?VWs4VGt1RGFFTTZGL2p1MTZERHlCVmd6anZNZVJNVENHWVlqOWZwZTYxUWRl?= =?utf-8?B?WFAvZWo0Zjl6M1BoU0gwKzNuR1BJYTI4cXVxQllzaVlWV09rT0R0RHl4U2Fu?= =?utf-8?B?R2J0Mk5JaGhuK0ZjRlFHMVlFbU1rYjJHNkJiK0pDMU1RT1RHaWtnbFd6Z05u?= =?utf-8?B?Uys3ME5TYUFnalZYbGt3M0tzdElqbFhxbWxkeVEreU9iVmtuVDNIU3IwZVFV?= =?utf-8?B?T1RoYTFKUFBpWGVXWStoMkxsckRwNlhPM0xKN29YRW9EWnllVjVQMkY4QjND?= =?utf-8?B?ZlBqdTZ0ZEFUejdSUUhqVWp2bnNwc3NVMjFXWndjQWlGcU52RTQ3eVJYaE5T?= =?utf-8?B?VVByeFRMK2huTUhEQWtNb2V0aXBucEtGRWRGaVlyMUZ1SFNMbnlBOEtiWGhm?= =?utf-8?B?TnZVSXlyZWdxa0MzSlIwWmlmT1B2VjBDckVqM1R0Z1VXQTF3Q3VNVStzZ0JE?= =?utf-8?B?Yk1tcGl5UTE2RUltSFh3dEp5MDJROElxSk9VOERraHFObXMycnNYQkRlYzNm?= =?utf-8?B?WTduYndSbUZlcCtpeVZtSTlITmcrNGVFWlAwYmtDSHBYcnkzaTlnc1lsd01W?= =?utf-8?B?akNSb0s1djJYWmpXWUJ0dUlBaFRaalFoTFBGaDVwdHdWWXRqQ0lzcHFFRXIx?= =?utf-8?B?Nm9CZGRhbGp2Ny9IeE9QdWRYek5vZytpY1dNaTdhL25KYkZVUERydUdnVE1J?= =?utf-8?B?cXVZOHVMY1g4MDFRVzBXV0s3ODJIU1IveW5acEFnN1p1VnkwaEd2dEJ2dkVK?= =?utf-8?B?RHFLWHphR3MyOWluRUJZSzZOREMxT1c4QkRsYnh0ZEorK2NiUWJnU1BUUDFU?= =?utf-8?B?Y2RYZ1Yxc2VtVmxZQTczY2tSTWJjK1QyTFN3VlNzM1Zub1RZUCtUUTI5V01J?= =?utf-8?B?UGxTT0wrQWw4RUdCWWRvc1ErY3YzQjFwaVUxdGhHeHpzN0FOWFJLa3RmOTM3?= =?utf-8?B?RU9nT29DZ2VDSTRNYWdXZitHTmlwT2lvQmNBVUd2YUlHSGh1UldMMUh6ZjAz?= =?utf-8?B?TXZXeS9kaGxyVVd2eS8vRmg4YlUzYzlLSUNGRkQza054aHp1eEtaK3JrcjBB?= =?utf-8?B?ZWI4V2lVUzlXNTBIbkhBQzk1dUZDclR6TzhZMXk4OFNDVTVQRGlPdzYrcFNV?= =?utf-8?B?eklwdEVpUk5VQnNYUUVxUmRGSmIreGRBL1krUTBSQlM2Mm52MVV2bTRncEZj?= =?utf-8?B?QTMrNFZIR1hVaUFrWlp1L1F0UUFsUGdxbjg0VXlJSVU0WGpseW9ZTU5DSjA2?= =?utf-8?B?bk5HamVYQ0ZkRGZ1RENYczlxM2Y0OHkrSmREd2Rwa0RDd3Q2WTk4NllyVGts?= =?utf-8?B?U1poV3dPSnZkanlOZ1IrajhUYnR4bkVYblpxd3dVMkI4N1NGWXMwMGNKb1Rq?= =?utf-8?B?SCtuNzVOUFdKeXRBNDNRT2RUblJkMGtXQ293NkEyaGMxLzhXV0UydWZ1OE01?= =?utf-8?Q?ft1hv3KZGuY0g?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB6390.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7416014)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bmNxUXlZdnlZdjR1K3RsV1IxR0M5dFZCRVdJeWc4YXBYNEsxaXVFcmJ2bFZI?= =?utf-8?B?cEc1RGd5S2N2QVA5NjRSSFo2TndVRVl4WmNQcEVqMnlNTVhpUFc2eHIvZHJZ?= =?utf-8?B?Q0JwOEQzYmV4SzdlR3kxODJlTlJkOGUwOUVPR1I3ZzdJd2dUUEFHNWdBaFVE?= =?utf-8?B?V3dqZUpOTlk4ZDJPSk5uaUZFeVl1UmxWVkZ0T2o0bExtZUppNGVxN3NJN2hI?= =?utf-8?B?LzZrc0pDU3ZNQmkxRm9nRFh3R2hCSFJjUVRrcVJjMkV6TkJ3WU1NOFFtNUUw?= =?utf-8?B?eFNhekowN0ZxMDBaN1RoQ3k2V3ZJa2pTZlBhRG96Yk1GNUhzOG1ZVkZDUnRS?= =?utf-8?B?dDZjcnpGSE84UFhjTFpvZFlSVjJIMHhnVW9IRldFcmhhSFhkLzhVTk5GRDhO?= =?utf-8?B?VHBQYmNKemtld0FLTGxHdnVmMENzVDVjWW8rcDZ3YU1VSWRlRE5kY1FZS21n?= =?utf-8?B?VWRNRkZ6b1IzWUp2dWgxUnI4N0lVbFFSb0NYRjR6SERZcitJdHJ0SjRPRmpj?= =?utf-8?B?aVdEREtOK2Q3UEdMc2tWTXN6MGZ5RUs2V240TytVSUUyRFNqNi9CT1pNRFY2?= =?utf-8?B?MUtVNXlUUmlqWWt0M2lYWEtDK2dnbXBQR3pqV1lFdlo1cmNFTEtDUU1mZUpR?= =?utf-8?B?bmxaMVY0Tm5RQ1g3elZRMmRURS9WbXhXaFMrQy9aOUpYUmlJaGhYUlpWVlRi?= =?utf-8?B?dkt6bE1QWjA0SHJKdXp2Kzk5UXFzZ1BDSkZjRE9TeUxZZTZHUjNYTkNiTVln?= =?utf-8?B?U3luUzVKZ2VhNEJhQlZESkFXUDJ2WFhpaFZOek1ZL0RuZ3FIdzRSa1FiSENk?= =?utf-8?B?WVhZSHU1NnlqcFUrOUVyY0wzMG5SWndRZjVMZGVLTHd6WFdObmF0aitOVUpT?= =?utf-8?B?VjN0QzJZdnY4S2t2ZGdJOUZIY2s3amtIT1pXRFBBTWk3ZHhvYU95UExuY2NG?= =?utf-8?B?MXQzbGNSTHhZTFRjR08xVmZ5a3pUcndoRVkremdodTgyTHF0ek1XcVNZYWYv?= =?utf-8?B?U3VrTEJGYW13MHZqcC9GR1FDU1V0ekxmNENPVHEza0hDVHBWSUNqVUxjVTBF?= =?utf-8?B?MFJDUzJDNDdVR1p3T2JDcmJScEdUQzVYSGxUK3lkSTJzWW9pVG55bGkrbSt1?= =?utf-8?B?YkhiU09FZTl3MXBneElGQVdzdGF6MlVpOUhuTFpSQkY3OVBIcUpOVUE5Wld0?= =?utf-8?B?dnRncjh2Z1g1LytYVGxvZ2VTeURPckg3cEI1TzRtakE5T1V3K29XbDROV2Jx?= =?utf-8?B?Z1ZXejJCVGpBdzRZVE0xc1cwSUlCK0pZVmRCejZkK3ZXL2V5UUg5NytkZHFn?= =?utf-8?B?RVlRejQzYWxGa2hEWVNIVEhNalE1WGs5WEh4Y3N1QkFQSUdYWnZzSnRnVGxv?= =?utf-8?B?QnpRVmJGRkovZzhZQit6ZENYYWhoRGczbk1VNmE0ZEZ6eUZYMlZReDdFME5R?= =?utf-8?B?V0hQaWNJTVY2YkNiS3krZ1hUQUZNNk5xMTJhYzRpOHJubndTMUlZdDB6a2VE?= =?utf-8?B?Z24wemNiRlJORmFiRFdKUG53Qm5wd1RlbFVFUGlWdTIwM1oyUmpKdHNDUW1B?= =?utf-8?B?NTlqdzJRNmFFWDRvNDdCbWpLOXh6a2ZPRDVzRmJncGltWXRsVUsxSHRkNG9t?= =?utf-8?B?ZE1PcGxUVGNiTXhtRzJxb1puTU80MU9Rb2lxVWEwY2pCd0s5MWg5NG55QkI1?= =?utf-8?B?NysxNEZITS9QTWhZVkhUdXlyaDFZMGZnUDU5NXRuK2txTjAzNHBoWEg4dURn?= =?utf-8?B?dUVoem9MTG9DL0xqT2w0bWc5Q1FXSkhGUCt4MTNxaFc1MXQ1aHpEbmNFUmNq?= =?utf-8?B?cXB2ekNSYVFDT3RxUEorWUU5M1ZqdVpEY3VWaCtrWjRlNDgvOWZCTXpmY0l3?= =?utf-8?B?NGR3K0Q4TnVQZGxheXovUFlhaG5QU3hUZmdnaWRVOEYxUm1xUkdVTkdiWUtK?= =?utf-8?B?SWI5dThQb2oxQWRrTVFBMXZ0TTdHbUNrWlJCQnptSTdDNzA3eWZrK2tQTTcz?= =?utf-8?B?dlhMVVcwOUNRNi9tRlNwcmduRTFnMzlMaWo0bWxXaVYrVlZOS3NYWlc4aEJB?= =?utf-8?B?ZXg3WnBxSy84OW43ZmhzODJZbjZ0T3lacGpqUWtnVE1heWZlYmZsUGhDL012?= =?utf-8?Q?QkFtBaxCvfULIKfdEsEVC7wlG?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: f7fc04a9-9a7f-47cd-2203-08dd47a84298 X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6390.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2025 18:50:15.5346 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mtv+FTRlMW0oIygww/3+/I6ObAJCP+5jV6CGPdPg6blCO7lbsKmz0KNNy7LnpjaaEkMi8zOrlYkNKxlJLsMh+Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6636 On 2/6/2025 12:18 PM, Gregory Price wrote: > On Tue, Jan 07, 2025 at 08:38:40AM -0600, Terry Bowman wrote: >> The AER driver and aer_event tracing currently log 'PCIe Bus Type' >> for all errors. >> >> Update the driver and aer_event tracing to log 'CXL Bus Type' for CXL >> device errors. >> >> Signed-off-by: Terry Bowman >> Reviewed-by: Jonathan Cameron >> Reviewed-by: Dave Jiang >> Reviewed-by: Fan Ni > Worth a macro/static function? Wonder what else could use this. > > Reviewed-by: Gregory Price Good idea. Thanks for the 'Reviewed-by`:. Terry