linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Kuppuswamy, Sathyanarayanan"  <sathyanarayanan.kuppuswamy@linux.intel.com>
To: Sean V Kelley <sean.v.kelley@intel.com>,
	bhelgaas@google.com, Jonathan.Cameron@huawei.com,
	xerces.zhao@gmail.com, rafael.j.wysocki@intel.com,
	ashok.raj@intel.com, tony.luck@intel.com,
	sathyanarayanan.kuppuswamy@intel.com, qiuxu.zhuo@intel.com
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v11 08/16] PCI/ERR: Use "bridge" for clarity in pcie_do_recovery()
Date: Tue, 17 Nov 2020 13:59:47 -0800	[thread overview]
Message-ID: <eb655100-68c8-d1e9-9370-9a6f8104f41e@linux.intel.com> (raw)
In-Reply-To: <20201117191954.1322844-9-sean.v.kelley@intel.com>



On 11/17/20 11:19 AM, Sean V Kelley wrote:
> pcie_do_recovery() may be called with "dev" being either a bridge (Root
> Port or Switch Downstream Port) or an Endpoint.  The bulk of the function
> deals with the bridge, so if we start with an Endpoint, we reset "dev" to
> be the bridge leading to it.
> 
> For clarity, replace "dev" in the body of the function with "bridge".  No
> functional change intended.
> 
> [bhelgaas: commit log, split pieces out so this is pure rename, also
> replace "dev" with "bridge" in messages and pci_uevent_ers()]
> Suggested-by: Bjorn Helgaas <bhelgaas@google.com>
> Link: https://lore.kernel.org/r/20201002184735.1229220-6-seanvk.dev@oregontracks.org
> Signed-off-by: Sean V Kelley <sean.v.kelley@intel.com>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
> ---
>   drivers/pci/pcie/err.c | 37 ++++++++++++++++++++-----------------
>   1 file changed, 20 insertions(+), 17 deletions(-)
> 


-- 
Sathyanarayanan Kuppuswamy
Linux Kernel Developer

  reply	other threads:[~2020-11-17 22:00 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-17 19:19 [PATCH v11 00/16] Add RCEC handling to PCI/AER Sean V Kelley
2020-11-17 19:19 ` [PATCH v11 01/16] AER: aer_root_reset() non-native handling Sean V Kelley
2020-11-17 20:04   ` Kuppuswamy, Sathyanarayanan
2020-11-17 19:19 ` [PATCH v11 02/16] PCI/RCEC: Add RCEC class code and extended capability Sean V Kelley
2020-11-17 20:07   ` Kuppuswamy, Sathyanarayanan
2020-11-17 22:39     ` Kelley, Sean V
2020-11-17 19:19 ` [PATCH v11 03/16] PCI/RCEC: Bind RCEC devices to the Root Port driver Sean V Kelley
2020-11-17 20:09   ` Kuppuswamy, Sathyanarayanan
2020-11-17 19:19 ` [PATCH v11 04/16] PCI/RCEC: Cache RCEC capabilities in pci_init_capabilities() Sean V Kelley
2020-11-17 19:19 ` [PATCH v11 05/16] PCI/ERR: Rename reset_link() to reset_subordinates() Sean V Kelley
2020-11-17 20:10   ` Kuppuswamy, Sathyanarayanan
2020-11-17 19:19 ` [PATCH v11 06/16] PCI/ERR: Simplify by using pci_upstream_bridge() Sean V Kelley
2020-11-17 20:11   ` Kuppuswamy, Sathyanarayanan
2020-11-17 19:19 ` [PATCH v11 07/16] PCI/ERR: Simplify by computing pci_pcie_type() once Sean V Kelley
2020-11-17 21:58   ` Kuppuswamy, Sathyanarayanan
2020-11-17 22:47     ` Kelley, Sean V
2020-11-17 19:19 ` [PATCH v11 08/16] PCI/ERR: Use "bridge" for clarity in pcie_do_recovery() Sean V Kelley
2020-11-17 21:59   ` Kuppuswamy, Sathyanarayanan [this message]
2020-11-17 19:19 ` [PATCH v11 09/16] PCI/ERR: Avoid negated conditional for clarity Sean V Kelley
2020-11-17 22:00   ` Kuppuswamy, Sathyanarayanan
2020-11-17 19:19 ` [PATCH v11 10/16] PCI/ERR: Add pci_walk_bridge() to pcie_do_recovery() Sean V Kelley
2020-11-17 19:19 ` [PATCH v11 11/16] PCI/ERR: Limit AER resets in pcie_do_recovery() Sean V Kelley
2020-11-17 19:19 ` [PATCH v11 12/16] PCI/RCEC: Add pcie_link_rcec() to associate RCiEPs Sean V Kelley
2020-11-17 19:19 ` [PATCH v11 13/16] PCI/RCEC: Add RCiEP's linked RCEC to AER/ERR Sean V Kelley
2020-11-17 19:19 ` [PATCH v11 14/16] PCI/AER: Add pcie_walk_rcec() to RCEC AER handling Sean V Kelley
2020-11-18  6:04   ` Kuppuswamy, Sathyanarayanan
2020-11-17 19:19 ` [PATCH v11 15/16] PCI/PME: Add pcie_walk_rcec() to RCEC PME handling Sean V Kelley
2020-11-18  6:03   ` Kuppuswamy, Sathyanarayanan
2020-11-18 16:11     ` Kelley, Sean V
2020-11-17 19:19 ` [PATCH v11 16/16] PCI/AER: Add RCEC AER error injection support Sean V Kelley
2020-11-18  6:02   ` Kuppuswamy, Sathyanarayanan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eb655100-68c8-d1e9-9370-9a6f8104f41e@linux.intel.com \
    --to=sathyanarayanan.kuppuswamy@linux.intel.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=ashok.raj@intel.com \
    --cc=bhelgaas@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=qiuxu.zhuo@intel.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=sathyanarayanan.kuppuswamy@intel.com \
    --cc=sean.v.kelley@intel.com \
    --cc=tony.luck@intel.com \
    --cc=xerces.zhao@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).