From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC2341CB323; Wed, 7 Aug 2024 08:59:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723021170; cv=none; b=PNfM0PgAiXqRV06frclt8ZeSKp3ciF0Dvw1zc3nmQBhGOhDudYcQuvNv+5cObTotVwC1VZ8uuIrDkCKQMG2aQCcRbrUjfQ3k8kR8siVYS86yNYEL8DS541rNIUZihVOuSqRbvU43bc/DtMxNMb0qzNspGzxdkGTOeCJAPhIdLGg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723021170; c=relaxed/simple; bh=6AV/diuPiqIR6+i3otrNsOuiCh/ietYkh63gohM56OM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EOyF51kZ+FXYTmimGLm37OwPfGkSS6y1VBH0Bdu1mpt0fmQn3BrX+4JHG0ktwZr/Q6wj9VKKtWyNfbZPqzpf18f5I875hZLGQgrytYHbPDdDAt+ngzH79FoFPCgRDtc6ZDbN9D1/Ur4w9/Gzn3t90Ilun7PnIGI6/orJoNiEmJs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=I2ZRMmUU; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=YoymDsDx; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=xu+PnEpF; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=YYPY+HhL; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="I2ZRMmUU"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="YoymDsDx"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="xu+PnEpF"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="YYPY+HhL" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id EBD3D21C0B; Wed, 7 Aug 2024 08:59:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1723021167; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=egcnL+OjEgIfVD+ZzmHj3+5ro0ueUWWs23oY+r7Ncjk=; b=I2ZRMmUUpJ8uH6sEpJn8OWl/v2ZZQ8a0DKaqxcqn+9zZ4f7xpFhXjIyXbRXhPt4Ffk3+gv uxKwFa+3OrcVtdMfN0HT3gSfUSKm+GAovmy8oBrlPsl6z/yGIwu284eKcTpboxK63ouXLP zsw2tNfAfROfECLTz/Nm/s+OHwobJ8A= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1723021167; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=egcnL+OjEgIfVD+ZzmHj3+5ro0ueUWWs23oY+r7Ncjk=; b=YoymDsDxUPX4wLhwm+voPe8kD7GsoPhlyv7/aY/uXNhG8ZLfWNvggHEhejFNC5cPpW3xYc us8pQkeb+xPdupBg== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=xu+PnEpF; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=YYPY+HhL DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1723021166; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=egcnL+OjEgIfVD+ZzmHj3+5ro0ueUWWs23oY+r7Ncjk=; b=xu+PnEpFQVK4WK7Lu0mAqhviAUvedztLU0VzlHlShNWw3ZUGghuSzRpl7LKf9CHG6zKm0w LqBMuiu+J/N8JyKXzfQ5lvxnOnSftIbuvNkbaigUY5euxU2JDXM1+kvDhlLPoQr/lG7z5l acEUZDzQbjwzVhZmpQgSlC6V4C1H+1U= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1723021166; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=egcnL+OjEgIfVD+ZzmHj3+5ro0ueUWWs23oY+r7Ncjk=; b=YYPY+HhLUNLsA1BolUtDVcjUbBtL6l3nv0m+YYL4cPa2o+Hmpq/lsJO4aMgslLtJ/ls43W MhqxyMAtzvzfjZDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9A0D613297; Wed, 7 Aug 2024 08:59:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id PCS/I243s2btAgAAD6G6ig (envelope-from ); Wed, 07 Aug 2024 08:59:26 +0000 Message-ID: Date: Wed, 7 Aug 2024 10:59:26 +0200 Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] drm/ast: Request PCI BAR with devres To: Philipp Stanner , Dave Airlie , Jocelyn Falempe , Maarten Lankhorst , Maxime Ripard , David Airlie , Daniel Vetter , Bjorn Helgaas Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org References: <20240807083018.8734-2-pstanner@redhat.com> <20240807083018.8734-4-pstanner@redhat.com> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: <20240807083018.8734-4-pstanner@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Level: X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.50 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; XM_UA_NO_VERSION(0.01)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; FREEMAIL_TO(0.00)[redhat.com,linux.intel.com,kernel.org,gmail.com,ffwll.ch,google.com]; ARC_NA(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MID_RHS_MATCH_FROM(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCPT_COUNT_SEVEN(0.00)[11]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,suse.de:dkim,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo] X-Rspamd-Action: no action X-Spam-Flag: NO X-Spam-Score: -4.50 X-Rspamd-Queue-Id: EBD3D21C0B Am 07.08.24 um 10:30 schrieb Philipp Stanner: > ast currently ioremaps two PCI BARs using pcim_iomap(). It does not > perform a request on the regions, however, which would make the driver a > bit more robust. > > PCI now offers pcim_iomap_region(), a managed function which both > requests and ioremaps a BAR. > > Replace pcim_iomap() with pcim_iomap_region(). > > Suggested-by: Thomas Zimmermann > Signed-off-by: Philipp Stanner Reviewed-by: Thomas Zimmermann > --- > drivers/gpu/drm/ast/ast_drv.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/ast/ast_drv.c b/drivers/gpu/drm/ast/ast_drv.c > index aae019e79bda..1fadaadfbe39 100644 > --- a/drivers/gpu/drm/ast/ast_drv.c > +++ b/drivers/gpu/drm/ast/ast_drv.c > @@ -287,9 +287,9 @@ static int ast_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent) > if (ret) > return ret; > > - regs = pcim_iomap(pdev, 1, 0); > - if (!regs) > - return -EIO; > + regs = pcim_iomap_region(pdev, 1, "ast"); > + if (IS_ERR(regs)) > + return PTR_ERR(regs); > > if (pdev->revision >= 0x40) { > /* > @@ -311,9 +311,9 @@ static int ast_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent) > > if (len < AST_IO_MM_LENGTH) > return -EIO; > - ioregs = pcim_iomap(pdev, 2, 0); > - if (!ioregs) > - return -EIO; > + ioregs = pcim_iomap_region(pdev, 2, "ast"); > + if (IS_ERR(ioregs)) > + return PTR_ERR(ioregs); > } else { > /* > * Anything else is best effort. -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)