From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Simon Horman <horms@verge.net.au>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Subject: Re: [PATCH 2/4] pcie-rcar: remove PHYRDY polling from rcar_pcie_hw_init_h1()
Date: Mon, 9 Apr 2018 18:33:02 +0300 [thread overview]
Message-ID: <ee266a0c-94a1-8f02-64d7-4ee77dde096d@cogentembedded.com> (raw)
In-Reply-To: <20180409105622.cl2joe6yoaozlvpz@verge.net.au>
On 04/09/2018 01:56 PM, Simon Horman wrote:
>> Now that we've added PCIEPHYSR.PHYRDY polling to rcar_pcie_hw_init(),
>> there is no need anymore for polling the PHY specific register in
>> rcar_pcie_hw_init_h1() -- remove it.
>>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> This looks good, but has it been tested?
Unfortunately, no. Yet it fully matches the R-Car H1 manual v1.00.
MBR, Sergei
next prev parent reply other threads:[~2018-04-09 15:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-06 10:58 [PATCH 0/4] Add R8A77980 PCIe support & some driver cleanups Sergei Shtylyov
2018-04-06 11:02 ` [PATCH 1/4] pcie-rcar: poll PHYRDY in rcar_pcie_hw_init() Sergei Shtylyov
2018-04-09 10:54 ` Simon Horman
2018-04-09 10:55 ` Simon Horman
2018-04-09 11:24 ` Simon Horman
2018-04-09 15:45 ` Sergei Shtylyov
2018-04-06 11:04 ` [PATCH 2/4] pcie-rcar: remove PHYRDY polling from rcar_pcie_hw_init_h1() Sergei Shtylyov
2018-04-09 10:56 ` Simon Horman
2018-04-09 15:33 ` Sergei Shtylyov [this message]
2018-04-06 11:08 ` [PATCH 3/4] pcie-rcar: add R-Car gen3 PHY support Sergei Shtylyov
2018-04-07 18:35 ` Sergei Shtylyov
2018-04-09 11:00 ` Simon Horman
2018-04-06 11:10 ` [PATCH 4/4] pcie-rcar: factor out rcar_pcie_hw_init() call Sergei Shtylyov
2018-04-09 8:34 ` Geert Uytterhoeven
2018-04-09 11:04 ` Simon Horman
2018-04-09 15:21 ` Sergei Shtylyov
2018-04-06 11:24 ` [PATCH 0/4] Add R8A77980 PCIe support & some driver cleanups Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee266a0c-94a1-8f02-64d7-4ee77dde096d@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=bhelgaas@google.com \
--cc=horms@verge.net.au \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).