From: Sinan Kaya <okaya@codeaurora.org>
To: Keith Busch <keith.busch@intel.com>, Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH 2/2] pci: Add ignore indicator quirk for devices
Date: Tue, 23 Aug 2016 13:14:03 -0400 [thread overview]
Message-ID: <eed69a47-633b-0c0c-e5c1-663bf37a9ec3@codeaurora.org> (raw)
In-Reply-To: <20160823171018.GB10224@localhost.localdomain>
On 8/23/2016 1:10 PM, Keith Busch wrote:
> It's superficially related to pciehp only because that's the only module
> that touches Slot Control, and this particular hardware interprets
> pciehp's control commands differently than the specification.
>
> Since the hardware can't be changed, is there any guidance you can
> recommend we follow to appropriately fence off pciehp from attention and
> power indicator control? I initially attempted the least invasive method,
> but I'm happy to explore other possibilities.
Most other non-standard HW require an LED driver for hotplug in the kernel.
IBM has one. It sound like you need another one.
static struct hotplug_slot_ops cpci_hotplug_slot_ops = {
.enable_slot = enable_slot,
.disable_slot = disable_slot,
.set_attention_status = set_attention_status,
.get_power_status = get_power_status,
.get_attention_status = get_attention_status,
.get_adapter_status = get_adapter_status,
.get_latch_status = get_latch_status,
};
cpci_hotplug_core.c and ibmphp_core.c.
--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2016-08-23 17:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-08 20:19 [PATCH 1/2] pci: add option to ignore slot capabilities Keith Busch
2016-08-08 20:19 ` [PATCH 2/2] pci: Add ignore indicator quirk for devices Keith Busch
2016-08-15 17:40 ` Bjorn Helgaas
2016-08-15 19:23 ` Keith Busch
2016-08-15 19:50 ` Bjorn Helgaas
2016-08-15 22:35 ` Keith Busch
2016-08-16 3:03 ` Bjorn Helgaas
2016-08-17 21:37 ` Bjorn Helgaas
2016-08-17 23:09 ` Keith Busch
2016-08-18 19:56 ` Bjorn Helgaas
2016-08-18 22:46 ` Keith Busch
2016-08-22 16:55 ` Bjorn Helgaas
2016-08-22 21:15 ` Keith Busch
2016-08-23 13:39 ` Bjorn Helgaas
2016-08-23 17:10 ` Keith Busch
2016-08-23 17:14 ` Sinan Kaya [this message]
2016-08-23 19:23 ` Keith Busch
2016-08-23 19:52 ` Bjorn Helgaas
2016-08-23 20:44 ` Keith Busch
2016-08-23 20:02 ` Bjorn Helgaas
2016-08-24 17:33 ` Keith Busch
2016-08-13 0:03 ` [PATCH 1/2] pci: add option to ignore slot capabilities Sean O. Stalley
2016-08-13 0:58 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eed69a47-633b-0c0c-e5c1-663bf37a9ec3@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=keith.busch@intel.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).