Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Alvaro Karsz <alvaro.karsz@solid-run.com>
Cc: virtualization@lists.linux-foundation.org,
	linux-pci@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	Jean Delvare <jdelvare@suse.com>
Subject: Re: [PATCH 3/3 v4] virtio: vdpa: new SolidNET DPU driver.
Date: Mon, 12 Dec 2022 11:05:00 -0800	[thread overview]
Message-ID: <f02e6f0f-d144-3eed-03e2-e55f459f666c@roeck-us.net> (raw)
In-Reply-To: <CAJs=3_DhEpGjgNZ6+cJiK6WVCQkBYW0V2EvF9vhTW-K6VodB_Q@mail.gmail.com>

On 12/12/22 09:56, Alvaro Karsz wrote:
>> Even better would be a separate CONFIG_SNET_VDPA_HWMON Kconfig option.
> 
> I prefer to wrap everything with a single Kconfig option.
> 
>> depends on HWMON || HWMON=n
> 
> Are you referring here to CONFIG_SNET_VDPA, or to the
> CONFIG_SNET_VDPA_HWMON you suggested?

Either

> Because if this refers to CONFIG_SNET_VDPA, HWMON=m  will block the driver.
> 

No, it won't. It would force SNET_VDPA to be built as module if HWMON
is built as module. Then you would not need IS_REACHABLE but could use
IS_ENABLED instead.

Guenter


  reply	other threads:[~2022-12-12 19:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-12 14:24 [PATCH 0/3] virtio: vdpa: new SolidNET DPU driver Alvaro Karsz
2022-12-12 14:24 ` [PATCH 1/3] Add SolidRun vendor id Alvaro Karsz
2022-12-12 14:24 ` [PATCH 2/3] New PCI quirk for SolidRun SNET DPU Alvaro Karsz
2022-12-12 14:24 ` [PATCH 3/3 v4] virtio: vdpa: new SolidNET DPU driver Alvaro Karsz
2022-12-12 15:01   ` Guenter Roeck
2022-12-12 16:29     ` Alvaro Karsz
2022-12-12 16:38       ` Alvaro Karsz
2022-12-12 17:01       ` Guenter Roeck
2022-12-12 17:46         ` Alvaro Karsz
2022-12-12 17:56           ` Alvaro Karsz
2022-12-12 19:05             ` Guenter Roeck [this message]
2022-12-12 20:17               ` Alvaro Karsz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f02e6f0f-d144-3eed-03e2-e55f459f666c@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=alvaro.karsz@solid-run.com \
    --cc=jasowang@redhat.com \
    --cc=jdelvare@suse.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox