From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F06E4C433E2 for ; Mon, 7 Sep 2020 03:30:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA48521531 for ; Mon, 7 Sep 2020 03:30:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726367AbgIGDaI (ORCPT ); Sun, 6 Sep 2020 23:30:08 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:10776 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726318AbgIGDaH (ORCPT ); Sun, 6 Sep 2020 23:30:07 -0400 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 57BD27BAAAD434CF8B0E; Mon, 7 Sep 2020 11:30:05 +0800 (CST) Received: from [127.0.0.1] (10.174.179.33) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.487.0; Mon, 7 Sep 2020 11:30:02 +0800 Subject: Re: [PATCH] PCI/ACPI: Suppress missing MCFG message To: Jeremy Linton , CC: , , , , , , , , References: <20200904170829.431900-1-jeremy.linton@arm.com> From: Hanjun Guo Message-ID: Date: Mon, 7 Sep 2020 11:30:01 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200904170829.431900-1-jeremy.linton@arm.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.33] X-CFilter-Loop: Reflected Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Hi Jeremy, On 2020/9/5 1:08, Jeremy Linton wrote: > MCFG is an optional ACPI table. Given there are machines > without PCI(e) (or it is hidden) we have been receiving > queries/complaints about what this message means given > its being presented as an error. > > Lets only print an error if something is wrong with the > the given table/etc. The ACPI table list printed at boot > will continue to provide a way to detect when the table > is missing. > > Signed-off-by: Jeremy Linton > --- > drivers/acpi/pci_mcfg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/pci_mcfg.c b/drivers/acpi/pci_mcfg.c > index 54b36b7ad47d..0bc8c012f157 100644 > --- a/drivers/acpi/pci_mcfg.c > +++ b/drivers/acpi/pci_mcfg.c > @@ -279,6 +279,6 @@ static __init int pci_mcfg_parse(struct acpi_table_header *header) > void __init pci_mmcfg_late_init(void) > { > int err = acpi_table_parse(ACPI_SIG_MCFG, pci_mcfg_parse); acpi_table_parse() will return errno -ENODEV and -EINVAL, and only returns -EINVAL if the table id or the handler is NULL, which is impossible here. > - if (err) > + if (err && err != -ENODEV) So the error message below will never be printed, I would prefer update the pr_err() to pr_dbg() for optional ACPI table. > pr_err("Failed to parse MCFG (%d)\n", err); > } Thanks Hanjun