From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA5BF2147EE for ; Wed, 19 Feb 2025 17:58:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739987941; cv=none; b=PquYUSnzFo8zHWYT+g+ml6xYyH8/w2YPaVBExplukVjVcArZkJ8Ulg6ZjIkn8IcKR9zbatYoATt05vT89JUZpcaQoeZN2oWJpqFkPRMmM62hsqcZujrs+rb4y6PVfzKBUjcRjDCcw2vhIdT5ex20XVgDIh00K06dclL7RxxGZPQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739987941; c=relaxed/simple; bh=bca4/lOlAI/66D+6VdDDMQS936BD6LQ3sNTZwS+FImM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BBCm5lAuUP75IBzYQdRx2XS/k1xppUyyBlYHft71dp6Z2dKcnHMJUySqmulekdKvnZc40PoTqE/BlHp1dSQlyR8u35AHHSEzeJrxtyCc8D7Qj4JHLaUXU/Ysi1E7ngC45xQFcsuk1e72pl7ARQqOjlqUcOK4vYel263tyu/myUY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PscXiEyB; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PscXiEyB" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 51JG9WS1031358 for ; Wed, 19 Feb 2025 17:58:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= RZPYXYhznydRoNkH0Kcvg2U8jDI9yURgtXY5VTKjyko=; b=PscXiEyBqT9oImjr DFubEALiRiOyR2Gck+mvk+zM7IYu3Zd6Lu+mYqBLHt6p5SjWEk9/HJVlYhTYQz60 j1QXksRrA3taY8NCfFDngNHvgoop6FXffcl1BBJ43j9eeMSCecXOZwwUo96ARn3j GKZWpVIh45VZbmTsroHh+xzwIHYVrgHh9eLscZ+2BKqxb3FQOgzMvNnZRn5zZQLe n+fCVkTUbKjHERsTCKYqgfwr3nfvcacsSM80R+4uWAQi6hkK2IpOQPF/8HW4Vdd6 ZitGL/o5uWzT+BPlLjhCpJNaqKz9Gt30ZKVpB6jzuH58QsgQHzleB9D1o3fXmZPt NSa0xw== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 44vyy5bgwh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 19 Feb 2025 17:58:58 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-220cb5924a4so224459745ad.2 for ; Wed, 19 Feb 2025 09:58:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739987937; x=1740592737; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RZPYXYhznydRoNkH0Kcvg2U8jDI9yURgtXY5VTKjyko=; b=VcThKEHHt18sSRBM3pekRNZwuAbTyTi/fogCAdfijcGDqUaWXxCkGu/G8b4um/hrR6 1Iesh2J6mqlf36GqPIh3zG3cq/X72X/TgVnXLvnGVJuwDO4WnLrjecS6MK7fjzI+58gz VeFdRU5gDC/5pI5Fw3LBH92OekMM6N/axjXyVZSfp3M+tKRU2K166Y496axonsOq/BYT LilXonXiMXvcKatUwRXkJcSR8iWjYs7AeAs+t24IADhrfRoHiXhSULFd3yHRmKsi/GbJ JIo5uEYiTQyPuV8gBPpc+VFgeCANRl5sbiBGqB5gZBVsRu1imTGNYFhNAXX0Rx5Uqo9I Jh2g== X-Forwarded-Encrypted: i=1; AJvYcCU5kpSUgGqv/qd0RVqlbE9Zpk13vm+ibjEd1zniuMvtXOLLW0AWBS/CyLg464UoMdSE+E++yR0TSZk=@vger.kernel.org X-Gm-Message-State: AOJu0YyUDtRWAob1OtMZCKo8mhXMthBPKX5fPXIkzKxUKrnKUhu7WTlL vDYjiNJH5x4WR3oPewGqnE1SLAtYoXHvgizhfuhUgY58fxNCgZg/oYkSUZt7p2r1iweHAMjrNOp 0Gf5wGt/1WJsDzSxQiRYA5cdRjH+MRHu2SaXdiPXavIUthWUBq+72T0Sdvow= X-Gm-Gg: ASbGncs8fDmkWqz1IE/CCkDDY++CuKJA8XCSVwzOcCYnr023DVYV3pCerownYg+QPcg oVTWKWZVNnCXZaWDmS8COa+qweeGsV2NXP1gCP7+3pTdhiI7sxRN90YUFQYo/uByn7Bfitdre8q iEGQ19fiisiNeW46mYMNOqQsRPVFMoLqn3ac/KnhHIYrx/JKv0E9jww2NW1swXLeJaHyHbSlbw2 kjKW1+XdhOxLspdkI2TZNUTMNrJMqEWl77AYhCMW0DyVzavv6GcpIcdJGNdm4jbtqUvUQLOOVy/ RGtegHBz2a5+K1wUQxH24CVL49dsysoQY18= X-Received: by 2002:a17:902:f543:b0:21f:542e:dd0a with SMTP id d9443c01a7336-221040a99d9mr278372625ad.41.1739987937124; Wed, 19 Feb 2025 09:58:57 -0800 (PST) X-Google-Smtp-Source: AGHT+IHUYFCEoZHriB5wecTnOAu53AMlZezfTLFnsL8ikE+PkMeZB3Iwnzg0FnHSPGIoH3cIgQ5kgg== X-Received: by 2002:a17:902:f543:b0:21f:542e:dd0a with SMTP id d9443c01a7336-221040a99d9mr278372065ad.41.1739987936755; Wed, 19 Feb 2025 09:58:56 -0800 (PST) Received: from [192.168.29.92] ([49.43.231.99]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-220d536b047sm107696615ad.101.2025.02.19.09.58.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Feb 2025 09:58:56 -0800 (PST) Message-ID: Date: Wed, 19 Feb 2025 23:28:47 +0530 Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 4/8] PCI: dwc: qcom: Update ICC & OPP votes based upon the requested speed Content-Language: en-US To: Bjorn Helgaas Cc: Bjorn Helgaas , =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= , Jingoo Han , Manivannan Sadhasivam , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Rob Herring , Johannes Berg , Jeff Johnson , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, mhi@lists.linux.dev, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, quic_jjohnson@quicinc.com, quic_pyarlaga@quicinc.com, quic_vbadigan@quicinc.com, quic_vpernami@quicinc.com, quic_mrana@quicinc.com References: <20250218220728.GA194681@bhelgaas> From: Krishna Chaitanya Chundru In-Reply-To: <20250218220728.GA194681@bhelgaas> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: W9Ly1DiVCEyer1qpzM-E_laNMHkxEbhZ X-Proofpoint-GUID: W9Ly1DiVCEyer1qpzM-E_laNMHkxEbhZ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-19_07,2025-02-19_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 mlxlogscore=999 spamscore=0 bulkscore=0 clxscore=1015 suspectscore=0 adultscore=0 malwarescore=0 mlxscore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2502100000 definitions=main-2502190138 On 2/19/2025 3:37 AM, Bjorn Helgaas wrote: > Make subject line match history for this file. > > On Mon, Feb 17, 2025 at 12:04:11PM +0530, Krishna Chaitanya Chundru wrote: >> QCOM PCIe controllers needs to disable ASPM before initiating link >> re-train. So as part of pre_bw_scale() disable ASPM and as part of >> post_scale_bus_bw() enable ASPM back. > > s/needs/need/ > > Why does Qcom need to disable ASPM? Is there a PCIe spec restriction > about this that should be applied to all PCIe host bridges? Or is > this a Qcom defect? > It is QCOM controller issue, PCIe spec doesn't mention to disable ASPM. >> Update ICC & OPP votes based on the requested speed so that RPMh votes >> gets updated based on the speed. > > s/gets/get/ > >> Bring out the core logic from qcom_pcie_icc_opp_update() to new function >> qcom_pcie_set_icc_opp(). > > This refactoring possibly could be a separate patch to make the meat > of this change clearer. > ack. - Krishna Chaitanya. >> +static int qcom_pcie_set_icc_opp(struct qcom_pcie *pcie, int speed, int width) >> +{ >> + struct dw_pcie *pci = pcie->pci; >> + unsigned long freq_kbps; >> + struct dev_pm_opp *opp; >> + int ret, freq_mbps; >> + >> + if (pcie->icc_mem) { >> + ret = icc_set_bw(pcie->icc_mem, 0, >> + width * QCOM_PCIE_LINK_SPEED_TO_BW(speed)); >> + if (ret) { >> + dev_err(pci->dev, "Failed to set bandwidth for PCIe-MEM interconnect path: %d\n", >> + ret); >> + } >> + } else if (pcie->use_pm_opp) { >> + freq_mbps = pcie_dev_speed_mbps(pcie_link_speed[speed]); >> + if (freq_mbps < 0) >> + return -EINVAL; >> + >> + freq_kbps = freq_mbps * KILO; >> + opp = dev_pm_opp_find_freq_exact(pci->dev, freq_kbps * width, >> + true); >> + if (!IS_ERR(opp)) { >> + ret = dev_pm_opp_set_opp(pci->dev, opp); >> + if (ret) >> + dev_err(pci->dev, "Failed to set OPP for freq (%lu): %d\n", >> + freq_kbps * width, ret); >> + dev_pm_opp_put(opp); >> + } >> + } >> + >> + return ret; > > Looks uninitialized in some paths.