Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Damien Le Moal <dlemoal@kernel.org>
To: kernel test robot <lkp@intel.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-pci@vger.kernel.org,
	Bjorn Helgaas <helgaas@kernel.org>
Subject: Re: [pci:enumeration 28/28] drivers/mfd/intel-lpss-pci.c:57:49: error: 'PCI_IRQ_LEGACY' undeclared; did you mean 'NR_IRQS_LEGACY'?
Date: Tue, 26 Mar 2024 20:52:36 +0900	[thread overview]
Message-ID: <f13e9775-9dca-4a8f-b6bb-6d5a8f6dbccd@kernel.org> (raw)
In-Reply-To: <202403261840.1RP419n5-lkp@intel.com>

On 3/26/24 19:19, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git enumeration
> head:   8694697a54096ae97eb38bf4144f2d96c64c68f2
> commit: 8694697a54096ae97eb38bf4144f2d96c64c68f2 [28/28] PCI: Remove PCI_IRQ_LEGACY
> config: i386-buildonly-randconfig-001-20240326 (https://download.01.org/0day-ci/archive/20240326/202403261840.1RP419n5-lkp@intel.com/config)
> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240326/202403261840.1RP419n5-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202403261840.1RP419n5-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/mfd/intel-lpss-pci.c: In function 'intel_lpss_pci_probe':
>>> drivers/mfd/intel-lpss-pci.c:57:49: error: 'PCI_IRQ_LEGACY' undeclared (first use in this function); did you mean 'NR_IRQS_LEGACY'?
>       57 |         ret = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_LEGACY);
>          |                                                 ^~~~~~~~~~~~~~
>          |                                                 NR_IRQS_LEGACY
>    drivers/mfd/intel-lpss-pci.c:57:49: note: each undeclared identifier is reported only once for each function it appears in

Bjorn,

Not sure what is going on here. I did an allyesconfig build on x86_64 and did
not see such issue. Did the build bot missed some patches ?

And the above also reminds me that we could change NR_IRQS_LEGACY to
NR_IRQS_INTX too.

-- 
Damien Le Moal
Western Digital Research


  reply	other threads:[~2024-03-26 11:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-26 10:19 [pci:enumeration 28/28] drivers/mfd/intel-lpss-pci.c:57:49: error: 'PCI_IRQ_LEGACY' undeclared; did you mean 'NR_IRQS_LEGACY'? kernel test robot
2024-03-26 11:52 ` Damien Le Moal [this message]
2024-03-26 21:13   ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f13e9775-9dca-4a8f-b6bb-6d5a8f6dbccd@kernel.org \
    --to=dlemoal@kernel.org \
    --cc=helgaas@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox