From: Logan Gunthorpe <logang@deltatee.com>
To: Shawn Lin <shawn.lin@rock-chips.com>,
Bjorn Helgaas <bhelgaas@google.com>
Cc: Nirmal Patel <nirmal.patel@linux.intel.com>,
Jonathan Derrick <jonathan.derrick@linux.dev>,
Kurt Schwemmer <kurt.schwemmer@microsemi.com>,
Philipp Stanner <phasta@kernel.org>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v2 2/3] PCI: switchtec: Replace pci_alloc_irq_vectors() with pcim_alloc_irq_vectors()
Date: Fri, 17 Apr 2026 09:16:46 -0600 [thread overview]
Message-ID: <f232e368-2546-4206-97f4-dfdfea636a05@deltatee.com> (raw)
In-Reply-To: <1776392767-83668-3-git-send-email-shawn.lin@rock-chips.com>
On 2026-04-16 8:26 p.m., Shawn Lin wrote:
> Replace pci_alloc_irq_vectors() with pcim_alloc_irq_vectors() to
> explicitly request devres-managed interrupt vectors. This makes the
> driver's intention clear and avoids the ambiguous implicit management
> previously provided by pcim_enable_device().
>
> The change prepares the driver for the eventual removal of the hybrid
> IRQ management pattern from pcim_enable_device(), ensuring consistent
> resource management through devres.
>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
This direction makes sense to me. I remember thinking it was odd that
pci_alloc_ir_vectors() was applicable to managed cases without the pcim
prefix. Thanks!
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
next prev parent reply other threads:[~2026-04-17 15:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-17 2:26 [PATCH v2 0/3] Add Devres managed IRQ vectors allocation Shawn Lin
2026-04-17 2:26 ` [PATCH v2 1/3] PCI/MSI: " Shawn Lin
2026-04-17 6:10 ` Frank Li
2026-04-17 6:32 ` Shawn Lin
2026-04-17 8:44 ` Philipp Stanner
2026-04-17 9:33 ` Shawn Lin
2026-04-20 9:28 ` Philipp Stanner
2026-04-20 9:52 ` Shawn Lin
2026-04-17 2:26 ` [PATCH v2 2/3] PCI: switchtec: Replace pci_alloc_irq_vectors() with pcim_alloc_irq_vectors() Shawn Lin
2026-04-17 15:16 ` Logan Gunthorpe [this message]
2026-04-17 2:26 ` [PATCH v2 3/3] PCI: vmd: " Shawn Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f232e368-2546-4206-97f4-dfdfea636a05@deltatee.com \
--to=logang@deltatee.com \
--cc=bhelgaas@google.com \
--cc=jonathan.derrick@linux.dev \
--cc=kurt.schwemmer@microsemi.com \
--cc=linux-pci@vger.kernel.org \
--cc=nirmal.patel@linux.intel.com \
--cc=phasta@kernel.org \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox