From: Sinan Kaya <okaya@codeaurora.org>
To: Alex_Gagniuc@Dellteam.com, mr.nuke.me@gmail.com, bhelgaas@google.com
Cc: Austin.Bolen@dell.com, Shyam.Iyer@dell.com,
keith.busch@intel.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: Check for PCIe downtraining conditions
Date: Thu, 31 May 2018 11:38:13 -0400 [thread overview]
Message-ID: <f260078b-6918-7fd9-39d6-e9f300e4c048@codeaurora.org> (raw)
In-Reply-To: <4e0611c872054e768daa96b302651db3@ausx13mps321.AMER.DELL.COM>
On 5/31/2018 11:29 AM, Alex_Gagniuc@Dellteam.com wrote:
> On 5/31/2018 10:28 AM, Sinan Kaya wrote:
>> On 5/31/2018 11:05 AM, Alexandru Gagniuc wrote:
>>> +static void pcie_max_link_cap(struct pci_dev *dev, enum pci_bus_speed *speed,
>>> + enum pcie_link_width *width)
>>> +{
>>> + uint32_t lnkcap;
>>> +
>>> + pcie_capability_read_dword(dev, PCI_EXP_LNKCAP, &lnkcap);
>>> +
>>> + *speed = pcie_link_speed[lnkcap & PCI_EXP_LNKCAP_SLS];
>>> + *width = (lnkcap & PCI_EXP_LNKCAP_MLW) >> PCI_EXP_LNKCAP_MLW_SHIFT;
>>> +}
>>> +
>>> +static void pcie_cur_link_sta(struct pci_dev *dev, enum pci_bus_speed *speed,
>>> + enum pcie_link_width *width)
>>> +{
>>> + uint16_t lnksta;
>>> +
>>> + pcie_capability_read_word(dev, PCI_EXP_LNKSTA, &lnksta);
>>> + *speed = pcie_link_speed[lnksta & PCI_EXP_LNKSTA_CLS];
>>> + *width = (lnksta & PCI_EXP_LNKSTA_NLW) >> PCI_EXP_LNKSTA_NLW_SHIFT;
>>> +}
>>> +
>>> +static const char *pcie_bus_speed_name(enum pci_bus_speed speed)
>>> +{
>>> + switch (speed) {
>>> + case PCIE_SPEED_2_5GT:
>>> + return "2.5 GT/s";
>>> + case PCIE_SPEED_5_0GT:
>>> + return "5.0 GT/s";
>>> + case PCIE_SPEED_8_0GT:
>>> + return "8.0 GT/s";
>>> + default:
>>> + return "unknown";
>>> + }
>>> +}
>>
>> I thought Bjorn added some functions to retrieve this now.
>
> Hmm. I couldn't find them.
https://lkml.org/lkml/2018/3/30/553
are you working on linux-next?
>
> Alex
>
>
--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2018-05-31 15:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-31 15:05 [PATCH] PCI: Check for PCIe downtraining conditions Alexandru Gagniuc
2018-05-31 15:28 ` Sinan Kaya
2018-05-31 15:29 ` Alex_Gagniuc
2018-05-31 15:38 ` Sinan Kaya [this message]
2018-05-31 15:46 ` Alex G.
2018-05-31 15:54 ` Sinan Kaya
2018-05-31 16:01 ` Alex G.
2018-05-31 16:13 ` Sinan Kaya
2018-05-31 16:49 ` Alex G.
2018-05-31 16:50 ` Alex G.
2018-05-31 17:11 ` Sinan Kaya
2018-05-31 17:27 ` Alex G.
2018-05-31 21:52 ` Alex G.
2018-05-31 15:30 ` Sinan Kaya
2018-05-31 21:44 ` Alex G.
2018-06-01 13:30 ` Sinan Kaya
2018-06-02 17:42 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f260078b-6918-7fd9-39d6-e9f300e4c048@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=Alex_Gagniuc@Dellteam.com \
--cc=Austin.Bolen@dell.com \
--cc=Shyam.Iyer@dell.com \
--cc=bhelgaas@google.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mr.nuke.me@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).