linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: "Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
	"Manivannan Sadhasivam" <mani@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	linux-pci@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] PCI: Drop ARM dependency from PCI_RCAR_GEN2
Date: Fri, 3 Oct 2025 16:57:01 +0300 (EEST)	[thread overview]
Message-ID: <f2bbca79-8b96-2fff-48ba-64b4fd4372b3@linux.intel.com> (raw)
In-Reply-To: <00f75d6732eacce93f04ffaeedc415d2db714cd6.1759480426.git.geert+renesas@glider.be>

[-- Attachment #1: Type: text/plain, Size: 1634 bytes --]

On Fri, 3 Oct 2025, Geert Uytterhoeven wrote:

> Since the reliance on ARM-specific struct pci_sys_data was removed, this
> driver can be compile-tested on other architectures.
> 
> While at it, make the help text a bit more generic, as some members of
> the R-Car Gen2 family have a different number of internal PCI
> controllers.
> 
> Suggested-by: Ilpo Jarvinen <ilpo.jarvinen@linux.intel.com>
> Fixes: 4a957563fe0231e0 ("PCI: rcar-gen2: Convert to use modern host bridge probe functions")

I'm not sure if fixes tag is warranted for "fixing" COMPILE_TEST.

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  drivers/pci/controller/Kconfig | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
> index 9f9d0c93cb461831..4c15caa1f1798ebb 100644
> --- a/drivers/pci/controller/Kconfig
> +++ b/drivers/pci/controller/Kconfig
> @@ -259,12 +259,11 @@ config PCIE_RCAR_EP
>  
>  config PCI_RCAR_GEN2
>  	bool "Renesas R-Car Gen2 Internal PCI controller"
> -	depends on ARCH_RENESAS || COMPILE_TEST
> -	depends on ARM
> +	depends on (ARCH_RENESAS && ARM) || COMPILE_TEST
>  	help
>  	  Say Y here if you want internal PCI support on R-Car Gen2 SoC.
> -	  There are 3 internal PCI controllers available with a single
> -	  built-in EHCI/OHCI host controller present on each one.
> +	  Each internal PCI controller contains a single built-in EHCI/OHCI
> +	  host controller.
>  
>  config PCIE_ROCKCHIP
>  	bool
> 

-- 
 i.

  reply	other threads:[~2025-10-03 13:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-03  8:35 [PATCH] PCI: Drop ARM dependency from PCI_RCAR_GEN2 Geert Uytterhoeven
2025-10-03 13:57 ` Ilpo Järvinen [this message]
2025-10-20  5:51 ` Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f2bbca79-8b96-2fff-48ba-64b4fd4372b3@linux.intel.com \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=bhelgaas@google.com \
    --cc=geert+renesas@glider.be \
    --cc=kwilczynski@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=mani@kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).