linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] PCI: Drop ARM dependency from PCI_RCAR_GEN2
@ 2025-10-03  8:35 Geert Uytterhoeven
  2025-10-03 13:57 ` Ilpo Järvinen
  2025-10-20  5:51 ` Manivannan Sadhasivam
  0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2025-10-03  8:35 UTC (permalink / raw)
  To: Ilpo Jarvinen, Lorenzo Pieralisi, Krzysztof Wilczyński,
	Manivannan Sadhasivam, Rob Herring, Bjorn Helgaas
  Cc: linux-pci, linux-renesas-soc, Geert Uytterhoeven

Since the reliance on ARM-specific struct pci_sys_data was removed, this
driver can be compile-tested on other architectures.

While at it, make the help text a bit more generic, as some members of
the R-Car Gen2 family have a different number of internal PCI
controllers.

Suggested-by: Ilpo Jarvinen <ilpo.jarvinen@linux.intel.com>
Fixes: 4a957563fe0231e0 ("PCI: rcar-gen2: Convert to use modern host bridge probe functions")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/pci/controller/Kconfig | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
index 9f9d0c93cb461831..4c15caa1f1798ebb 100644
--- a/drivers/pci/controller/Kconfig
+++ b/drivers/pci/controller/Kconfig
@@ -259,12 +259,11 @@ config PCIE_RCAR_EP
 
 config PCI_RCAR_GEN2
 	bool "Renesas R-Car Gen2 Internal PCI controller"
-	depends on ARCH_RENESAS || COMPILE_TEST
-	depends on ARM
+	depends on (ARCH_RENESAS && ARM) || COMPILE_TEST
 	help
 	  Say Y here if you want internal PCI support on R-Car Gen2 SoC.
-	  There are 3 internal PCI controllers available with a single
-	  built-in EHCI/OHCI host controller present on each one.
+	  Each internal PCI controller contains a single built-in EHCI/OHCI
+	  host controller.
 
 config PCIE_ROCKCHIP
 	bool
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] PCI: Drop ARM dependency from PCI_RCAR_GEN2
  2025-10-03  8:35 [PATCH] PCI: Drop ARM dependency from PCI_RCAR_GEN2 Geert Uytterhoeven
@ 2025-10-03 13:57 ` Ilpo Järvinen
  2025-10-20  5:51 ` Manivannan Sadhasivam
  1 sibling, 0 replies; 3+ messages in thread
From: Ilpo Järvinen @ 2025-10-03 13:57 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Lorenzo Pieralisi, Krzysztof Wilczyński,
	Manivannan Sadhasivam, Rob Herring, Bjorn Helgaas, linux-pci,
	linux-renesas-soc

[-- Attachment #1: Type: text/plain, Size: 1634 bytes --]

On Fri, 3 Oct 2025, Geert Uytterhoeven wrote:

> Since the reliance on ARM-specific struct pci_sys_data was removed, this
> driver can be compile-tested on other architectures.
> 
> While at it, make the help text a bit more generic, as some members of
> the R-Car Gen2 family have a different number of internal PCI
> controllers.
> 
> Suggested-by: Ilpo Jarvinen <ilpo.jarvinen@linux.intel.com>
> Fixes: 4a957563fe0231e0 ("PCI: rcar-gen2: Convert to use modern host bridge probe functions")

I'm not sure if fixes tag is warranted for "fixing" COMPILE_TEST.

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  drivers/pci/controller/Kconfig | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
> index 9f9d0c93cb461831..4c15caa1f1798ebb 100644
> --- a/drivers/pci/controller/Kconfig
> +++ b/drivers/pci/controller/Kconfig
> @@ -259,12 +259,11 @@ config PCIE_RCAR_EP
>  
>  config PCI_RCAR_GEN2
>  	bool "Renesas R-Car Gen2 Internal PCI controller"
> -	depends on ARCH_RENESAS || COMPILE_TEST
> -	depends on ARM
> +	depends on (ARCH_RENESAS && ARM) || COMPILE_TEST
>  	help
>  	  Say Y here if you want internal PCI support on R-Car Gen2 SoC.
> -	  There are 3 internal PCI controllers available with a single
> -	  built-in EHCI/OHCI host controller present on each one.
> +	  Each internal PCI controller contains a single built-in EHCI/OHCI
> +	  host controller.
>  
>  config PCIE_ROCKCHIP
>  	bool
> 

-- 
 i.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] PCI: Drop ARM dependency from PCI_RCAR_GEN2
  2025-10-03  8:35 [PATCH] PCI: Drop ARM dependency from PCI_RCAR_GEN2 Geert Uytterhoeven
  2025-10-03 13:57 ` Ilpo Järvinen
@ 2025-10-20  5:51 ` Manivannan Sadhasivam
  1 sibling, 0 replies; 3+ messages in thread
From: Manivannan Sadhasivam @ 2025-10-20  5:51 UTC (permalink / raw)
  To: Ilpo Jarvinen, Lorenzo Pieralisi, Krzysztof Wilczyński,
	Rob Herring, Bjorn Helgaas, Geert Uytterhoeven
  Cc: linux-pci, linux-renesas-soc


On Fri, 03 Oct 2025 10:35:34 +0200, Geert Uytterhoeven wrote:
> Since the reliance on ARM-specific struct pci_sys_data was removed, this
> driver can be compile-tested on other architectures.
> 
> While at it, make the help text a bit more generic, as some members of
> the R-Car Gen2 family have a different number of internal PCI
> controllers.
> 
> [...]

Applied, thanks!

[1/1] PCI: Drop ARM dependency from PCI_RCAR_GEN2
      commit: bd4e28f711a0c218641f72bb1602a2c8b9d36274

Best regards,
-- 
Manivannan Sadhasivam <mani@kernel.org>


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-10-20  5:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-03  8:35 [PATCH] PCI: Drop ARM dependency from PCI_RCAR_GEN2 Geert Uytterhoeven
2025-10-03 13:57 ` Ilpo Järvinen
2025-10-20  5:51 ` Manivannan Sadhasivam

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).