Re: [PATCH] PCI: release empty sibling resources during bridge window resize

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 5983 bytes --]

On Thu, 9 Apr 2026, Geramy Loveless wrote:

> Perfect I’ll get started on these changes, while I’m here, does the other bug create
> a cascade of problems if fixed? 

Hi,

I'm not sure what "other bug" refers to?

If you meant Cristian problem, he seemed to have empty bridge windows 
which this approach should be able to solve without extra problems 
expected.

If you refer to the resource entries having dangling resource tree 
pointers (sibling, etc.), it's not a big problem when the resource entry 
has been detached from the tree. It has some impact on whether 
resource_assigned() can always be trusted so it would be nice to clear all 
those links on removal (the current remove algorithm shortcuts the 
subtree).

-- 
 i.

> On Thu, Apr 9, 2026 at 1:03 AM Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> wrote:
>       On Wed, 8 Apr 2026, Geramy Loveless wrote:
> 
>       Thanks for the patch. The patch need some work but the general direction
>       looks acceptable.
> 
>       FYI, your patch is misformatted, tabs got eaten, probably something in
>       tha way you send the email does that.
> 
>       Please Cc also Cristian Cocos <cristi@ieee.org> on further submissions.
> 
>       > When pci_resize_resource() walks up the bridge hierarchy via
>       > pbus_reassign_bridge_resources(), bridge windows with any child
>       > resources are refused release. This prevents BAR resize on devices
>       > behind multi-port PCIe switches (such as Thunderbolt docks) where
>       > empty sibling downstream ports hold small reservations that block the
>       > parent bridge window from being freed and re-sized.
>       >
>       > Add pci_bus_release_bridge_resources_safe() which verifies that a
>       > resource subtree contains no active children before releasing it,
>       > and use it in pbus_reassign_bridge_resources() to clear empty sibling
>       > reservations so the bridge window can grow.
>       >
>       > Signed-off-by: Geramy Loveless <gloveless@jqluv.com>
> 
>       You may want to add Suggested-by tag.
> 
>       > ---
>       > drivers/pci/setup-bus.c | 30 +++++++++++++++++++++++++++---
>       > 1 file changed, 27 insertions(+), 3 deletions(-)
>       >
>       > diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c
>       > index 4cf120ebe..9a3a23819 100644
>       > --- a/drivers/pci/setup-bus.c
>       > +++ b/drivers/pci/setup-bus.c
>       > @@ -2297,6 +2297,30 @@
>       > EXPORT_SYMBOL_GPL(pci_assign_unassigned_bridge_resources);
>       > * release it when possible. If the bridge window contains assigned
>       > * resources, it cannot be released.
>       > */
>       > +
>       > +/*
>       > + * Release child resources from a bridge window so it can be freed and
>       > + * re-sized, but only if the entire subtree is empty (no active device
>       > + * resources underneath). Walks the resource tree recursively to
>       handle
>       > + * arbitrarily deep bridge hierarchies. Returns true if the resources
>       > + * were released or the window was already empty.
>       > + */
>       > +static bool pci_bus_release_bridge_resources_safe(struct pci_bus *bus,
>       > + struct resource *res)
>       > +{
>       > + struct resource *child;
>       > +
>       > + for (child = res->child; child; child = child->sibling) {
>       > + if (child->child &&
>       > + !pci_bus_release_bridge_resources_safe(bus, child))
>       > + return false;
> 
>       This should walk bus devices and device resources using PCI side
>       iterators (not using the low-level resource list). This does not look
>       safe iteration anyway because the code is also removing entries from the
>       resource tree (it only works because resource code leaves stale sibling
>       pointers which should be corrected one day).
> 
>       PCI side should be enough to capture all resources, and that way you
>       still have access to all PCI side structs.
> 
>       Perhaps sanity checking ! ->child at the end wouldn't hurt but it the
>       release should be doable.
> 
>       You should also pass the saved list and store any released resources so
>       you can properly rollback in case of a failure (I think the rollback
>       code will already just-work as long as you add the entries there).
> 
>       > + }
>       > +
>       > + if (res->child)
>       > + pci_bus_release_bridge_resources(bus, res, whole_subtree);
> 
>       I think this could pass non-bridge window resources which looks wrong but
>       you need to rewrite the algorithm in this function anyway.
> 
>       > + return true;
>       > +}
>       > +
>       > static int pbus_reassign_bridge_resources(struct pci_bus *bus, struct
>       > resource *res,
>       > struct list_head *saved)
>       > {
>       > @@ -2316,8 +2340,8 @@ static int pbus_reassign_bridge_resources(struct
>       > pci_bus *bus, struct resource *
>       > i = pci_resource_num(bridge, res);
>       > - /* Ignore BARs which are still in use */
>       > - if (!res->child) {
>       > + if (!res->child ||
>       > + pci_bus_release_bridge_resources_safe(bridge->subordinate, res)) {
> 
>       Just call this release always before checking !res->child.
> 
>       You need to check bridge->subordinate before calling it.
> 
>       > ret = pci_dev_res_add_to_list(saved, bridge, res, 0, 0);
>       > if (ret)
>       > return ret;
>       > @@ -2327,7 +2351,7 @@ static int pbus_reassign_bridge_resources(struct
>       > pci_bus *bus, struct resource *
>       > const char *res_name = pci_resource_name(bridge, i);
>       > pci_warn(bridge,
>       > - "%s %pR: was not released (still contains assigned resources)\n",
>       > + "%s %pR: not released, active children present\n",
>       > res_name, res);
>       > }
>       >
> 
>       --
>        i.
> 
> 
>