linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sinan Kaya <okaya@kernel.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH v6 3/7] PCI: Expose reset_type to users of pci_reset_function_locked()
Date: Fri, 19 Oct 2018 18:18:37 -0400	[thread overview]
Message-ID: <f430e49e-7008-4320-f967-5078616a04b8@kernel.org> (raw)
In-Reply-To: <20181019202028.GB105697@bhelgaas-glaptop.roam.corp.google.com>

On 10/19/2018 4:20 PM, Bjorn Helgaas wrote:
>> +int pci_reset_function_locked(struct pci_dev *dev, u32 reset_type);
> There are no callers of this.  Why are we updating it rather than
> removing it?
> 

I'll remove this function on another patch.

I transition all __pci_reset_function_locked users
to pci_reset_function_locked()  first.

Then all pci_reset_function_locked() users to pci_reset_function().

Then, git rid of pci_reset_function_locked() at last step.

  reply	other threads:[~2018-10-19 22:18 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-19  2:11 [PATCH v6 1/7] PCI: Expose reset_type to users of __pci_reset_function_locked() Sinan Kaya
2018-10-19  2:11 ` [PATCH v6 2/7] PCI: Expose reset_type to users of pci_reset_function() Sinan Kaya
2018-10-19  2:11 ` [PATCH v6 3/7] PCI: Expose reset_type to users of pci_reset_function_locked() Sinan Kaya
2018-10-19 20:20   ` Bjorn Helgaas
2018-10-19 22:18     ` Sinan Kaya [this message]
2018-10-19  2:11 ` [PATCH v6 4/7] PCI: Expose reset type to users of pci_try_reset_function() Sinan Kaya
2018-10-19 20:14   ` Bjorn Helgaas
2018-10-19 20:21     ` Brian Norris
2018-10-19  2:11 ` [PATCH v6 5/7] PCI: Expose reset type to users of pci_probe_reset_function() Sinan Kaya
2018-10-19  2:11 ` [PATCH v6 6/7] PCI: Expose reset type to users of pci_reset_bus() Sinan Kaya
2018-10-19  2:11 ` [PATCH v6 7/7] IB/hfi1,PCI: switch to __pci_function_locked() for reset request Sinan Kaya
2018-10-19 13:10   ` Doug Ledford
2018-10-20  2:09 ` [PATCH v6 1/7] PCI: Expose reset_type to users of __pci_reset_function_locked() Bjorn Helgaas
2018-10-20  2:58   ` Sinan Kaya
2018-10-20 15:03     ` Bjorn Helgaas
2018-10-20 16:21       ` Sinan Kaya
2018-11-08 20:31       ` Alex Williamson
2018-11-08 21:13         ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f430e49e-7008-4320-f967-5078616a04b8@kernel.org \
    --to=okaya@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=helgaas@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).