From: Sathyanarayanan Kuppuswamy <sathyanarayanan.kuppuswamy@linux.intel.com>
To: Wilfred Mallawa <wilfred.opensource@gmail.com>,
bhelgaas@google.com, mika.westerberg@linux.intel.com,
lukas@wunner.de, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: alistair.francis@wdc.com, wilfred.mallawa@wdc.com,
dlemoal@kernel.org, cassel@kernel.org
Subject: Re: [PATCH v2] PCI: fix the printed delay amount in info print
Date: Sun, 13 Apr 2025 17:46:50 -0700 [thread overview]
Message-ID: <f435b1c3-4f97-4898-9533-3a83f74cc14a@linux.intel.com> (raw)
In-Reply-To: <20250414001505.21243-2-wilfred.opensource@gmail.com>
On 4/13/25 5:15 PM, Wilfred Mallawa wrote:
> From: Wilfred Mallawa <wilfred.mallawa@wdc.com>
>
> Print the delay amount that pcie_wait_for_link_delay() is invoked with
> instead of the hardcoded 1000ms value in the debug info print.
>
> Fixes: 7b3ba09febf4 ("PCI/PM: Shorten pci_bridge_wait_for_secondary_bus() wait time for slow links")
> Signed-off-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
> Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
> ---
Reviewed-by: Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>
> drivers/pci/pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index 869d204a70a3..8139b70cafa9 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -4935,7 +4935,7 @@ int pci_bridge_wait_for_secondary_bus(struct pci_dev *dev, char *reset_type)
> delay);
> if (!pcie_wait_for_link_delay(dev, true, delay)) {
> /* Did not train, no need to wait any further */
> - pci_info(dev, "Data Link Layer Link Active not set in 1000 msec\n");
> + pci_info(dev, "Data Link Layer Link Active not set in %d msec\n", delay);
> return -ENOTTY;
> }
>
--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer
next prev parent reply other threads:[~2025-04-14 0:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-14 0:15 [PATCH v2] PCI: fix the printed delay amount in info print Wilfred Mallawa
2025-04-14 0:46 ` Sathyanarayanan Kuppuswamy [this message]
2025-04-14 4:40 ` Mika Westerberg
2025-04-14 13:01 ` Ilpo Järvinen
2025-04-17 20:26 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f435b1c3-4f97-4898-9533-3a83f74cc14a@linux.intel.com \
--to=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=alistair.francis@wdc.com \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mika.westerberg@linux.intel.com \
--cc=wilfred.mallawa@wdc.com \
--cc=wilfred.opensource@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox