From: Markus Elfring <Markus.Elfring@web.de>
To: "Thippeswamy Havalige" <thippeswamy.havalige@amd.com>,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Conor Dooley" <conor+dt@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Rob Herring" <robh@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Bharat Kumar Gogada <bharat.kumar.gogada@amd.com>,
Jingoo Han <jingoohan1@gmail.com>,
Michal Simek <michal.simek@amd.com>
Subject: Re: [PATCH v8 3/3] PCI: amd-mdb: Add AMD MDB Root Port driver
Date: Wed, 5 Feb 2025 16:10:29 +0100 [thread overview]
Message-ID: <f5462109-1603-4866-895c-b5c349261296@web.de> (raw)
In-Reply-To: <20250129113029.64841-4-thippeswamy.havalige@amd.com>
…
> +++ b/drivers/pci/controller/dwc/pcie-amd-mdb.c
> @@ -0,0 +1,476 @@
…
> +static void amd_mdb_mask_intx_irq(struct irq_data *data)
> +{
…
> + raw_spin_lock_irqsave(&port->lock, flags);
> + val = pcie_read(pcie, AMD_MDB_TLP_IR_MASK_MISC);
> + pcie_write(pcie, (val & (~mask)), AMD_MDB_TLP_IR_ENABLE_MISC);
> + raw_spin_unlock_irqrestore(&port->lock, flags);
> +}
…
Under which circumstances would you become interested to apply a statement
like “guard(raw_spinlock_irqsave)(&port->lock);”?
https://elixir.bootlin.com/linux/v6.13.1/source/include/linux/spinlock.h#L551
Regards,
Markus
next prev parent reply other threads:[~2025-02-05 15:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-29 11:30 [PATCH v8 0/3] Add support for AMD MDB IP as Root Port Thippeswamy Havalige
2025-01-29 11:30 ` [PATCH v8 1/3] dt-bindings: PCI: dwc: Add AMD Versal2 mdb slcr support Thippeswamy Havalige
2025-01-29 11:30 ` [PATCH v8 2/3] dt-bindings: PCI: amd-mdb: Add AMD Versal2 MDB PCIe Root Port Bridge Thippeswamy Havalige
2025-01-29 11:30 ` [PATCH v8 3/3] PCI: amd-mdb: Add AMD MDB Root Port driver Thippeswamy Havalige
2025-02-03 6:23 ` Havalige, Thippeswamy
2025-02-03 17:41 ` Manivannan Sadhasivam
2025-02-03 18:28 ` Bjorn Helgaas
2025-02-04 9:37 ` Havalige, Thippeswamy
2025-02-04 22:11 ` Bjorn Helgaas
2025-02-05 11:37 ` Havalige, Thippeswamy
2025-02-05 11:53 ` Havalige, Thippeswamy
2025-02-05 14:20 ` Bjorn Helgaas
2025-02-07 16:45 ` Havalige, Thippeswamy
2025-02-05 15:10 ` Markus Elfring [this message]
2025-02-06 16:07 ` Havalige, Thippeswamy
2025-02-06 20:26 ` Bjorn Helgaas
2025-02-07 6:39 ` [v8 " Markus Elfring
2025-02-07 6:59 ` Manivannan Sadhasivam
2025-02-07 9:45 ` Markus Elfring
2025-02-11 23:16 ` Bjorn Helgaas
2025-02-12 5:36 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5462109-1603-4866-895c-b5c349261296@web.de \
--to=markus.elfring@web.de \
--cc=bharat.kumar.gogada@amd.com \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jingoohan1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=michal.simek@amd.com \
--cc=robh@kernel.org \
--cc=thippeswamy.havalige@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox