Re: [PATCH] PCI/MSI: Handle the NOMASK flag correctly for all PCI/MSI backends

["Jürgen Groß" <jgross@suse.com>]

[-- Attachment #1.1.1: Type: text/plain, Size: 1028 bytes --]

On 26.03.25 13:05, Thomas Gleixner wrote:
> The conversion of the XEN specific global variable pci_msi_ignore_mask to a
> MSI domain flag, missed the facts that:
> 
>      1) Legacy architectures do not provide a interrupt domain
>      2) Parent MSI domains do not necessarily have a domain info attached
>     
> Both cases result in an unconditional NULL pointer dereference.
> 
> Cure this by using the existing pci_msi_domain_supports() helper, which
> handles all possible cases correctly.
> 
> Fixes: c3164d2e0d18 ("PCI/MSI: Convert pci_msi_ignore_mask to per MSI domain flag")
> Reported-by: Daniel Gomez <da.gomez@kernel.org>
> Reported-by: Borislav Petkov <bp@alien8.de>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Tested-by: Borislav Petkov <bp@alien8.de>
> Tested-by: Daniel Gomez <da.gomez@kernel.org>

As the patch introducing the problem went in via the Xen tree, should
this fix go in via the Xen tree, too?


Juergen

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3743 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]