From: Krzysztof Kozlowski <krzk@kernel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Sai Krishna Musham <sai.krishna.musham@amd.com>
Cc: bhelgaas@google.com, lpieralisi@kernel.org, kw@linux.com,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
cassel@kernel.org, linux-pci@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
michal.simek@amd.com, bharat.kumar.gogada@amd.com,
thippeswamy.havalige@amd.com
Subject: Re: [PATCH v6 2/2] PCI: xilinx-cpm: Add support for PCIe RP PERST# signal
Date: Thu, 27 Mar 2025 19:08:29 +0100 [thread overview]
Message-ID: <f65db82b-fedb-43d8-9d61-53e1bacda3ba@kernel.org> (raw)
In-Reply-To: <cjrb3idrj3x7vo4fujl6nakj3foyu64gtxwovmxd4qvovvhwqq@26bpt5b4zjao>
On 27/03/2025 18:25, Manivannan Sadhasivam wrote:
>> /**
>> @@ -551,6 +600,27 @@ static int xilinx_cpm_pcie_parse_dt(struct xilinx_cpm_pcie *port,
>> port->reg_base = port->cfg->win;
>> }
>>
>> + port->crx_base = devm_platform_ioremap_resource_byname(pdev,
>> + "cpm_crx");
>> + if (IS_ERR(port->crx_base)) {
>> + if (PTR_ERR(port->crx_base) == -EINVAL)
>> + port->crx_base = NULL;
>> + else
>> + return PTR_ERR(port->crx_base);
>> + }
>> +
>> + if (port->variant->version == CPM5NC_HOST) {
>> + port->cpm5nc_attr_base =
>> + devm_platform_ioremap_resource_byname(pdev,
>> + "cpm5nc_attr");
>
> Where is this resource defined in the binding?
>
So this is v6 and still not tested.
Where is the DTS using this binding and driver, so we can verify that
AMD is not sending us such totally bogus, downstream code?
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-03-27 18:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-26 2:28 [PATCH v6 0/2] Add support for PCIe RP PERST# Sai Krishna Musham
2025-03-26 2:28 ` [PATCH v6 1/2] dt-bindings: PCI: xilinx-cpm: Add reset-gpios " Sai Krishna Musham
2025-03-26 7:45 ` Krzysztof Kozlowski
2025-03-26 9:52 ` Musham, Sai Krishna
2025-03-26 2:28 ` [PATCH v6 2/2] PCI: xilinx-cpm: Add support for PCIe RP PERST# signal Sai Krishna Musham
2025-03-27 17:25 ` Manivannan Sadhasivam
2025-03-27 18:08 ` Krzysztof Kozlowski [this message]
2025-04-04 7:03 ` Musham, Sai Krishna
2025-04-04 7:11 ` Krzysztof Kozlowski
2025-04-13 4:22 ` Musham, Sai Krishna
2025-04-04 6:59 ` Musham, Sai Krishna
2025-04-09 6:55 ` Manivannan Sadhasivam
2025-04-13 4:28 ` Musham, Sai Krishna
2025-04-15 7:13 ` Manivannan Sadhasivam
2025-04-22 6:39 ` Musham, Sai Krishna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f65db82b-fedb-43d8-9d61-53e1bacda3ba@kernel.org \
--to=krzk@kernel.org \
--cc=bharat.kumar.gogada@amd.com \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=michal.simek@amd.com \
--cc=robh@kernel.org \
--cc=sai.krishna.musham@amd.com \
--cc=thippeswamy.havalige@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox