From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D62F6C433B4 for ; Thu, 29 Apr 2021 07:15:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A0FCC61431 for ; Thu, 29 Apr 2021 07:15:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230309AbhD2HQV (ORCPT ); Thu, 29 Apr 2021 03:16:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230174AbhD2HQV (ORCPT ); Thu, 29 Apr 2021 03:16:21 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56CB3C06138B for ; Thu, 29 Apr 2021 00:15:35 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id u17so98429886ejk.2 for ; Thu, 29 Apr 2021 00:15:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=0Vhaiy7KCk4dhjU0COHqgaZ+NZlSEN30UxiwPliDRtM=; b=ED1SqQfZQc6dnAUKQNu7JxD5YmxjJj4VXgnAZgJg0IgHmue4DzMf55YPFELnv4ruZJ PYZIrGME+hiLPkamcuCFKbZ1EuOBPp6tA1A606NYfPAsu5/p9Wvh8NvMLb7vpGagi8Ev mfjtqEFnP4fgCZ1TmZsxR2oeRQr65QX3lnLqyuZ/GDY6L0qZ8IdTAiu1Gi5e9PBQpi16 kCP2dHp3WSx8PzGT7zU7tJDWIE409tOGW4LOmNnt+Yhz7vW4BaR9gloOrjxftJDWVAgP fUVwwWfL/AQQNFYpfqh5qIysoeaUy/kNM3P+Y7nVxneBwY2OjFIGCgRyeUkMiGuE3Fht Dsrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=0Vhaiy7KCk4dhjU0COHqgaZ+NZlSEN30UxiwPliDRtM=; b=hN0FyKilOJyQI2Dly4QDTVNCD3JA4hq56yYQMUCE4nbbWDxJn1FZisjssIGsJpd7xz 3UWZJG4CG59tRXgiszC1mtA85hYvbJQq3OQ7yu7cxQrpy2RiNbkg2T76nuYVSJJxcni5 54kv2mJn0MDk2EofFA5jZtVce21CS8cUFXOUzhcPMdC87xg7K98jpFQ4NlAex17bnDgt 7GBetfvy/CSdbxf3xlxtAKx3Y/8aY2aOhlo983N/zJgTD/Rg3kb1WW3FFrdaMXnn1ewN INFDzWQTEp0FFyrDxzailnndCMgZXkm7KabusVs0yHeL6TdSimPaEo3nBo+jjd2oYYIE B1qA== X-Gm-Message-State: AOAM530tqxpGVrjo7HrMviNJBOSFpr3bs8LjHGZdshdEehGYi9Jj7R9z PSY0Jxj0JIRS1hTOsh917YM= X-Google-Smtp-Source: ABdhPJyWkpxf2itDYnMgYqeb1O/hEOB6obny5mrQqWh3lb5YA4ecvpsCg0JWreVNFmINA/ObBFa1EA== X-Received: by 2002:a17:907:174a:: with SMTP id lf10mr11077236ejc.433.1619680534092; Thu, 29 Apr 2021 00:15:34 -0700 (PDT) Received: from ?IPv6:2a02:908:1252:fb60:49f7:8b5a:d7ab:5e3e? ([2a02:908:1252:fb60:49f7:8b5a:d7ab:5e3e]) by smtp.gmail.com with ESMTPSA id n10sm1264425ejg.124.2021.04.29.00.15.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Apr 2021 00:15:33 -0700 (PDT) Subject: Re: [PATCH v5 13/27] drm/amdgpu: When filizing the fence driver. stop scheduler first. To: Andrey Grodzovsky , dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-pci@vger.kernel.org, daniel.vetter@ffwll.ch, Harry.Wentland@amd.com Cc: ppaalanen@gmail.com, Alexander.Deucher@amd.com, gregkh@linuxfoundation.org, helgaas@kernel.org, Felix.Kuehling@amd.com References: <20210428151207.1212258-1-andrey.grodzovsky@amd.com> <20210428151207.1212258-14-andrey.grodzovsky@amd.com> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: Date: Thu, 29 Apr 2021 09:15:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210428151207.1212258-14-andrey.grodzovsky@amd.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Filizing the fences? You mean finishing the fences, don't you? :) Am 28.04.21 um 17:11 schrieb Andrey Grodzovsky: > No point calling amdgpu_fence_wait_empty before stopping the > SW scheduler otherwise there is always a chance another job sneaked > in after the wait. > > Signed-off-by: Andrey Grodzovsky > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c > index 34d51e962799..fd9282637549 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c > @@ -533,6 +533,12 @@ void amdgpu_fence_driver_fini_hw(struct amdgpu_device *adev) > > if (!ring || !ring->fence_drv.initialized) > continue; > + > + /* Stop any new job submissions from sched before flushing the ring */ > + /* TODO Handle amdgpu_job_submit_direct and amdgpu_amdkfd_submit_ib */ > + if (!ring->no_scheduler) > + drm_sched_fini(&ring->sched); > + > r = amdgpu_fence_wait_empty(ring); > if (r) { > /* no need to trigger GPU reset as we are unloading */ > @@ -541,8 +547,7 @@ void amdgpu_fence_driver_fini_hw(struct amdgpu_device *adev) > if (ring->fence_drv.irq_src) > amdgpu_irq_put(adev, ring->fence_drv.irq_src, > ring->fence_drv.irq_type); > - if (!ring->no_scheduler) > - drm_sched_fini(&ring->sched); > + > del_timer_sync(&ring->fence_drv.fallback_timer); > } > }