* [PATCH 0/2] New VMD Device ids
@ 2020-01-06 22:41 Sushma Kalakota
2020-01-06 22:41 ` [PATCH 1/2] PCI: vmd: Add device id for VMD device 8086:4C3D Sushma Kalakota
2020-01-06 22:41 ` [PATCH 2/2] PCI: vmd: Add device id for VMD device 8086:467F Sushma Kalakota
0 siblings, 2 replies; 5+ messages in thread
From: Sushma Kalakota @ 2020-01-06 22:41 UTC (permalink / raw)
To: Lorenzo Pieralisi
Cc: Jonathan Derrick, Bjorn Helgaas, linux-pci, Sushma Kalakota
This set adds new VMD device ids
Sushma Kalakota (2):
PCI: vmd: Add device id for VMD device 8086:4C3D
PCI: vmd: Add device id for VMD device 8086:467F
drivers/pci/controller/vmd.c | 4 ++++
include/linux/pci_ids.h | 2 ++
2 files changed, 6 insertions(+)
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] PCI: vmd: Add device id for VMD device 8086:4C3D
2020-01-06 22:41 [PATCH 0/2] New VMD Device ids Sushma Kalakota
@ 2020-01-06 22:41 ` Sushma Kalakota
2020-01-06 22:41 ` [PATCH 2/2] PCI: vmd: Add device id for VMD device 8086:467F Sushma Kalakota
1 sibling, 0 replies; 5+ messages in thread
From: Sushma Kalakota @ 2020-01-06 22:41 UTC (permalink / raw)
To: Lorenzo Pieralisi
Cc: Jonathan Derrick, Bjorn Helgaas, linux-pci, Sushma Kalakota
This patch adds support for this VMD device which supports the bus
restriction mode.
Signed-off-by: Jon Derrick <jonathan.derrick@intel.com>
Signed-off-by: Sushma Kalakota <sushmax.kalakota@intel.com>
---
drivers/pci/controller/vmd.c | 2 ++
include/linux/pci_ids.h | 1 +
2 files changed, 3 insertions(+)
diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/controller/vmd.c
index 212842263f55..2b192e72f550 100644
--- a/drivers/pci/controller/vmd.c
+++ b/drivers/pci/controller/vmd.c
@@ -868,6 +868,8 @@ static const struct pci_device_id vmd_ids[] = {
{PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VMD_28C0),
.driver_data = VMD_FEAT_HAS_MEMBAR_SHADOW |
VMD_FEAT_HAS_BUS_RESTRICTIONS,},
+ {PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VMD_4C3D),
+ .driver_data = VMD_FEAT_HAS_BUS_RESTRICTIONS,},
{PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VMD_9A0B),
.driver_data = VMD_FEAT_HAS_BUS_RESTRICTIONS,},
{0,}
diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
index 2302d133af6f..8b3bc4b545b9 100644
--- a/include/linux/pci_ids.h
+++ b/include/linux/pci_ids.h
@@ -2957,6 +2957,7 @@
#define PCI_DEVICE_ID_INTEL_SBRIDGE_BR 0x3cf5 /* 13.6 */
#define PCI_DEVICE_ID_INTEL_SBRIDGE_SAD1 0x3cf6 /* 12.7 */
#define PCI_DEVICE_ID_INTEL_IOAT_SNB 0x402f
+#define PCI_DEVICE_ID_INTEL_VMD_4C3D 0x4c3d
#define PCI_DEVICE_ID_INTEL_5100_16 0x65f0
#define PCI_DEVICE_ID_INTEL_5100_19 0x65f3
#define PCI_DEVICE_ID_INTEL_5100_21 0x65f5
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] PCI: vmd: Add device id for VMD device 8086:467F
2020-01-06 22:41 [PATCH 0/2] New VMD Device ids Sushma Kalakota
2020-01-06 22:41 ` [PATCH 1/2] PCI: vmd: Add device id for VMD device 8086:4C3D Sushma Kalakota
@ 2020-01-06 22:41 ` Sushma Kalakota
2020-01-07 19:13 ` Keith Busch
1 sibling, 1 reply; 5+ messages in thread
From: Sushma Kalakota @ 2020-01-06 22:41 UTC (permalink / raw)
To: Lorenzo Pieralisi
Cc: Jonathan Derrick, Bjorn Helgaas, linux-pci, Sushma Kalakota
This patch adds support for this VMD device which supports the bus
restriction mode.
Signed-off-by: Jon Derrick <jonathan.derrick@intel.com>
Signed-off-by: Sushma Kalakota <sushmax.kalakota@intel.com>
---
drivers/pci/controller/vmd.c | 2 ++
include/linux/pci_ids.h | 1 +
2 files changed, 3 insertions(+)
diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/controller/vmd.c
index 2b192e72f550..9433bd387fdd 100644
--- a/drivers/pci/controller/vmd.c
+++ b/drivers/pci/controller/vmd.c
@@ -868,6 +868,8 @@ static const struct pci_device_id vmd_ids[] = {
{PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VMD_28C0),
.driver_data = VMD_FEAT_HAS_MEMBAR_SHADOW |
VMD_FEAT_HAS_BUS_RESTRICTIONS,},
+ {PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VMD_467F),
+ .driver_data = VMD_FEAT_HAS_BUS_RESTRICTIONS,},
{PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VMD_4C3D),
.driver_data = VMD_FEAT_HAS_BUS_RESTRICTIONS,},
{PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VMD_9A0B),
diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
index 8b3bc4b545b9..aac007c60f87 100644
--- a/include/linux/pci_ids.h
+++ b/include/linux/pci_ids.h
@@ -2957,6 +2957,7 @@
#define PCI_DEVICE_ID_INTEL_SBRIDGE_BR 0x3cf5 /* 13.6 */
#define PCI_DEVICE_ID_INTEL_SBRIDGE_SAD1 0x3cf6 /* 12.7 */
#define PCI_DEVICE_ID_INTEL_IOAT_SNB 0x402f
+#define PCI_DEVICE_ID_INTEL_VMD_467F 0x467f
#define PCI_DEVICE_ID_INTEL_VMD_4C3D 0x4c3d
#define PCI_DEVICE_ID_INTEL_5100_16 0x65f0
#define PCI_DEVICE_ID_INTEL_5100_19 0x65f3
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] PCI: vmd: Add device id for VMD device 8086:467F
2020-01-06 22:41 ` [PATCH 2/2] PCI: vmd: Add device id for VMD device 8086:467F Sushma Kalakota
@ 2020-01-07 19:13 ` Keith Busch
2020-01-07 19:22 ` Derrick, Jonathan
0 siblings, 1 reply; 5+ messages in thread
From: Keith Busch @ 2020-01-07 19:13 UTC (permalink / raw)
To: Sushma Kalakota
Cc: Lorenzo Pieralisi, Jonathan Derrick, Bjorn Helgaas, linux-pci
On Mon, Jan 06, 2020 at 03:41:22PM -0700, Sushma Kalakota wrote:
> This patch adds support for this VMD device which supports the bus
> restriction mode.
Suggested rephrasing to an imperative voice:
Add new VMD device IDs that require the bus restriction mode.
> Signed-off-by: Jon Derrick <jonathan.derrick@intel.com>
> Signed-off-by: Sushma Kalakota <sushmax.kalakota@intel.com>
The first sign-off should be the author, but there's no "From:" header
line for Jon. Is the attribution correct?
> @@ -868,6 +868,8 @@ static const struct pci_device_id vmd_ids[] = {
> {PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VMD_28C0),
> .driver_data = VMD_FEAT_HAS_MEMBAR_SHADOW |
> VMD_FEAT_HAS_BUS_RESTRICTIONS,},
> + {PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VMD_467F),
> + .driver_data = VMD_FEAT_HAS_BUS_RESTRICTIONS,},
> {PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VMD_4C3D),
> .driver_data = VMD_FEAT_HAS_BUS_RESTRICTIONS,},
Since you know all the new device ids, might as well collapse this patch
with the first one from this series.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] PCI: vmd: Add device id for VMD device 8086:467F
2020-01-07 19:13 ` Keith Busch
@ 2020-01-07 19:22 ` Derrick, Jonathan
0 siblings, 0 replies; 5+ messages in thread
From: Derrick, Jonathan @ 2020-01-07 19:22 UTC (permalink / raw)
To: kbusch@kernel.org, Kalakota, SushmaX
Cc: lorenzo.pieralisi@arm.com, linux-pci@vger.kernel.org,
helgaas@kernel.org
Thanks Keith,
On Tue, 2020-01-07 at 12:13 -0700, Keith Busch wrote:
> On Mon, Jan 06, 2020 at 03:41:22PM -0700, Sushma Kalakota wrote:
> > This patch adds support for this VMD device which supports the bus
> > restriction mode.
>
> Suggested rephrasing to an imperative voice:
>
> Add new VMD device IDs that require the bus restriction mode.
>
Sure
> > Signed-off-by: Jon Derrick <jonathan.derrick@intel.com>
> > Signed-off-by: Sushma Kalakota <sushmax.kalakota@intel.com>
>
> The first sign-off should be the author, but there's no "From:" header
> line for Jon. Is the attribution correct?
We both worked on this, though it was primarily Sushma.
We'll switch the attribution order per
https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin
>
> > @@ -868,6 +868,8 @@ static const struct pci_device_id vmd_ids[] = {
> > {PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VMD_28C0),
> > .driver_data = VMD_FEAT_HAS_MEMBAR_SHADOW |
> > VMD_FEAT_HAS_BUS_RESTRICTIONS,},
> > + {PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VMD_467F),
> > + .driver_data = VMD_FEAT_HAS_BUS_RESTRICTIONS,},
> > {PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VMD_4C3D),
> > .driver_data = VMD_FEAT_HAS_BUS_RESTRICTIONS,},
>
> Since you know all the new device ids, might as well collapse this patch
> with the first one from this series.
Sure
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-01-07 19:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-06 22:41 [PATCH 0/2] New VMD Device ids Sushma Kalakota
2020-01-06 22:41 ` [PATCH 1/2] PCI: vmd: Add device id for VMD device 8086:4C3D Sushma Kalakota
2020-01-06 22:41 ` [PATCH 2/2] PCI: vmd: Add device id for VMD device 8086:467F Sushma Kalakota
2020-01-07 19:13 ` Keith Busch
2020-01-07 19:22 ` Derrick, Jonathan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).