From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC6ED27BF93 for ; Mon, 24 Nov 2025 14:36:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763994998; cv=none; b=tjoUICbFYAudf0fg5yZ6DBa61gFzQeULUzol5RCdtq49+bsiIgp/5rDDJVRZMXqxVwaOq80KoQeyGqHqsUzb6nssgoHxn2VkFFpNql2QchHv5U/Ujx1PSm6TguEJ06/OLUz8dGbh0uuHLm3kwUfcpdaIYsLfhZzajXwxwAOdP44= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763994998; c=relaxed/simple; bh=wSQ341CU5vsOctNXexpEakv7qkoHtZ0v3orCbR3i2WA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fG4gAA7FiSPaccKSOF1ZEml46jpjgeOOeOGOFwk7zQSLECeC4CfLIh3qBK3c3kACVinlSluFyhr5C6fRhVqoFSM6nOroAk0atuFRUa5t0z6pC6jXsMrmq6cm3zWc7GlqIPoyj6RPxOVBgeIrf+7lli6EuYtFWALqoOjsELJPjLA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KXbHvO/9; arc=none smtp.client-ip=209.85.208.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KXbHvO/9" Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-6418738efa0so6787416a12.1 for ; Mon, 24 Nov 2025 06:36:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763994995; x=1764599795; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DMHuhLQ2+QePhLbxyyov6Mwfn5dk2KsNTjCwuBZ/B2U=; b=KXbHvO/9ol0/OiDNK7qOJvewM69cUrLRJMwl2GueEzDPO8a0jnZvVd0yM11GYlfMk0 eTi/gIEsE4lZrCBv0TN9OXsjpNO4hMRdtxSbcXgycLhx4eXiPll8tVH6sDcwR+GT6GJC nTYPifOBMNFvhBV7Mrj/bx0TWAK958UXs/m4b6XBvCQkDwZcoIZyOx0RDxNEYEbkasb3 YtlQnEp2fEaUEdcPM0552kgGbYKAYv1NA4fxoxIKqueuyGu5rJPZQ3v+ldK9WdCbbGaC iSkWasyWrTPePI0EK0Q3oURrQJh32VhHP9xZ7v70G9K/M97i+eTpwp0eOx2mSBvaXX5Y MUTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763994995; x=1764599795; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DMHuhLQ2+QePhLbxyyov6Mwfn5dk2KsNTjCwuBZ/B2U=; b=vpHOxZ0NTcSBkDOBBRWo9WWj1mv0GsTrqD7Jv/UVrIxha4HPElvoqv9ZtxW7R517YV kO/BD86/e2pzt9p9CrexaF+m0VJAs3dIn5qV5kbVEs+M8hLXbi6GAn73o5TScNSP6zfm yR3pwhgwGUSszw9mbICLgx1r0okN6Xf8P1A7UsyMQ33v6g3JcRU/GhFnVNktTBolxBgf dUG7f864t2Adv4nFJadYSCqt4EhXDWSu/ZoYjUMKq4MJLOhEPJD2K3GNg+BBDMcEdKpQ 1TPs4mcx2bpTR3bcuIAFhSsBk6s2zYeN87PNl7XhyUXt+IT38bZCycefolgs6G95V/VL CwVQ== X-Forwarded-Encrypted: i=1; AJvYcCWx8L0YWVxbzj8Bj/OEMI4GcsBWWdrp7qPnZfU0FwUx87m14geT8YG5ot6CK6tF45vmWvji2o8gIno=@vger.kernel.org X-Gm-Message-State: AOJu0YxA6cWPGhKoyFz/VT0ebXWyRTFVOYKNQCHfR6y3iuDxX28JVL6v jtfYWmXrjs/6hQDOFpR6uhjvzYas2BzlaMt+IxeFNNJ5mr90TvTtSc4HEJ11Rqr/ X-Gm-Gg: ASbGncv5KRC3noum/v0az63dPK0Y0nWZ6bm2/+95LS5fpqa3hLvY8m6GNf/zdmlrCX5 UD3safwBSxWJPXj5PwMxjrb9n4Dte7dGfLNLgWSnWVxH0PLTMvQVF47272JDInVmkBhPBKhWPKA /A7rxatJx/2i8XfVL4K18whACEBN4y0o/89CRCY1XfaNWJ9FCAVbviB10lBQDYDPoztqvcUQX3P jM9Aqvhhx26oo9m2WuH0uqWU/S0tmRTjeXReTyQirJ2SF03zJuXTD2E2YuJUGAoVspsfLYQ2Uvy sJJWKRsAtR1KMMdd3R1Dz/1VD/IbMKNBQQQ0/j5UOPu4LDmY5BKf4Rvm4UzQyUbIoHET1NaHic1 6OdG/Tpn+6ySL8tJHRQzxJpQsL0cn62xJYJ7gT9buP+qZW8K8V5ERKaVs1TSWWGJ4Q70B96xTsT 7W3ep0tSlxEXaZMg== X-Google-Smtp-Source: AGHT+IGs/95/cJ+tL3SsaiiXXgcuCaeuAg21ZTVttRpATbc8iAWB4Al2D0iS745iUZOaE4uems77rg== X-Received: by 2002:a2e:95d9:0:b0:37a:5bc6:ab9f with SMTP id 38308e7fff4ca-37cd92392c8mr23746331fa.26.1763989401463; Mon, 24 Nov 2025 05:03:21 -0800 (PST) Received: from [10.38.18.76] ([213.255.186.37]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-37cc6b48e26sm27317291fa.1.2025.11.24.05.03.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Nov 2025 05:03:21 -0800 (PST) Message-ID: Date: Mon, 24 Nov 2025 15:03:19 +0200 Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 01/29] Revert "treewide: Fix probing of devices in DT overlays" To: Herve Codina , Andrew Lunn , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Michael Turquette , Stephen Boyd , Andi Shyti , Wolfram Sang , Peter Rosin , Arnd Bergmann , Saravana Kannan , Bjorn Helgaas , Charles Keepax , Richard Fitzgerald , David Rhodes , Linus Walleij , Ulf Hansson , Mark Brown , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Len Brown , Davidlohr Bueso , Jonathan Cameron , Dave Jiang , Alison Schofield , Vishal Verma , Ira Weiny , Dan Williams , Geert Uytterhoeven Cc: Wolfram Sang , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-i2c@vger.kernel.org, linux-pci@vger.kernel.org, linux-sound@vger.kernel.org, patches@opensource.cirrus.com, linux-gpio@vger.kernel.org, linux-pm@vger.kernel.org, linux-spi@vger.kernel.org, linux-acpi@vger.kernel.org, linux-cxl@vger.kernel.org, Allan Nielsen , Horatiu Vultur , Steen Hegelund , Luca Ceresoli , Thomas Petazzoni References: <20251015071420.1173068-1-herve.codina@bootlin.com> <20251015071420.1173068-2-herve.codina@bootlin.com> Content-Language: en-US From: Kalle Niemi In-Reply-To: <20251015071420.1173068-2-herve.codina@bootlin.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/15/25 10:13, Herve Codina wrote: > From: Saravana Kannan > > This reverts commit 1a50d9403fb90cbe4dea0ec9fd0351d2ecbd8924. > > While the commit fixed fw_devlink overlay handling for one case, it > broke it for another case. So revert it and redo the fix in a separate > patch. > > Fixes: 1a50d9403fb9 ("treewide: Fix probing of devices in DT overlays") > Reported-by: Herve Codina > Closes: https://lore.kernel.org/lkml/CAMuHMdXEnSD4rRJ-o90x4OprUacN_rJgyo8x6=9F9rZ+-KzjOg@mail.gmail.com/ > Closes: https://lore.kernel.org/all/20240221095137.616d2aaa@bootlin.com/ > Closes: https://lore.kernel.org/lkml/20240312151835.29ef62a0@bootlin.com/ > Signed-off-by: Saravana Kannan > Link: https://lore.kernel.org/lkml/20240411235623.1260061-2-saravanak@google.com/ > Signed-off-by: Herve Codina > Acked-by: Mark Brown > --- > drivers/bus/imx-weim.c | 6 ------ > drivers/i2c/i2c-core-of.c | 5 ----- > drivers/of/dynamic.c | 1 - > drivers/of/platform.c | 5 ----- > drivers/spi/spi.c | 5 ----- > 5 files changed, 22 deletions(-) > > diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c > index 83d623d97f5f..87070155b057 100644 > --- a/drivers/bus/imx-weim.c > +++ b/drivers/bus/imx-weim.c > @@ -327,12 +327,6 @@ static int of_weim_notify(struct notifier_block *nb, unsigned long action, > "Failed to setup timing for '%pOF'\n", rd->dn); > > if (!of_node_check_flag(rd->dn, OF_POPULATED)) { > - /* > - * Clear the flag before adding the device so that > - * fw_devlink doesn't skip adding consumers to this > - * device. > - */ > - rd->dn->fwnode.flags &= ~FWNODE_FLAG_NOT_DEVICE; > if (!of_platform_device_create(rd->dn, NULL, &pdev->dev)) { > dev_err(&pdev->dev, > "Failed to create child device '%pOF'\n", > diff --git a/drivers/i2c/i2c-core-of.c b/drivers/i2c/i2c-core-of.c > index eb7fb202355f..30b48a428c0b 100644 > --- a/drivers/i2c/i2c-core-of.c > +++ b/drivers/i2c/i2c-core-of.c > @@ -176,11 +176,6 @@ static int of_i2c_notify(struct notifier_block *nb, unsigned long action, > return NOTIFY_OK; > } > > - /* > - * Clear the flag before adding the device so that fw_devlink > - * doesn't skip adding consumers to this device. > - */ > - rd->dn->fwnode.flags &= ~FWNODE_FLAG_NOT_DEVICE; > client = of_i2c_register_device(adap, rd->dn); > if (IS_ERR(client)) { > dev_err(&adap->dev, "failed to create client for '%pOF'\n", > diff --git a/drivers/of/dynamic.c b/drivers/of/dynamic.c > index 2eaaddcb0ec4..b5be7484fb36 100644 > --- a/drivers/of/dynamic.c > +++ b/drivers/of/dynamic.c > @@ -225,7 +225,6 @@ static void __of_attach_node(struct device_node *np) > np->sibling = np->parent->child; > np->parent->child = np; > of_node_clear_flag(np, OF_DETACHED); > - np->fwnode.flags |= FWNODE_FLAG_NOT_DEVICE; > > raw_spin_unlock_irqrestore(&devtree_lock, flags); > > diff --git a/drivers/of/platform.c b/drivers/of/platform.c > index f77cb19973a5..ef9445ba168b 100644 > --- a/drivers/of/platform.c > +++ b/drivers/of/platform.c > @@ -739,11 +739,6 @@ static int of_platform_notify(struct notifier_block *nb, > if (of_node_check_flag(rd->dn, OF_POPULATED)) > return NOTIFY_OK; > > - /* > - * Clear the flag before adding the device so that fw_devlink > - * doesn't skip adding consumers to this device. > - */ > - rd->dn->fwnode.flags &= ~FWNODE_FLAG_NOT_DEVICE; > /* pdev_parent may be NULL when no bus platform device */ > pdev_parent = of_find_device_by_node(parent); > pdev = of_platform_device_create(rd->dn, NULL, > diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c > index 2e0647a06890..b22944a207c9 100644 > --- a/drivers/spi/spi.c > +++ b/drivers/spi/spi.c > @@ -4791,11 +4791,6 @@ static int of_spi_notify(struct notifier_block *nb, unsigned long action, > return NOTIFY_OK; > } > > - /* > - * Clear the flag before adding the device so that fw_devlink > - * doesn't skip adding consumers to this device. > - */ > - rd->dn->fwnode.flags &= ~FWNODE_FLAG_NOT_DEVICE; > spi = of_register_spi_device(ctlr, rd->dn); > put_device(&ctlr->dev); > Sorry, some of you will receive this message now for second time. First message was sent to older series of patches. - Hello, Test system testing drivers for ROHM ICs bisected this commit to cause BD71847 drivers probe to not be called. The devicetree blob overlay describing bd71847 enables I2C1 bus on BeagleBone Black aswell. Probe is called when the driver is used with HW connected to I2C2 bus. I2C2 bus is enabled before overlaying devicetree blobs. ---- BD71847 Devicetree overlay source ---- /dts-v1/; /plugin/; /{ /* this is our device tree overlay root node */ compatible = "ti,beaglebone", "ti,beaglebone-black"; part-number = "BBB-I2C1"; version = "00A0"; fragment@0 { target = <&am33xx_pinmux>; // this is a link to an already defined node in the device tree, so that node is overlayed with our modification __overlay__ { i2c1_pins: pinmux_i2c1_pins { pinctrl-single,pins = < 0x158 0x72 /* spi0_d1.i2c1_sda */ 0x15C 0x72 /* spi0_cs0.i2c1_sdl */ >; }; }; }; .... .... fragment@2 { target = <&i2c1>; __overlay__ { pinctrl-0 = <&i2c1_pins>; clock-frequency = <100000>; status = "okay"; pmic: pmic@4b { /* the "test" defined as child of the i2c1 bus */ compatible = "rohm,bd71847"; reg = <0x4b>; .... .... }; /* root node end */ ---- END OF BD71847 Devicetree overlay source ---- Reverting this patch from linux-next from last friday fixes the issue. BR Kalle Niemi